[INFO] updating cached repository dmdrummond/mandelbrot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dmdrummond/mandelbrot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dmdrummond/mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/dmdrummond/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dmdrummond/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dmdrummond/mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmdrummond/mandelbrot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmdrummond/mandelbrot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8dd70ffe7f24420dedc3787400755898f43178c8 [INFO] sha for GitHub repo dmdrummond/mandelbrot: 8dd70ffe7f24420dedc3787400755898f43178c8 [INFO] validating manifest of dmdrummond/mandelbrot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dmdrummond/mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dmdrummond/mandelbrot [INFO] finished frobbing dmdrummond/mandelbrot [INFO] frobbed toml for dmdrummond/mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/dmdrummond/mandelbrot/Cargo.toml [INFO] started frobbing dmdrummond/mandelbrot [INFO] finished frobbing dmdrummond/mandelbrot [INFO] frobbed toml for dmdrummond/mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dmdrummond/mandelbrot/Cargo.toml [INFO] crate dmdrummond/mandelbrot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dmdrummond/mandelbrot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dmdrummond/mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 81a9f3697018bba052c7164eb2affb065a1bb55009c75375ebf1f59e75f725d6 [INFO] running `"docker" "start" "-a" "81a9f3697018bba052c7164eb2affb065a1bb55009c75375ebf1f59e75f725d6"` [INFO] [stderr] Checking rayon-core v1.3.0 [INFO] [stderr] Checking num-bigint v0.1.41 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking mandelbrot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let x_factor = 3.5 / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | let y_factor = 2.0 / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Complex::new((x as f64 * x_factor) - 2.5, (y as f64 * y_factor) - 1.0 ); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:19:60 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Complex::new((x as f64 * x_factor) - 2.5, (y as f64 * y_factor) - 1.0 ); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let ref mut fout = File::create("fractal3.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------------------- help: try: `let fout = &mut File::create("fractal3.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:14:26 [INFO] [stderr] | [INFO] [stderr] 14 | let x_factor = 3.5 / width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:15:26 [INFO] [stderr] | [INFO] [stderr] 15 | let y_factor = 2.0 / height as f64; [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Complex::new((x as f64 * x_factor) - 2.5, (y as f64 * y_factor) - 1.0 ); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:19:60 [INFO] [stderr] | [INFO] [stderr] 19 | let c = Complex::new((x as f64 * x_factor) - 2.5, (y as f64 * y_factor) - 1.0 ); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/main.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let ref mut fout = File::create("fractal3.png").unwrap(); [INFO] [stderr] | ----^^^^^^^^^^^^----------------------------------------- help: try: `let fout = &mut File::create("fractal3.png").unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.77s [INFO] running `"docker" "inspect" "81a9f3697018bba052c7164eb2affb065a1bb55009c75375ebf1f59e75f725d6"` [INFO] running `"docker" "rm" "-f" "81a9f3697018bba052c7164eb2affb065a1bb55009c75375ebf1f59e75f725d6"` [INFO] [stdout] 81a9f3697018bba052c7164eb2affb065a1bb55009c75375ebf1f59e75f725d6