[INFO] updating cached repository dkarkada/julia-gen [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dkarkada/julia-gen [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dkarkada/julia-gen" "work/ex/clippy-test-run/sources/stable/gh/dkarkada/julia-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dkarkada/julia-gen'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dkarkada/julia-gen" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dkarkada/julia-gen"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dkarkada/julia-gen'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b1ae6da5c20a22c6829df480577c978bdfab383d [INFO] sha for GitHub repo dkarkada/julia-gen: b1ae6da5c20a22c6829df480577c978bdfab383d [INFO] validating manifest of dkarkada/julia-gen on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dkarkada/julia-gen on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dkarkada/julia-gen [INFO] finished frobbing dkarkada/julia-gen [INFO] frobbed toml for dkarkada/julia-gen written to work/ex/clippy-test-run/sources/stable/gh/dkarkada/julia-gen/Cargo.toml [INFO] started frobbing dkarkada/julia-gen [INFO] finished frobbing dkarkada/julia-gen [INFO] frobbed toml for dkarkada/julia-gen written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dkarkada/julia-gen/Cargo.toml [INFO] crate dkarkada/julia-gen has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dkarkada/julia-gen against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dkarkada/julia-gen:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8bb9595c0dfa4c94e9b32e724396ef83bc9830ff850f2dea22f4447258e29e25 [INFO] running `"docker" "start" "-a" "8bb9595c0dfa4c94e9b32e724396ef83bc9830ff850f2dea22f4447258e29e25"` [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling num-derive v0.2.2 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking julia v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | return rgb [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:67:4 [INFO] [stderr] | [INFO] [stderr] 67 | return rgb [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `rgb` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `channel` is used to index `rgb` [INFO] [stderr] --> src/main.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | for channel in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (channel, ) in rgb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let c1p1_c = color_palette_1[cind][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_1[cind][channel])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | let c2p1_c = color_palette_1[cind+1][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_1[cind+1][channel])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let c1p2_c = color_palette_2[cind][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_2[cind][channel])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | let c2p2_c = color_palette_2[cind+1][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_2[cind+1][channel])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | let re = Regex::new(r":").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:53 [INFO] [stderr] | [INFO] [stderr] 150 | (Ok(val1), Ok(val2)) => params.aspect_ratio = val1 as f64/val2 as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:65 [INFO] [stderr] | [INFO] [stderr] 150 | (Ok(val1), Ok(val2)) => params.aspect_ratio = val1 as f64/val2 as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | let re = Regex::new(r"x").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | params.aspect_ratio = val1 as f64/val2 as f64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:165:42 [INFO] [stderr] | [INFO] [stderr] 165 | params.aspect_ratio = val1 as f64/val2 as f64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:232:16 [INFO] [stderr] | [INFO] [stderr] 232 | let height = (params.img_width as f64 / params.aspect_ratio) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(params.img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:235:24 [INFO] [stderr] | [INFO] [stderr] 235 | let scale = win_width/width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | let zx = x as f64 * scale - win_width/2.0 + centerx; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | let zy = (height-y) as f64 * scale - win_width/2.0 + centery; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(height-y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:263:21 [INFO] [stderr] | [INFO] [stderr] 263 | let count: f64 = (count as f64) / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `channel` is used to index `rgb` [INFO] [stderr] --> src/main.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | for channel in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 57 | for (channel, ) in rgb.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | let c1p1_c = color_palette_1[cind][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_1[cind][channel])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:59:18 [INFO] [stderr] | [INFO] [stderr] 59 | let c2p1_c = color_palette_1[cind+1][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_1[cind+1][channel])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | let c1p2_c = color_palette_2[cind][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_2[cind][channel])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | let c2p2_c = color_palette_2[cind+1][channel] as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(color_palette_2[cind+1][channel])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:146:25 [INFO] [stderr] | [INFO] [stderr] 146 | let re = Regex::new(r":").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:53 [INFO] [stderr] | [INFO] [stderr] 150 | (Ok(val1), Ok(val2)) => params.aspect_ratio = val1 as f64/val2 as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:150:65 [INFO] [stderr] | [INFO] [stderr] 150 | (Ok(val1), Ok(val2)) => params.aspect_ratio = val1 as f64/val2 as f64, [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:159:25 [INFO] [stderr] | [INFO] [stderr] 159 | let re = Regex::new(r"x").unwrap(); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:165:30 [INFO] [stderr] | [INFO] [stderr] 165 | params.aspect_ratio = val1 as f64/val2 as f64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:165:42 [INFO] [stderr] | [INFO] [stderr] 165 | params.aspect_ratio = val1 as f64/val2 as f64 [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:232:16 [INFO] [stderr] | [INFO] [stderr] 232 | let height = (params.img_width as f64 / params.aspect_ratio) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(params.img_width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:235:24 [INFO] [stderr] | [INFO] [stderr] 235 | let scale = win_width/width as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | let zx = x as f64 * scale - win_width/2.0 + centerx; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | let zy = (height-y) as f64 * scale - win_width/2.0 + centery; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(height-y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:263:21 [INFO] [stderr] | [INFO] [stderr] 263 | let count: f64 = (count as f64) / 255.0; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 19.12s [INFO] running `"docker" "inspect" "8bb9595c0dfa4c94e9b32e724396ef83bc9830ff850f2dea22f4447258e29e25"` [INFO] running `"docker" "rm" "-f" "8bb9595c0dfa4c94e9b32e724396ef83bc9830ff850f2dea22f4447258e29e25"` [INFO] [stdout] 8bb9595c0dfa4c94e9b32e724396ef83bc9830ff850f2dea22f4447258e29e25