[INFO] updating cached repository djmittens/learn-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/djmittens/learn-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/djmittens/learn-rust" "work/ex/clippy-test-run/sources/stable/gh/djmittens/learn-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/djmittens/learn-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/djmittens/learn-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmittens/learn-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmittens/learn-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3485da39d85e6df25c2c594b469b04e3bdd35f70 [INFO] sha for GitHub repo djmittens/learn-rust: 3485da39d85e6df25c2c594b469b04e3bdd35f70 [INFO] validating manifest of djmittens/learn-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of djmittens/learn-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing djmittens/learn-rust [INFO] finished frobbing djmittens/learn-rust [INFO] frobbed toml for djmittens/learn-rust written to work/ex/clippy-test-run/sources/stable/gh/djmittens/learn-rust/Cargo.toml [INFO] started frobbing djmittens/learn-rust [INFO] finished frobbing djmittens/learn-rust [INFO] frobbed toml for djmittens/learn-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmittens/learn-rust/Cargo.toml [INFO] crate djmittens/learn-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting djmittens/learn-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/djmittens/learn-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da904c47f3383526e80db744e137fa3bb0756595ef51da8eeb2284bf8697a284 [INFO] running `"docker" "start" "-a" "da904c47f3383526e80db744e137fa3bb0756595ef51da8eeb2284bf8697a284"` [INFO] [stderr] Checking hamming v0.1.3 [INFO] [stderr] Checking primal-estimate v0.2.1 [INFO] [stderr] Compiling memchr v2.1.2 [INFO] [stderr] Checking primal-check v0.2.3 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Checking primal-bit v0.2.4 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking primal-sieve v0.2.9 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking primal v0.2.3 [INFO] [stderr] Checking learn-rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return sieve; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `sieve` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | return sieve; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `sieve` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if !false { [INFO] [stderr] | ^^^^^^ help: try: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:24:8 [INFO] [stderr] | [INFO] [stderr] 24 | if !false { [INFO] [stderr] | ^^^^^^ help: try: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.59s [INFO] running `"docker" "inspect" "da904c47f3383526e80db744e137fa3bb0756595ef51da8eeb2284bf8697a284"` [INFO] running `"docker" "rm" "-f" "da904c47f3383526e80db744e137fa3bb0756595ef51da8eeb2284bf8697a284"` [INFO] [stdout] da904c47f3383526e80db744e137fa3bb0756595ef51da8eeb2284bf8697a284