[INFO] updating cached repository djmitche/rask
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/djmitche/rask
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/djmitche/rask" "work/ex/clippy-test-run/sources/stable/gh/djmitche/rask"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/djmitche/rask'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/djmitche/rask" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmitche/rask"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmitche/rask'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 93ce28ed15d11ba601765933f95756e7fb76d2e3
[INFO] sha for GitHub repo djmitche/rask: 93ce28ed15d11ba601765933f95756e7fb76d2e3
[INFO] validating manifest of djmitche/rask on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of djmitche/rask on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing djmitche/rask
[INFO] finished frobbing djmitche/rask
[INFO] frobbed toml for djmitche/rask written to work/ex/clippy-test-run/sources/stable/gh/djmitche/rask/Cargo.toml
[INFO] started frobbing djmitche/rask
[INFO] finished frobbing djmitche/rask
[INFO] frobbed toml for djmitche/rask written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmitche/rask/Cargo.toml
[INFO] crate djmitche/rask has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting djmitche/rask against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/djmitche/rask:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b14af98c5b6d7cce4f96d2f63685f66d05d82fee79e9e12d27b19f4286acf336
[INFO] running `"docker" "start" "-a" "b14af98c5b6d7cce4f96d2f63685f66d05d82fee79e9e12d27b19f4286acf336"`
[INFO] [stderr]     Checking uuid v0.7.1
[INFO] [stderr]     Checking taskwarrior v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tdb2/pig.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/tdb2/pig.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             input: input,
[INFO] [stderr]    |             ^^^^^^^^^^^^ help: replace it with: `input`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/task/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | mod task;
[INFO] [stderr]   | ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: module has the same name as its containing module
[INFO] [stderr]  --> src/task/mod.rs:1:1
[INFO] [stderr]   |
[INFO] [stderr] 1 | mod task;
[INFO] [stderr]   | ^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::module_inception)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/task/taskbuilder.rs:171:60
[INFO] [stderr]     |
[INFO] [stderr] 171 |         assert_eq!(parse_int::<u32>("123000000").unwrap(), 123000000u32);
[INFO] [stderr]     |                                                            ^^^^^^^^^^^^ help: consider: `123_000_000u32`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/task/taskbuilder.rs:172:62
[INFO] [stderr]     |
[INFO] [stderr] 172 |         assert_eq!(parse_int::<i32>("-123000000").unwrap(), -123000000i32);
[INFO] [stderr]     |                                                              ^^^^^^^^^^^^ help: consider: `123_000_000i32`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/tdb2/ff4.rs:13:15
[INFO] [stderr]    |
[INFO] [stderr] 13 |         bail!(format!("too short"));
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"too short".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/tdb2/ff4.rs:18:31
[INFO] [stderr]    |
[INFO] [stderr] 18 |             b'0'...b'9' => Ok((c - b'0') as u16),
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^ help: try: `u16::from(c - b'0')`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/tdb2/ff4.rs:19:31
[INFO] [stderr]    |
[INFO] [stderr] 19 |             b'a'...b'f' => Ok((c - b'a' + 10) as u16),
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(c - b'a' + 10)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/tdb2/ff4.rs:20:31
[INFO] [stderr]    |
[INFO] [stderr] 20 |             b'A'...b'F' => Ok((c - b'A' + 10) as u16),
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(c - b'A' + 10)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stderr]   --> src/tdb2/ff4.rs:53:33
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 b'n' => rv.push('\n' as char),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stderr] 
[INFO] [stderr] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stderr]   --> src/tdb2/ff4.rs:54:33
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 b'r' => rv.push('\r' as char),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stderr] 
[INFO] [stderr] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stderr]   --> src/tdb2/ff4.rs:55:33
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 b't' => rv.push('\t' as char),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/tdb2/ff4.rs:86:12
[INFO] [stderr]    |
[INFO] [stderr] 86 |       if let Some(_) = value.find('&') {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 87 | |         return value.replace("&open;", "[").replace("&close;", "]");
[INFO] [stderr] 88 | |     }
[INFO] [stderr]    | |_____- help: try this: `if value.find('&').is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/tdb2/ff4.rs:13:15
[INFO] [stderr]    |
[INFO] [stderr] 13 |         bail!(format!("too short"));
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"too short".to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/tdb2/ff4.rs:18:31
[INFO] [stderr]    |
[INFO] [stderr] 18 |             b'0'...b'9' => Ok((c - b'0') as u16),
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^ help: try: `u16::from(c - b'0')`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/tdb2/ff4.rs:19:31
[INFO] [stderr]    |
[INFO] [stderr] 19 |             b'a'...b'f' => Ok((c - b'a' + 10) as u16),
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(c - b'a' + 10)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change
[INFO] [stderr]   --> src/tdb2/ff4.rs:20:31
[INFO] [stderr]    |
[INFO] [stderr] 20 |             b'A'...b'F' => Ok((c - b'A' + 10) as u16),
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(c - b'A' + 10)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stderr]   --> src/tdb2/ff4.rs:53:33
[INFO] [stderr]    |
[INFO] [stderr] 53 |                 b'n' => rv.push('\n' as char),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_cast)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stderr] 
[INFO] [stderr] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stderr]   --> src/tdb2/ff4.rs:54:33
[INFO] [stderr]    |
[INFO] [stderr] 54 |                 b'r' => rv.push('\r' as char),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stderr] 
[INFO] [stderr] warning: casting to the same type is unnecessary (`char` -> `char`)
[INFO] [stderr]   --> src/tdb2/ff4.rs:55:33
[INFO] [stderr]    |
[INFO] [stderr] 55 |                 b't' => rv.push('\t' as char),
[INFO] [stderr]    |                                 ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/tdb2/ff4.rs:86:12
[INFO] [stderr]    |
[INFO] [stderr] 86 |       if let Some(_) = value.find('&') {
[INFO] [stderr]    |  _____-      ^^^^^^^
[INFO] [stderr] 87 | |         return value.replace("&open;", "[").replace("&close;", "]");
[INFO] [stderr] 88 | |     }
[INFO] [stderr]    | |_____- help: try this: `if value.find('&').is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/parse.rs:17:46
[INFO] [stderr]    |
[INFO] [stderr] 17 |     assert_eq!(tasks[0].entry, Utc.timestamp(1538520624, 0));
[INFO] [stderr]    |                                              ^^^^^^^^^^ help: consider: `1_538_520_624`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/parse.rs:19:61
[INFO] [stderr]    |
[INFO] [stderr] 19 |     assert_eq!(tasks[1].annotations[0].entry, Utc.timestamp(1541461824, 0));
[INFO] [stderr]    |                                                             ^^^^^^^^^^ help: consider: `1_541_461_824`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]   --> tests/parse.rs:18:16
[INFO] [stderr]    |
[INFO] [stderr] 18 |     assert_eq!(tasks[0].udas.get("phabricatorid").unwrap(), "D7364");
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&tasks[0].udas["phabricatorid"]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.47s
[INFO] running `"docker" "inspect" "b14af98c5b6d7cce4f96d2f63685f66d05d82fee79e9e12d27b19f4286acf336"`
[INFO] running `"docker" "rm" "-f" "b14af98c5b6d7cce4f96d2f63685f66d05d82fee79e9e12d27b19f4286acf336"`
[INFO] [stdout] b14af98c5b6d7cce4f96d2f63685f66d05d82fee79e9e12d27b19f4286acf336