[INFO] updating cached repository djmcgill/freeze-flash [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/djmcgill/freeze-flash [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/djmcgill/freeze-flash" "work/ex/clippy-test-run/sources/stable/gh/djmcgill/freeze-flash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/djmcgill/freeze-flash'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/djmcgill/freeze-flash" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/freeze-flash"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/freeze-flash'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 87a48e8bd1be520022a765a458c1446ca093dff1 [INFO] sha for GitHub repo djmcgill/freeze-flash: 87a48e8bd1be520022a765a458c1446ca093dff1 [INFO] validating manifest of djmcgill/freeze-flash on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of djmcgill/freeze-flash on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing djmcgill/freeze-flash [INFO] finished frobbing djmcgill/freeze-flash [INFO] frobbed toml for djmcgill/freeze-flash written to work/ex/clippy-test-run/sources/stable/gh/djmcgill/freeze-flash/Cargo.toml [INFO] started frobbing djmcgill/freeze-flash [INFO] finished frobbing djmcgill/freeze-flash [INFO] frobbed toml for djmcgill/freeze-flash written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/freeze-flash/Cargo.toml [INFO] crate djmcgill/freeze-flash has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting djmcgill/freeze-flash against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/djmcgill/freeze-flash:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd18e6d5f9593ecfada3ff9ab9cdfc2db4b4cf345105549a0f033e7efa01f151 [INFO] running `"docker" "start" "-a" "cd18e6d5f9593ecfada3ff9ab9cdfc2db4b4cf345105549a0f033e7efa01f151"` [INFO] [stderr] Compiling bitflags v1.0.0 [INFO] [stderr] Checking either v1.2.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking x11-dl v2.15.0 [INFO] [stderr] Checking png v0.10.0 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Checking pistoncore-input v0.19.0 [INFO] [stderr] Compiling xml-rs v0.6.2 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling wayland-scanner v0.9.10 [INFO] [stderr] Compiling gl_generator v0.5.5 [INFO] [stderr] Checking pistoncore-window v0.29.0 [INFO] [stderr] Compiling gl v0.6.3 [INFO] [stderr] Compiling glutin v0.9.2 [INFO] [stderr] Compiling wayland-client v0.9.10 [INFO] [stderr] Compiling wayland-protocols v0.9.10 [INFO] [stderr] Checking pistoncore-event_loop v0.34.0 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking piston v0.34.0 [INFO] [stderr] Checking image v0.16.0 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.7.0 [INFO] [stderr] Checking winit v0.7.6 [INFO] [stderr] Checking piston2d-opengl_graphics v0.48.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.40.1 [INFO] [stderr] Checking freeze-flash v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:23:36 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn update(&mut self, args: &UpdateArgs, update_command: &PlayerUpdate) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn point_to(&mut self, _args: &UpdateArgs, point_to: &Vector2) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | let center = Vector2::new(width as f64/2.0, height as f64/2.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:49 [INFO] [stderr] | [INFO] [stderr] 69 | let center = Vector2::new(width as f64/2.0, height as f64/2.0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:23:36 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn update(&mut self, args: &UpdateArgs, update_command: &PlayerUpdate) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/player.rs:46:39 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn point_to(&mut self, _args: &UpdateArgs, point_to: &Vector2) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:46:32 [INFO] [stderr] | [INFO] [stderr] 46 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:31 [INFO] [stderr] | [INFO] [stderr] 69 | let center = Vector2::new(width as f64/2.0, height as f64/2.0); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:69:49 [INFO] [stderr] | [INFO] [stderr] 69 | let center = Vector2::new(width as f64/2.0, height as f64/2.0); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 46.88s [INFO] running `"docker" "inspect" "cd18e6d5f9593ecfada3ff9ab9cdfc2db4b4cf345105549a0f033e7efa01f151"` [INFO] running `"docker" "rm" "-f" "cd18e6d5f9593ecfada3ff9ab9cdfc2db4b4cf345105549a0f033e7efa01f151"` [INFO] [stdout] cd18e6d5f9593ecfada3ff9ab9cdfc2db4b4cf345105549a0f033e7efa01f151