[INFO] updating cached repository djmcgill/form [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/djmcgill/form [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/djmcgill/form" "work/ex/clippy-test-run/sources/stable/gh/djmcgill/form"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/djmcgill/form'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/djmcgill/form" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/form"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/form'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 612c66d593e453987841a64a149ea50a4cae5186 [INFO] sha for GitHub repo djmcgill/form: 612c66d593e453987841a64a149ea50a4cae5186 [INFO] validating manifest of djmcgill/form on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of djmcgill/form on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing djmcgill/form [INFO] finished frobbing djmcgill/form [INFO] frobbed toml for djmcgill/form written to work/ex/clippy-test-run/sources/stable/gh/djmcgill/form/Cargo.toml [INFO] started frobbing djmcgill/form [INFO] finished frobbing djmcgill/form [INFO] frobbed toml for djmcgill/form written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/form/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting djmcgill/form against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/djmcgill/form:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 477e2b13241b54a2c7a75ad2ac9c3552eeec41b9d9f112c7b5cfc4389d569ccf [INFO] running `"docker" "start" "-a" "477e2b13241b54a2c7a75ad2ac9c3552eeec41b9d9f112c7b5cfc4389d569ccf"` [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking rustc-demangle v0.1.13 [INFO] [stderr] Compiling backtrace-sys v0.1.28 [INFO] [stderr] Compiling backtrace v0.3.13 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking synom v0.11.3 [INFO] [stderr] Compiling syn v0.15.26 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Checking syn v0.11.11 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_chacha v0.1.1 [INFO] [stderr] Checking rand_os v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_pcg v0.1.1 [INFO] [stderr] Checking rand v0.6.5 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking form v0.5.0 (/opt/crater/workdir) [INFO] [stderr] error: for loop over `extract_crate_from_mod(&mut item.node)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/util.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | for rust_crate in extract_crate_from_mod(&mut item.node) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for rust_crate in extract_crate_from_mod(&mut item.node)` with `if let Some(rust_crate) = extract_crate_from_mod(&mut item.node)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / fn extract_crate_from_mod<'a>(node: &'a mut ItemKind) -> Option { [INFO] [stderr] 119 | | if let ItemKind::Mod(ref mut maybe_items) = *node { [INFO] [stderr] 120 | | maybe_items.take().map(make_crate) [INFO] [stderr] 121 | | } else { [INFO] [stderr] 122 | | None [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: for loop over `extract_crate_from_mod(&mut item.node)`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/util.rs:102:27 [INFO] [stderr] | [INFO] [stderr] 102 | for rust_crate in extract_crate_from_mod(&mut item.node) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for rust_crate in extract_crate_from_mod(&mut item.node)` with `if let Some(rust_crate) = extract_crate_from_mod(&mut item.node)` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: Could not compile `form`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/util.rs:118:1 [INFO] [stderr] | [INFO] [stderr] 118 | / fn extract_crate_from_mod<'a>(node: &'a mut ItemKind) -> Option { [INFO] [stderr] 119 | | if let ItemKind::Mod(ref mut maybe_items) = *node { [INFO] [stderr] 120 | | maybe_items.take().map(make_crate) [INFO] [stderr] 121 | | } else { [INFO] [stderr] 122 | | None [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `form`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "477e2b13241b54a2c7a75ad2ac9c3552eeec41b9d9f112c7b5cfc4389d569ccf"` [INFO] running `"docker" "rm" "-f" "477e2b13241b54a2c7a75ad2ac9c3552eeec41b9d9f112c7b5cfc4389d569ccf"` [INFO] [stdout] 477e2b13241b54a2c7a75ad2ac9c3552eeec41b9d9f112c7b5cfc4389d569ccf