[INFO] updating cached repository djmcgill/autonomy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/djmcgill/autonomy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/djmcgill/autonomy" "work/ex/clippy-test-run/sources/stable/gh/djmcgill/autonomy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/djmcgill/autonomy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/djmcgill/autonomy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/autonomy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/autonomy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fb5299626c71060d213f86a0b76b9e6ad910231f [INFO] sha for GitHub repo djmcgill/autonomy: fb5299626c71060d213f86a0b76b9e6ad910231f [INFO] validating manifest of djmcgill/autonomy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of djmcgill/autonomy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing djmcgill/autonomy [INFO] finished frobbing djmcgill/autonomy [INFO] frobbed toml for djmcgill/autonomy written to work/ex/clippy-test-run/sources/stable/gh/djmcgill/autonomy/Cargo.toml [INFO] started frobbing djmcgill/autonomy [INFO] finished frobbing djmcgill/autonomy [INFO] frobbed toml for djmcgill/autonomy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djmcgill/autonomy/Cargo.toml [INFO] crate djmcgill/autonomy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting djmcgill/autonomy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/djmcgill/autonomy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 935233f4c08dbc61b66665422e0aa03f3dac8aaa6f56ffd17a01de8c34b83705 [INFO] running `"docker" "start" "-a" "935233f4c08dbc61b66665422e0aa03f3dac8aaa6f56ffd17a01de8c34b83705"` [INFO] [stderr] Checking rustc-hash v1.0.1 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Compiling glutin v0.17.0 [INFO] [stderr] Checking num-bigint v0.2.1 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking rusttype v0.7.2 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking winit v0.16.2 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking rusttype v0.6.5 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking nalgebra v0.16.9 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking ncollide3d v0.17.1 [INFO] [stderr] Checking kiss3d v0.16.4 [INFO] [stderr] Checking autonomy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `alga::linear::Transformation` [INFO] [stderr] --> src/mouse_picking.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use alga::linear::Transformation; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `alga::linear::Transformation` [INFO] [stderr] --> src/mouse_picking.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use alga::linear::Transformation; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/flat_array.rs:19:34 [INFO] [stderr] | [INFO] [stderr] 19 | for (item, ix) in self.0.into_iter().cloned().zip(0usize..) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:42:66 [INFO] [stderr] | [INFO] [stderr] 42 | faces.push(Point3::new(7 + ix_diff, 4 + ix_diff, 0 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:43:40 [INFO] [stderr] | [INFO] [stderr] 43 | faces.push(Point3::new(0 + ix_diff, 3 + ix_diff, 7 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:46:40 [INFO] [stderr] | [INFO] [stderr] 46 | faces.push(Point3::new(0 + ix_diff, 1 + ix_diff, 2 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:47:66 [INFO] [stderr] | [INFO] [stderr] 47 | faces.push(Point3::new(2 + ix_diff, 3 + ix_diff, 0 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | faces.push(Point3::new(1 + ix_diff, 0 + ix_diff, 4 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/mouse_picking.rs:43:58 [INFO] [stderr] | [INFO] [stderr] 43 | let nearest_collisions = &mut normals_and_points.into_iter().map(|&(normal, point)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: for loop over `option_nearest_collision`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:69:34 [INFO] [stderr] | [INFO] [stderr] 69 | for nearest_collision in option_nearest_collision { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for nearest_collision in option_nearest_collision` with `if let Some(nearest_collision) = option_nearest_collision` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `autonomy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/flat_array.rs:19:34 [INFO] [stderr] | [INFO] [stderr] 19 | for (item, ix) in self.0.into_iter().cloned().zip(0usize..) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:42:66 [INFO] [stderr] | [INFO] [stderr] 42 | faces.push(Point3::new(7 + ix_diff, 4 + ix_diff, 0 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:43:40 [INFO] [stderr] | [INFO] [stderr] 43 | faces.push(Point3::new(0 + ix_diff, 3 + ix_diff, 7 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:46:40 [INFO] [stderr] | [INFO] [stderr] 46 | faces.push(Point3::new(0 + ix_diff, 1 + ix_diff, 2 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:47:66 [INFO] [stderr] | [INFO] [stderr] 47 | faces.push(Point3::new(2 + ix_diff, 3 + ix_diff, 0 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ix_diff` [INFO] [stderr] --> src/flat_array.rs:49:53 [INFO] [stderr] | [INFO] [stderr] 49 | faces.push(Point3::new(1 + ix_diff, 0 + ix_diff, 4 + ix_diff)); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/mouse_picking.rs:43:58 [INFO] [stderr] | [INFO] [stderr] 43 | let nearest_collisions = &mut normals_and_points.into_iter().map(|&(normal, point)| { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: for loop over `option_nearest_collision`, which is an `Option`. This is more readably written as an `if let` statement. [INFO] [stderr] --> src/main.rs:69:34 [INFO] [stderr] | [INFO] [stderr] 69 | for nearest_collision in option_nearest_collision { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::for_loop_over_option)] on by default [INFO] [stderr] = help: consider replacing `for nearest_collision in option_nearest_collision` with `if let Some(nearest_collision) = option_nearest_collision` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_loop_over_option [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `autonomy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "935233f4c08dbc61b66665422e0aa03f3dac8aaa6f56ffd17a01de8c34b83705"` [INFO] running `"docker" "rm" "-f" "935233f4c08dbc61b66665422e0aa03f3dac8aaa6f56ffd17a01de8c34b83705"` [INFO] [stdout] 935233f4c08dbc61b66665422e0aa03f3dac8aaa6f56ffd17a01de8c34b83705