[INFO] updating cached repository djc/kv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/djc/kv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/djc/kv" "work/ex/clippy-test-run/sources/stable/gh/djc/kv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/djc/kv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/djc/kv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djc/kv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djc/kv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ea50ca6f591c01198bc6ba87554c9879d2eead03 [INFO] sha for GitHub repo djc/kv: ea50ca6f591c01198bc6ba87554c9879d2eead03 [INFO] validating manifest of djc/kv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of djc/kv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing djc/kv [INFO] finished frobbing djc/kv [INFO] frobbed toml for djc/kv written to work/ex/clippy-test-run/sources/stable/gh/djc/kv/Cargo.toml [INFO] started frobbing djc/kv [INFO] finished frobbing djc/kv [INFO] frobbed toml for djc/kv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/djc/kv/Cargo.toml [INFO] crate djc/kv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting djc/kv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/djc/kv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cd02af8d0b7ddc2934a9ae5f51b8ac16ec339cbe17dac1a8037c3c28a12c9bde [INFO] running `"docker" "start" "-a" "cd02af8d0b7ddc2934a9ae5f51b8ac16ec339cbe17dac1a8037c3c28a12c9bde"` [INFO] [stderr] Compiling protobuf v2.0.2 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking raft v0.3.0 [INFO] [stderr] Checking kv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/client.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/bin/client.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if src.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/bin/client.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/bin/client.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if src.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `src.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/node.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | .map(move |t| Msg::Tick(t)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Msg::Tick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/bin/node.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / fn on_ready(&mut self) { [INFO] [stderr] 115 | | if !self.r.has_ready() { [INFO] [stderr] 116 | | return; [INFO] [stderr] 117 | | } [INFO] [stderr] ... | [INFO] [stderr] 239 | | self.r.advance(ready); [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/node.rs:172:68 [INFO] [stderr] | [INFO] [stderr] 172 | } else if prefix_len == 0 || prefix == &e.data[1..prefix_len + 1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `1..=prefix_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/node.rs:174:50 [INFO] [stderr] | [INFO] [stderr] 174 | let key = ByteStr(e.data[1..key_len + 1].to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=key_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/node.rs:185:27 [INFO] [stderr] | [INFO] [stderr] 185 | } else if found.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `found.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/node.rs:269:29 [INFO] [stderr] | [INFO] [stderr] 269 | / match prefix { [INFO] [stderr] 270 | | Some(mut prefix) => { [INFO] [stderr] 271 | | entry_data.append(&mut prefix.0); [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | None => {} [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let Some(mut prefix) = prefix { [INFO] [stderr] 270 | entry_data.append(&mut prefix.0); [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/node.rs:103:18 [INFO] [stderr] | [INFO] [stderr] 103 | .map(move |t| Msg::Tick(t)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Msg::Tick` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/bin/node.rs:114:5 [INFO] [stderr] | [INFO] [stderr] 114 | / fn on_ready(&mut self) { [INFO] [stderr] 115 | | if !self.r.has_ready() { [INFO] [stderr] 116 | | return; [INFO] [stderr] 117 | | } [INFO] [stderr] ... | [INFO] [stderr] 239 | | self.r.advance(ready); [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/node.rs:172:68 [INFO] [stderr] | [INFO] [stderr] 172 | } else if prefix_len == 0 || prefix == &e.data[1..prefix_len + 1] { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `1..=prefix_len` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/bin/node.rs:174:50 [INFO] [stderr] | [INFO] [stderr] 174 | let key = ByteStr(e.data[1..key_len + 1].to_vec()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: use: `1..=key_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/node.rs:185:27 [INFO] [stderr] | [INFO] [stderr] 185 | } else if found.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `found.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/node.rs:269:29 [INFO] [stderr] | [INFO] [stderr] 269 | / match prefix { [INFO] [stderr] 270 | | Some(mut prefix) => { [INFO] [stderr] 271 | | entry_data.append(&mut prefix.0); [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | None => {} [INFO] [stderr] 274 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 269 | if let Some(mut prefix) = prefix { [INFO] [stderr] 270 | entry_data.append(&mut prefix.0); [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 29.78s [INFO] running `"docker" "inspect" "cd02af8d0b7ddc2934a9ae5f51b8ac16ec339cbe17dac1a8037c3c28a12c9bde"` [INFO] running `"docker" "rm" "-f" "cd02af8d0b7ddc2934a9ae5f51b8ac16ec339cbe17dac1a8037c3c28a12c9bde"` [INFO] [stdout] cd02af8d0b7ddc2934a9ae5f51b8ac16ec339cbe17dac1a8037c3c28a12c9bde