[INFO] updating cached repository divvun/divvun-bundler
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/divvun/divvun-bundler
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/divvun/divvun-bundler" "work/ex/clippy-test-run/sources/stable/gh/divvun/divvun-bundler"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/divvun/divvun-bundler'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/divvun/divvun-bundler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/divvun/divvun-bundler"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/divvun/divvun-bundler'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d9d21fdd4807aa20c22ad87432fa6bc53d74c6a1
[INFO] sha for GitHub repo divvun/divvun-bundler: d9d21fdd4807aa20c22ad87432fa6bc53d74c6a1
[INFO] validating manifest of divvun/divvun-bundler on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of divvun/divvun-bundler on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing divvun/divvun-bundler
[INFO] finished frobbing divvun/divvun-bundler
[INFO] frobbed toml for divvun/divvun-bundler written to work/ex/clippy-test-run/sources/stable/gh/divvun/divvun-bundler/Cargo.toml
[INFO] started frobbing divvun/divvun-bundler
[INFO] finished frobbing divvun/divvun-bundler
[INFO] frobbed toml for divvun/divvun-bundler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/divvun/divvun-bundler/Cargo.toml
[INFO] crate divvun/divvun-bundler has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting divvun/divvun-bundler against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/divvun/divvun-bundler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9f11b83a4d6cf677f37c5cd748ac2d1d702437fcdc5739e68653fbccaf01d831
[INFO] running `"docker" "start" "-a" "9f11b83a4d6cf677f37c5cd748ac2d1d702437fcdc5739e68653fbccaf01d831"`
[INFO] [stderr]    Compiling plist v0.3.0
[INFO] [stderr]    Compiling miniz_oxide_c_api v0.2.0
[INFO] [stderr]     Checking miniz_oxide v0.2.0
[INFO] [stderr]     Checking regex v1.1.0
[INFO] [stderr]     Checking flate2 v1.0.4
[INFO] [stderr]     Checking env_logger v0.6.0
[INFO] [stderr]     Checking zip v0.4.2
[INFO] [stderr]     Checking divvun-bundler v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `PathBuf`
[INFO] [stderr]  --> src/targets/osx.rs:3:23
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::path::{Path, PathBuf};
[INFO] [stderr]   |                       ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `self`
[INFO] [stderr]  --> src/targets/win.rs:6:17
[INFO] [stderr]   |
[INFO] [stderr] 6 | use std::path::{self, Path, PathBuf};
[INFO] [stderr]   |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `PathBuf`
[INFO] [stderr]  --> src/targets/osx.rs:3:23
[INFO] [stderr]   |
[INFO] [stderr] 3 | use std::path::{Path, PathBuf};
[INFO] [stderr]   |                       ^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `self`
[INFO] [stderr]  --> src/targets/win.rs:6:17
[INFO] [stderr]   |
[INFO] [stderr] 6 | use std::path::{self, Path, PathBuf};
[INFO] [stderr]   |                 ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `result`
[INFO] [stderr]    --> src/targets/osx.rs:170:9
[INFO] [stderr]     |
[INFO] [stderr] 170 |     let result = Command::new("productsign")
[INFO] [stderr]     |         ^^^^^^ help: consider using `_result` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `result`
[INFO] [stderr]    --> src/targets/osx.rs:187:10
[INFO] [stderr]     |
[INFO] [stderr] 187 |      let result = Command::new("codesign")
[INFO] [stderr]     |          ^^^^^^ help: consider using `_result` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `output_dir`
[INFO] [stderr]    --> src/targets/win.rs:252:2
[INFO] [stderr]     |
[INFO] [stderr] 252 |     output_dir: &Path,
[INFO] [stderr]     |     ^^^^^^^^^^ help: consider using `_output_dir` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `result`
[INFO] [stderr]    --> src/targets/osx.rs:170:9
[INFO] [stderr]     |
[INFO] [stderr] 170 |     let result = Command::new("productsign")
[INFO] [stderr]     |         ^^^^^^ help: consider using `_result` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `result`
[INFO] [stderr]    --> src/targets/osx.rs:187:10
[INFO] [stderr]     |
[INFO] [stderr] 187 |      let result = Command::new("codesign")
[INFO] [stderr]     |          ^^^^^^ help: consider using `_result` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `output_dir`
[INFO] [stderr]    --> src/targets/win.rs:252:2
[INFO] [stderr]     |
[INFO] [stderr] 252 |     output_dir: &Path,
[INFO] [stderr]     |     ^^^^^^^^^^ help: consider using `_output_dir` instead
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/targets/win.rs:21:1
[INFO] [stderr]     |
[INFO] [stderr] 21  | / pub fn create_installer_speller(
[INFO] [stderr] 22  | |     app_id: &str,
[INFO] [stderr] 23  | |     app_name: &str,
[INFO] [stderr] 24  | |     bcp47code: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |     .expect("to rename installer executable");
[INFO] [stderr] 105 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/targets/win.rs:244:1
[INFO] [stderr]     |
[INFO] [stderr] 244 | / fn make_nsi_speller(
[INFO] [stderr] 245 | |     app_id: &str,
[INFO] [stderr] 246 | |     app_name: &str,
[INFO] [stderr] 247 | |     bcp47code: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 283 | |     )
[INFO] [stderr] 284 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/targets/win.rs:336:3
[INFO] [stderr]     |
[INFO] [stderr] 336 |         alternatives.iter().filter(|p| p.is_dir()).next().cloned()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|p| p.is_dir()).next()` with `find(|p| p.is_dir())`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/targets/win.rs:21:1
[INFO] [stderr]     |
[INFO] [stderr] 21  | / pub fn create_installer_speller(
[INFO] [stderr] 22  | |     app_id: &str,
[INFO] [stderr] 23  | |     app_name: &str,
[INFO] [stderr] 24  | |     bcp47code: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |     .expect("to rename installer executable");
[INFO] [stderr] 105 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::too_many_arguments)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: this function has too many arguments (8/7)
[INFO] [stderr]    --> src/targets/win.rs:244:1
[INFO] [stderr]     |
[INFO] [stderr] 244 | / fn make_nsi_speller(
[INFO] [stderr] 245 | |     app_id: &str,
[INFO] [stderr] 246 | |     app_name: &str,
[INFO] [stderr] 247 | |     bcp47code: &str,
[INFO] [stderr] ...   |
[INFO] [stderr] 283 | |     )
[INFO] [stderr] 284 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
[INFO] [stderr] 
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr]    --> src/targets/win.rs:336:3
[INFO] [stderr]     |
[INFO] [stderr] 336 |         alternatives.iter().filter(|p| p.is_dir()).next().cloned()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr]     = note: replace `filter(|p| p.is_dir()).next()` with `find(|p| p.is_dir())`
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Write`
[INFO] [stderr]  --> src/main.rs:8:27
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::io::{Read, Seek, Write};
[INFO] [stderr]   |                           ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `user`
[INFO] [stderr]   --> src/main.rs:68:6
[INFO] [stderr]    |
[INFO] [stderr] 68 |     let user = matches.is_present("USER");
[INFO] [stderr]    |         ^^^^ help: consider using `_user` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `archive`
[INFO] [stderr]    --> src/main.rs:156:38
[INFO] [stderr]     |
[INFO] [stderr] 156 | fn create_stored_zip<R: Read + Seek>(archive: &mut ZipArchive<R>) -> ZipArchive<R> {
[INFO] [stderr]     |                                      ^^^^^^^ help: consider using `_archive` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_compressed`
[INFO] [stderr]    --> src/main.rs:144:1
[INFO] [stderr]     |
[INFO] [stderr] 144 | fn is_compressed<R: Read + Seek>(archive: &mut ZipArchive<R>) -> bool {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `create_stored_zip`
[INFO] [stderr]    --> src/main.rs:156:1
[INFO] [stderr]     |
[INFO] [stderr] 156 | fn create_stored_zip<R: Read + Seek>(archive: &mut ZipArchive<R>) -> ZipArchive<R> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 |       let certificate_path = match sign {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 59 | |         true => Some(Path::new(
[INFO] [stderr] 60 | |             matches
[INFO] [stderr] 61 | |                 .value_of("CERTIFICATE")
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |         _ => None,
[INFO] [stderr] 65 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let certificate_path = if sign { Some(Path::new(
[INFO] [stderr] 59 |     matches
[INFO] [stderr] 60 |         .value_of("CERTIFICATE")
[INFO] [stderr] 61 |         .expect("valid certificate path"),
[INFO] [stderr] 62 | )) } else { None };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:3:1
[INFO] [stderr]   |
[INFO] [stderr] 3 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `Write`
[INFO] [stderr]  --> src/main.rs:8:27
[INFO] [stderr]   |
[INFO] [stderr] 8 | use std::io::{Read, Seek, Write};
[INFO] [stderr]   |                           ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `user`
[INFO] [stderr]   --> src/main.rs:68:6
[INFO] [stderr]    |
[INFO] [stderr] 68 |     let user = matches.is_present("USER");
[INFO] [stderr]    |         ^^^^ help: consider using `_user` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `archive`
[INFO] [stderr]    --> src/main.rs:156:38
[INFO] [stderr]     |
[INFO] [stderr] 156 | fn create_stored_zip<R: Read + Seek>(archive: &mut ZipArchive<R>) -> ZipArchive<R> {
[INFO] [stderr]     |                                      ^^^^^^^ help: consider using `_archive` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_compressed`
[INFO] [stderr]    --> src/main.rs:144:1
[INFO] [stderr]     |
[INFO] [stderr] 144 | fn is_compressed<R: Read + Seek>(archive: &mut ZipArchive<R>) -> bool {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `create_stored_zip`
[INFO] [stderr]    --> src/main.rs:156:1
[INFO] [stderr]     |
[INFO] [stderr] 156 | fn create_stored_zip<R: Read + Seek>(archive: &mut ZipArchive<R>) -> ZipArchive<R> {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]   --> src/main.rs:58:25
[INFO] [stderr]    |
[INFO] [stderr] 58 |       let certificate_path = match sign {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 59 | |         true => Some(Path::new(
[INFO] [stderr] 60 | |             matches
[INFO] [stderr] 61 | |                 .value_of("CERTIFICATE")
[INFO] [stderr] ...  |
[INFO] [stderr] 64 | |         _ => None,
[INFO] [stderr] 65 | |     };
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]    |
[INFO] [stderr] 58 |     let certificate_path = if sign { Some(Path::new(
[INFO] [stderr] 59 |     matches
[INFO] [stderr] 60 |         .value_of("CERTIFICATE")
[INFO] [stderr] 61 |         .expect("valid certificate path"),
[INFO] [stderr] 62 | )) } else { None };
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 13.77s
[INFO] running `"docker" "inspect" "9f11b83a4d6cf677f37c5cd748ac2d1d702437fcdc5739e68653fbccaf01d831"`
[INFO] running `"docker" "rm" "-f" "9f11b83a4d6cf677f37c5cd748ac2d1d702437fcdc5739e68653fbccaf01d831"`
[INFO] [stdout] 9f11b83a4d6cf677f37c5cd748ac2d1d702437fcdc5739e68653fbccaf01d831