[INFO] updating cached repository divergentdave/certificate_carver [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/divergentdave/certificate_carver [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/divergentdave/certificate_carver" "work/ex/clippy-test-run/sources/stable/gh/divergentdave/certificate_carver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/divergentdave/certificate_carver'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/divergentdave/certificate_carver" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/divergentdave/certificate_carver"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/divergentdave/certificate_carver'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7fa0bdc5c4c3e335d0d10466a47a33c9c078438 [INFO] sha for GitHub repo divergentdave/certificate_carver: d7fa0bdc5c4c3e335d0d10466a47a33c9c078438 [INFO] validating manifest of divergentdave/certificate_carver on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of divergentdave/certificate_carver on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing divergentdave/certificate_carver [INFO] finished frobbing divergentdave/certificate_carver [INFO] frobbed toml for divergentdave/certificate_carver written to work/ex/clippy-test-run/sources/stable/gh/divergentdave/certificate_carver/Cargo.toml [INFO] started frobbing divergentdave/certificate_carver [INFO] finished frobbing divergentdave/certificate_carver [INFO] frobbed toml for divergentdave/certificate_carver written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/divergentdave/certificate_carver/Cargo.toml [INFO] crate divergentdave/certificate_carver has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting divergentdave/certificate_carver against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/divergentdave/certificate_carver:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2c214862a3293393ef7ac7045b175e6622c9cffc0e08a6ee6cf3fc0e4c162d2f [INFO] running `"docker" "start" "-a" "2c214862a3293393ef7ac7045b175e6622c9cffc0e08a6ee6cf3fc0e4c162d2f"` [INFO] [stderr] Checking futures v0.1.19 [INFO] [stderr] Checking podio v0.1.6 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Compiling miniz_oxide_c_api v0.1.2 [INFO] [stderr] Compiling bzip2-sys v0.1.6 [INFO] [stderr] Checking miniz_oxide v0.1.2 [INFO] [stderr] Checking msdos_time v0.1.5 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking bzip2 v0.3.2 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Checking zip v0.3.1 [INFO] [stderr] Checking tokio-executor v0.1.0 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking relay v0.1.1 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.0 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking tokio-reactor v0.1.0 [INFO] [stderr] Checking tokio v0.1.3 [INFO] [stderr] Checking tokio-core v0.1.15 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.22 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking certificate_carver v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `TrustRoots` [INFO] [stderr] --> src/lib.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / pub fn new() -> TrustRoots { [INFO] [stderr] 184 | | TrustRoots { [INFO] [stderr] 185 | | root_fps: HashSet::new(), [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Carver` [INFO] [stderr] --> src/lib.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / pub fn new() -> Carver { [INFO] [stderr] 211 | | Carver { [INFO] [stderr] 212 | | map: HashMap::new(), [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:220:34 [INFO] [stderr] | [INFO] [stderr] 220 | let mut info = entry.or_insert(CertificateInfo::new(der.clone(), cert)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| CertificateInfo::new(der.clone(), cert))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:230:55 [INFO] [stderr] | [INFO] [stderr] 230 | static ref PEM_END_RE: Regex = Regex::new("-----END CERTIFICATE-----").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:320:75 [INFO] [stderr] | [INFO] [stderr] 320 | let mut issuer_fps = lookup.entry(subject_fp.clone()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:332:24 [INFO] [stderr] | [INFO] [stderr] 332 | fn recurse<'a, 'b>(fp: &'a CertificateFingerprint, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:371:22 [INFO] [stderr] | [INFO] [stderr] 371 | |fp| self.map.get(fp).unwrap().der.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[fp]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:405:40 [INFO] [stderr] | [INFO] [stderr] 405 | Nid::GENERATIONQUALIFIER]).into_iter().zip((&["C", "O", "OU", [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:407:51 [INFO] [stderr] | [INFO] [stderr] 407 | "Pseudonym", "Generation Qualifier"]).into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `certificate_carver`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `TrustRoots` [INFO] [stderr] --> src/lib.rs:183:5 [INFO] [stderr] | [INFO] [stderr] 183 | / pub fn new() -> TrustRoots { [INFO] [stderr] 184 | | TrustRoots { [INFO] [stderr] 185 | | root_fps: HashSet::new(), [INFO] [stderr] 186 | | } [INFO] [stderr] 187 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Carver` [INFO] [stderr] --> src/lib.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / pub fn new() -> Carver { [INFO] [stderr] 211 | | Carver { [INFO] [stderr] 212 | | map: HashMap::new(), [INFO] [stderr] 213 | | } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 205 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:220:34 [INFO] [stderr] | [INFO] [stderr] 220 | let mut info = entry.or_insert(CertificateInfo::new(der.clone(), cert)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| CertificateInfo::new(der.clone(), cert))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lib.rs:230:55 [INFO] [stderr] | [INFO] [stderr] 230 | static ref PEM_END_RE: Regex = Regex::new("-----END CERTIFICATE-----").unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:320:75 [INFO] [stderr] | [INFO] [stderr] 320 | let mut issuer_fps = lookup.entry(subject_fp.clone()).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/lib.rs:332:24 [INFO] [stderr] | [INFO] [stderr] 332 | fn recurse<'a, 'b>(fp: &'a CertificateFingerprint, [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:371:22 [INFO] [stderr] | [INFO] [stderr] 371 | |fp| self.map.get(fp).unwrap().der.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&self.map[fp]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:405:40 [INFO] [stderr] | [INFO] [stderr] 405 | Nid::GENERATIONQUALIFIER]).into_iter().zip((&["C", "O", "OU", [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/lib.rs:407:51 [INFO] [stderr] | [INFO] [stderr] 407 | "Pseudonym", "Generation Qualifier"]).into_iter()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `certificate_carver`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2c214862a3293393ef7ac7045b175e6622c9cffc0e08a6ee6cf3fc0e4c162d2f"` [INFO] running `"docker" "rm" "-f" "2c214862a3293393ef7ac7045b175e6622c9cffc0e08a6ee6cf3fc0e4c162d2f"` [INFO] [stdout] 2c214862a3293393ef7ac7045b175e6622c9cffc0e08a6ee6cf3fc0e4c162d2f