[INFO] updating cached repository diskkid/dcc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/diskkid/dcc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/diskkid/dcc" "work/ex/clippy-test-run/sources/stable/gh/diskkid/dcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/diskkid/dcc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/diskkid/dcc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diskkid/dcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diskkid/dcc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 842ca0c147e79c5f51b25ce3fad6165ca77963f9 [INFO] sha for GitHub repo diskkid/dcc: 842ca0c147e79c5f51b25ce3fad6165ca77963f9 [INFO] validating manifest of diskkid/dcc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of diskkid/dcc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing diskkid/dcc [INFO] finished frobbing diskkid/dcc [INFO] frobbed toml for diskkid/dcc written to work/ex/clippy-test-run/sources/stable/gh/diskkid/dcc/Cargo.toml [INFO] started frobbing diskkid/dcc [INFO] finished frobbing diskkid/dcc [INFO] frobbed toml for diskkid/dcc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diskkid/dcc/Cargo.toml [INFO] crate diskkid/dcc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting diskkid/dcc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/diskkid/dcc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 624cffd685669750b64de7fe90daeb1fe3ea59456f8bcc3ba580989ea7178b3d [INFO] running `"docker" "start" "-a" "624cffd685669750b64de7fe90daeb1fe3ea59456f8bcc3ba580989ea7178b3d"` [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking dcc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/token.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | if let Some(c) = chars.peek() { [INFO] [stderr] 51 | | match c { [INFO] [stderr] 52 | | '0'...'9' => { [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(c) = chars.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `used` [INFO] [stderr] --> src/regalloc.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | for i in 0..regs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 9 | for (i, ) in used.iter_mut().enumerate().take(regs.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/token.rs:49:17 [INFO] [stderr] | [INFO] [stderr] 49 | / loop { [INFO] [stderr] 50 | | if let Some(c) = chars.peek() { [INFO] [stderr] 51 | | match c { [INFO] [stderr] 52 | | '0'...'9' => { [INFO] [stderr] ... | [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(c) = chars.peek() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `used` [INFO] [stderr] --> src/regalloc.rs:9:22 [INFO] [stderr] | [INFO] [stderr] 9 | for i in 0..regs.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 9 | for (i, ) in used.iter_mut().enumerate().take(regs.len()) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.24s [INFO] running `"docker" "inspect" "624cffd685669750b64de7fe90daeb1fe3ea59456f8bcc3ba580989ea7178b3d"` [INFO] running `"docker" "rm" "-f" "624cffd685669750b64de7fe90daeb1fe3ea59456f8bcc3ba580989ea7178b3d"` [INFO] [stdout] 624cffd685669750b64de7fe90daeb1fe3ea59456f8bcc3ba580989ea7178b3d