[INFO] updating cached repository disjukr/adaptive-thresholding [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/disjukr/adaptive-thresholding [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/disjukr/adaptive-thresholding" "work/ex/clippy-test-run/sources/stable/gh/disjukr/adaptive-thresholding"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/disjukr/adaptive-thresholding'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/disjukr/adaptive-thresholding" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/disjukr/adaptive-thresholding"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/disjukr/adaptive-thresholding'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a699efd4510aca5c6807ac87c6a7f9fa1b73e300 [INFO] sha for GitHub repo disjukr/adaptive-thresholding: a699efd4510aca5c6807ac87c6a7f9fa1b73e300 [INFO] validating manifest of disjukr/adaptive-thresholding on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of disjukr/adaptive-thresholding on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing disjukr/adaptive-thresholding [INFO] finished frobbing disjukr/adaptive-thresholding [INFO] frobbed toml for disjukr/adaptive-thresholding written to work/ex/clippy-test-run/sources/stable/gh/disjukr/adaptive-thresholding/Cargo.toml [INFO] started frobbing disjukr/adaptive-thresholding [INFO] finished frobbing disjukr/adaptive-thresholding [INFO] frobbed toml for disjukr/adaptive-thresholding written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/disjukr/adaptive-thresholding/Cargo.toml [INFO] crate disjukr/adaptive-thresholding has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting disjukr/adaptive-thresholding against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/disjukr/adaptive-thresholding:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 53b943ce4d36aa017da297f2de88f029fe90f5684e185938bb07003475af4f24 [INFO] running `"docker" "start" "-a" "53b943ce4d36aa017da297f2de88f029fe90f5684e185938bb07003475af4f24"` [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking adaptive-thresholding v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | let c = integral_image.get_pixel(x1 - 1, y2).to_luma()[0] as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | let d = integral_image.get_pixel(x2, y2).to_luma()[0] as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let p = if curr <= (sum * (100 - threshold) / 100) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:89:17 [INFO] [stderr] | [INFO] [stderr] 89 | let c = integral_image.get_pixel(x1 - 1, y2).to_luma()[0] as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:90:17 [INFO] [stderr] | [INFO] [stderr] 90 | let d = integral_image.get_pixel(x2, y2).to_luma()[0] as i32; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | let p = if curr <= (sum * (100 - threshold) / 100) { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | sum += img.get_pixel(i, j).to_luma()[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(img.get_pixel(i, j).to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:24 [INFO] [stderr] | [INFO] [stderr] 92 | let curr = (img.get_pixel(i, j).to_luma()[0] as i32) * count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.get_pixel(i, j).to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:28:20 [INFO] [stderr] | [INFO] [stderr] 28 | sum += img.get_pixel(i, j).to_luma()[0] as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(img.get_pixel(i, j).to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:24 [INFO] [stderr] | [INFO] [stderr] 92 | let curr = (img.get_pixel(i, j).to_luma()[0] as i32) * count; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(img.get_pixel(i, j).to_luma()[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.17s [INFO] running `"docker" "inspect" "53b943ce4d36aa017da297f2de88f029fe90f5684e185938bb07003475af4f24"` [INFO] running `"docker" "rm" "-f" "53b943ce4d36aa017da297f2de88f029fe90f5684e185938bb07003475af4f24"` [INFO] [stdout] 53b943ce4d36aa017da297f2de88f029fe90f5684e185938bb07003475af4f24