[INFO] updating cached repository dirk/metriqsd [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dirk/metriqsd [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dirk/metriqsd" "work/ex/clippy-test-run/sources/stable/gh/dirk/metriqsd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dirk/metriqsd'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dirk/metriqsd" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dirk/metriqsd"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dirk/metriqsd'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 261131f92244a32b57e2c16364e1661db2d39b76 [INFO] sha for GitHub repo dirk/metriqsd: 261131f92244a32b57e2c16364e1661db2d39b76 [INFO] validating manifest of dirk/metriqsd on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dirk/metriqsd on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dirk/metriqsd [INFO] finished frobbing dirk/metriqsd [INFO] frobbed toml for dirk/metriqsd written to work/ex/clippy-test-run/sources/stable/gh/dirk/metriqsd/Cargo.toml [INFO] started frobbing dirk/metriqsd [INFO] finished frobbing dirk/metriqsd [INFO] frobbed toml for dirk/metriqsd written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dirk/metriqsd/Cargo.toml [INFO] crate dirk/metriqsd has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dirk/metriqsd against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dirk/metriqsd:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d8147161e4518a9592202b86d86f86094cb7699003524afeb13813cde1a112a7 [INFO] running `"docker" "start" "-a" "d8147161e4518a9592202b86d86f86094cb7699003524afeb13813cde1a112a7"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Compiling string_cache_codegen v0.4.0 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Compiling string_cache v0.7.1 [INFO] [stderr] Checking metriqs v0.1.6 [INFO] [stderr] Checking metriqsd v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/runner.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | for mut recv in self.recv.drain((..)) { [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/runner.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | for mut recv in self.recv.drain((..)) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/runner.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | for mut recv in self.recv.drain((..)) { [INFO] [stderr] | ^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/runner.rs:50:41 [INFO] [stderr] | [INFO] [stderr] 50 | for mut recv in self.recv.drain((..)) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/builder.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self { [INFO] [stderr] 160 | | &StatsdTcp(ref builder) => RecvRunnerKind::StatsdTcp(builder.build(&ctxt)), [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *self { [INFO] [stderr] 160 | StatsdTcp(ref builder) => RecvRunnerKind::StatsdTcp(builder.build(&ctxt)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/builder.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match self { [INFO] [stderr] 201 | | &mut StatsdTcp(ref mut listener) => listener.listen(), [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 200 | match *self { [INFO] [stderr] 201 | StatsdTcp(ref mut listener) => listener.listen(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/builder.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | / match self { [INFO] [stderr] 160 | | &StatsdTcp(ref builder) => RecvRunnerKind::StatsdTcp(builder.build(&ctxt)), [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *self { [INFO] [stderr] 160 | StatsdTcp(ref builder) => RecvRunnerKind::StatsdTcp(builder.build(&ctxt)), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/builder.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match self { [INFO] [stderr] 201 | | &mut StatsdTcp(ref mut listener) => listener.listen(), [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 200 | match *self { [INFO] [stderr] 201 | StatsdTcp(ref mut listener) => listener.listen(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.60s [INFO] running `"docker" "inspect" "d8147161e4518a9592202b86d86f86094cb7699003524afeb13813cde1a112a7"` [INFO] running `"docker" "rm" "-f" "d8147161e4518a9592202b86d86f86094cb7699003524afeb13813cde1a112a7"` [INFO] [stdout] d8147161e4518a9592202b86d86f86094cb7699003524afeb13813cde1a112a7