[INFO] updating cached repository dihedral-codes/rust-check-zds [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dihedral-codes/rust-check-zds [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dihedral-codes/rust-check-zds" "work/ex/clippy-test-run/sources/stable/gh/dihedral-codes/rust-check-zds"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dihedral-codes/rust-check-zds'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dihedral-codes/rust-check-zds" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dihedral-codes/rust-check-zds"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dihedral-codes/rust-check-zds'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f6fd49d4a6f0515a2b3b8f5afc5264f9806bd54 [INFO] sha for GitHub repo dihedral-codes/rust-check-zds: 9f6fd49d4a6f0515a2b3b8f5afc5264f9806bd54 [INFO] validating manifest of dihedral-codes/rust-check-zds on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dihedral-codes/rust-check-zds on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dihedral-codes/rust-check-zds [INFO] finished frobbing dihedral-codes/rust-check-zds [INFO] frobbed toml for dihedral-codes/rust-check-zds written to work/ex/clippy-test-run/sources/stable/gh/dihedral-codes/rust-check-zds/Cargo.toml [INFO] started frobbing dihedral-codes/rust-check-zds [INFO] finished frobbing dihedral-codes/rust-check-zds [INFO] frobbed toml for dihedral-codes/rust-check-zds written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dihedral-codes/rust-check-zds/Cargo.toml [INFO] crate dihedral-codes/rust-check-zds has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dihedral-codes/rust-check-zds against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dihedral-codes/rust-check-zds:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b6171309a21f8cff167cf9e4e8582cbc5185684ef8cf74b764ede5061deab67 [INFO] running `"docker" "start" "-a" "3b6171309a21f8cff167cf9e4e8582cbc5185684ef8cf74b764ede5061deab67"` [INFO] [stderr] Checking rust-check-zds v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | Bracelets {curr: curr} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `curr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | Bracelets {curr: curr} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `curr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | const MASK: u64 = 0xffffffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:8:19 [INFO] [stderr] | [INFO] [stderr] 8 | const MASK: u64 = 0xffffffffffff; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `a` [INFO] [stderr] --> src/main.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 22 | for (i, ) in a.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / if parity == 1 { [INFO] [stderr] 33 | | false [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | true [INFO] [stderr] 36 | | } [INFO] [stderr] | |___^ help: you can reduce it to: `!(parity == 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/main.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 97 | for in a.iter().take(K) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in reader.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | for line in reader.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `a` [INFO] [stderr] --> src/main.rs:22:12 [INFO] [stderr] | [INFO] [stderr] 22 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 22 | for (i, ) in a.iter_mut().enumerate().take(K) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/main.rs:32:3 [INFO] [stderr] | [INFO] [stderr] 32 | / if parity == 1 { [INFO] [stderr] 33 | | false [INFO] [stderr] 34 | | } else { [INFO] [stderr] 35 | | true [INFO] [stderr] 36 | | } [INFO] [stderr] | |___^ help: you can reduce it to: `!(parity == 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `a`. [INFO] [stderr] --> src/main.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | for i in 0..K { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 97 | for in a.iter().take(K) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in reader.lines().enumerate()` or similar iterators [INFO] [stderr] --> src/main.rs:117:15 [INFO] [stderr] | [INFO] [stderr] 117 | for line in reader.lines() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.50s [INFO] running `"docker" "inspect" "3b6171309a21f8cff167cf9e4e8582cbc5185684ef8cf74b764ede5061deab67"` [INFO] running `"docker" "rm" "-f" "3b6171309a21f8cff167cf9e4e8582cbc5185684ef8cf74b764ede5061deab67"` [INFO] [stdout] 3b6171309a21f8cff167cf9e4e8582cbc5185684ef8cf74b764ede5061deab67