[INFO] updating cached repository diejmon/rust_preferences
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/diejmon/rust_preferences
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/diejmon/rust_preferences" "work/ex/clippy-test-run/sources/stable/gh/diejmon/rust_preferences"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/diejmon/rust_preferences'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/diejmon/rust_preferences" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diejmon/rust_preferences"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diejmon/rust_preferences'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c12c7044c5d35afdc1ce0b5c4de773c9e9176cec
[INFO] sha for GitHub repo diejmon/rust_preferences: c12c7044c5d35afdc1ce0b5c4de773c9e9176cec
[INFO] validating manifest of diejmon/rust_preferences on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of diejmon/rust_preferences on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing diejmon/rust_preferences
[INFO] removed workspace from diejmon/rust_preferences
[INFO] finished frobbing diejmon/rust_preferences
[INFO] frobbed toml for diejmon/rust_preferences written to work/ex/clippy-test-run/sources/stable/gh/diejmon/rust_preferences/Cargo.toml
[INFO] started frobbing diejmon/rust_preferences
[INFO] removed workspace from diejmon/rust_preferences
[INFO] finished frobbing diejmon/rust_preferences
[INFO] frobbed toml for diejmon/rust_preferences written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diejmon/rust_preferences/Cargo.toml
[INFO] crate diejmon/rust_preferences has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting diejmon/rust_preferences against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/diejmon/rust_preferences:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bd301116f19cfe555e49d40c445410105dca2c6fe327ee67f5218034d52458c2
[INFO] running `"docker" "start" "-a" "bd301116f19cfe555e49d40c445410105dca2c6fe327ee67f5218034d52458c2"`
[INFO] [stderr]     Checking rust_preferences v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mem_prefs.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         return Preferences { values: Mutex::new(HashMap::new()) }
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Preferences { values: Mutex::new(HashMap::new()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mem_prefs::Preferences`
[INFO] [stderr]   --> src/mem_prefs.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> Preferences {
[INFO] [stderr] 12 | |         return Preferences { values: Mutex::new(HashMap::new()) }
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/mem_prefs.rs:12:9
[INFO] [stderr]    |
[INFO] [stderr] 12 |         return Preferences { values: Mutex::new(HashMap::new()) }
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Preferences { values: Mutex::new(HashMap::new()) }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mem_prefs::Preferences`
[INFO] [stderr]   --> src/mem_prefs.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 | /     pub fn new() -> Preferences {
[INFO] [stderr] 12 | |         return Preferences { values: Mutex::new(HashMap::new()) }
[INFO] [stderr] 13 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.00s
[INFO] running `"docker" "inspect" "bd301116f19cfe555e49d40c445410105dca2c6fe327ee67f5218034d52458c2"`
[INFO] running `"docker" "rm" "-f" "bd301116f19cfe555e49d40c445410105dca2c6fe327ee67f5218034d52458c2"`
[INFO] [stdout] bd301116f19cfe555e49d40c445410105dca2c6fe327ee67f5218034d52458c2