[INFO] updating cached repository diegoag666/flatworld-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/diegoag666/flatworld-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/diegoag666/flatworld-rs" "work/ex/clippy-test-run/sources/stable/gh/diegoag666/flatworld-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/diegoag666/flatworld-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/diegoag666/flatworld-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diegoag666/flatworld-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diegoag666/flatworld-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 87dc123c95bc505e2102b951d62ce134bcc6e9f7 [INFO] sha for GitHub repo diegoag666/flatworld-rs: 87dc123c95bc505e2102b951d62ce134bcc6e9f7 [INFO] validating manifest of diegoag666/flatworld-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of diegoag666/flatworld-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing diegoag666/flatworld-rs [INFO] finished frobbing diegoag666/flatworld-rs [INFO] frobbed toml for diegoag666/flatworld-rs written to work/ex/clippy-test-run/sources/stable/gh/diegoag666/flatworld-rs/Cargo.toml [INFO] started frobbing diegoag666/flatworld-rs [INFO] finished frobbing diegoag666/flatworld-rs [INFO] frobbed toml for diegoag666/flatworld-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/diegoag666/flatworld-rs/Cargo.toml [INFO] crate diegoag666/flatworld-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting diegoag666/flatworld-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/diegoag666/flatworld-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4117f7eb83f20af3deb3f41b8b81e7042c718ab23107e7638dc6a9fe557ec2da [INFO] running `"docker" "start" "-a" "4117f7eb83f20af3deb3f41b8b81e7042c718ab23107e7638dc6a9fe557ec2da"` [INFO] [stderr] Compiling flat v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Compiling glib-sys v0.4.0 [INFO] [stderr] Compiling gobject-sys v0.4.0 [INFO] [stderr] Compiling cairo-sys-rs v0.4.0 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Compiling cairo-rs v0.2.0 [INFO] [stderr] Checking glib v0.3.1 [INFO] [stderr] warning: function is never used: `use_program` [INFO] [stderr] --> src/graphics.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn use_program(p: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:55:49 [INFO] [stderr] | [INFO] [stderr] 55 | println!("version: {}", graphics::version().unwrap_or("error getting version".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "error getting version".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / match event { [INFO] [stderr] 77 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 78 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 79 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 77 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 78 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 79 | _ => () [INFO] [stderr] 80 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: function is never used: `use_program` [INFO] [stderr] --> src/graphics.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn use_program(p: u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/graphics.rs:149:31 [INFO] [stderr] | [INFO] [stderr] 149 | let mut success = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:55:49 [INFO] [stderr] | [INFO] [stderr] 55 | println!("version: {}", graphics::version().unwrap_or("error getting version".to_owned())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "error getting version".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:13 [INFO] [stderr] | [INFO] [stderr] 76 | / match event { [INFO] [stderr] 77 | | glutin::Event::WindowEvent{ event, .. } => match event { [INFO] [stderr] 78 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 79 | | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] ... | [INFO] [stderr] 82 | | _ => () [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | if let glutin::Event::WindowEvent{ event, .. } = event { match event { [INFO] [stderr] 77 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 78 | glutin::WindowEvent::Resized(w, h) => gl_window.resize(w, h), [INFO] [stderr] 79 | _ => () [INFO] [stderr] 80 | } } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.73s [INFO] running `"docker" "inspect" "4117f7eb83f20af3deb3f41b8b81e7042c718ab23107e7638dc6a9fe557ec2da"` [INFO] running `"docker" "rm" "-f" "4117f7eb83f20af3deb3f41b8b81e7042c718ab23107e7638dc6a9fe557ec2da"` [INFO] [stdout] 4117f7eb83f20af3deb3f41b8b81e7042c718ab23107e7638dc6a9fe557ec2da