[INFO] updating cached repository dicej/rust-https-example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dicej/rust-https-example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dicej/rust-https-example" "work/ex/clippy-test-run/sources/stable/gh/dicej/rust-https-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dicej/rust-https-example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dicej/rust-https-example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dicej/rust-https-example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dicej/rust-https-example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 29834e9b5fb02ba51902edbb4de13085c593b24a [INFO] sha for GitHub repo dicej/rust-https-example: 29834e9b5fb02ba51902edbb4de13085c593b24a [INFO] validating manifest of dicej/rust-https-example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dicej/rust-https-example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dicej/rust-https-example [INFO] finished frobbing dicej/rust-https-example [INFO] frobbed toml for dicej/rust-https-example written to work/ex/clippy-test-run/sources/stable/gh/dicej/rust-https-example/Cargo.toml [INFO] started frobbing dicej/rust-https-example [INFO] finished frobbing dicej/rust-https-example [INFO] frobbed toml for dicej/rust-https-example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dicej/rust-https-example/Cargo.toml [INFO] crate dicej/rust-https-example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dicej/rust-https-example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dicej/rust-https-example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e6befb5248f0dfc895a182bbc48c325fc32200258114a36c4b920fc24e89b56d [INFO] running `"docker" "start" "-a" "e6befb5248f0dfc895a182bbc48c325fc32200258114a36c4b920fc24e89b56d"` [INFO] [stderr] Compiling case v0.1.0 [INFO] [stderr] Checking openssl v0.9.15 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Compiling derive-error v0.0.3 [INFO] [stderr] Checking hyper v0.11.2 [INFO] [stderr] Checking native-tls v0.1.4 [INFO] [stderr] Checking tokio-tls v0.1.3 [INFO] [stderr] Checking websocket v0.20.2 [INFO] [stderr] Checking hyper-tls v0.1.2 [INFO] [stderr] Checking hello v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/udp.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | core.run(Server { socket: socket }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/udp.rs:43:23 [INFO] [stderr] | [INFO] [stderr] 43 | core.run(Server { socket: socket }).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/udp.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/udp.rs:31:35 [INFO] [stderr] | [INFO] [stderr] 31 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Error` [INFO] [stderr] --> src/main.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / enum MyError { [INFO] [stderr] 23 | | IoError(io::Error), [INFO] [stderr] 24 | | TlsError(native_tls::Error), [INFO] [stderr] 25 | | UriError(hyper::error::UriError), [INFO] [stderr] ... | [INFO] [stderr] 28 | | WebsocketError(websocket::WebSocketError) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same postfix: `Error` [INFO] [stderr] --> src/main.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | / enum MyError { [INFO] [stderr] 23 | | IoError(io::Error), [INFO] [stderr] 24 | | TlsError(native_tls::Error), [INFO] [stderr] 25 | | UriError(hyper::error::UriError), [INFO] [stderr] ... | [INFO] [stderr] 28 | | WebsocketError(websocket::WebSocketError) [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(m, _)| match m { [INFO] [stderr] | _______________________^ [INFO] [stderr] 62 | | Some(OwnedMessage::Text(text)) => println!("Got message: {}", text), [INFO] [stderr] 63 | | _=> (), [INFO] [stderr] 64 | | }); [INFO] [stderr] | |_________^ help: try this: `if let Some(OwnedMessage::Text(text)) = m { println!("Got message: {}", text) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:23 [INFO] [stderr] | [INFO] [stderr] 61 | .map(|(m, _)| match m { [INFO] [stderr] | _______________________^ [INFO] [stderr] 62 | | Some(OwnedMessage::Text(text)) => println!("Got message: {}", text), [INFO] [stderr] 63 | | _=> (), [INFO] [stderr] 64 | | }); [INFO] [stderr] | |_________^ help: try this: `if let Some(OwnedMessage::Text(text)) = m { println!("Got message: {}", text) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 16.98s [INFO] running `"docker" "inspect" "e6befb5248f0dfc895a182bbc48c325fc32200258114a36c4b920fc24e89b56d"` [INFO] running `"docker" "rm" "-f" "e6befb5248f0dfc895a182bbc48c325fc32200258114a36c4b920fc24e89b56d"` [INFO] [stdout] e6befb5248f0dfc895a182bbc48c325fc32200258114a36c4b920fc24e89b56d