[INFO] updating cached repository dialogbox/rust-working-samples
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dialogbox/rust-working-samples
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dialogbox/rust-working-samples" "work/ex/clippy-test-run/sources/stable/gh/dialogbox/rust-working-samples"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dialogbox/rust-working-samples'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dialogbox/rust-working-samples" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dialogbox/rust-working-samples"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dialogbox/rust-working-samples'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 9a95136d92277a7601147e25f9d76dd728dc0906
[INFO] sha for GitHub repo dialogbox/rust-working-samples: 9a95136d92277a7601147e25f9d76dd728dc0906
[INFO] validating manifest of dialogbox/rust-working-samples on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dialogbox/rust-working-samples on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dialogbox/rust-working-samples
[INFO] finished frobbing dialogbox/rust-working-samples
[INFO] frobbed toml for dialogbox/rust-working-samples written to work/ex/clippy-test-run/sources/stable/gh/dialogbox/rust-working-samples/Cargo.toml
[INFO] started frobbing dialogbox/rust-working-samples
[INFO] finished frobbing dialogbox/rust-working-samples
[INFO] frobbed toml for dialogbox/rust-working-samples written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dialogbox/rust-working-samples/Cargo.toml
[INFO] crate dialogbox/rust-working-samples has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dialogbox/rust-working-samples against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dialogbox/rust-working-samples:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] e374667321aeca9e119383ec886601ad7e83db74086d2c55c0d2b485a9a7fd5d
[INFO] running `"docker" "start" "-a" "e374667321aeca9e119383ec886601ad7e83db74086d2c55c0d2b485a9a7fd5d"`
[INFO] [stderr]     Checking tokio-io v0.1.8
[INFO] [stderr]    Compiling native-tls v0.2.1
[INFO] [stderr]     Checking tokio-codec v0.1.0
[INFO] [stderr]     Checking tokio-reactor v0.1.5
[INFO] [stderr]     Checking tokio-fs v0.1.3
[INFO] [stderr]     Checking h2 v0.1.12
[INFO] [stderr]     Checking tokio-udp v0.1.2
[INFO] [stderr]     Checking tokio-uds v0.2.1
[INFO] [stderr]     Checking tokio-tcp v0.1.1
[INFO] [stderr]     Checking tokio v0.1.8
[INFO] [stderr]     Checking hyper v0.12.9
[INFO] [stderr]     Checking hyper-tls v0.3.0
[INFO] [stderr]     Checking working-samples v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/word_count.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     return wordcount
[INFO] [stderr] 15 | |         .iter()
[INFO] [stderr] 16 | |         .map(|&(w, count)| (w.to_owned(), count))
[INFO] [stderr] 17 | |         .collect();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 14 |     wordcount
[INFO] [stderr] 15 |         .iter()
[INFO] [stderr] 16 |         .map(|&(w, count)| (w.to_owned(), count))
[INFO] [stderr] 17 |         .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/hn_client.rs:146:31
[INFO] [stderr]     |
[INFO] [stderr] 146 |         match client.get_item(17915371) {
[INFO] [stderr]     |                               ^^^^^^^^ help: consider: `17_915_371`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/hn_client.rs:226:17
[INFO] [stderr]     |
[INFO] [stderr] 226 |                 ()
[INFO] [stderr]     |                 ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unused_unit)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded unit expression
[INFO] [stderr]    --> src/hn_client.rs:248:17
[INFO] [stderr]     |
[INFO] [stderr] 248 |                 ()
[INFO] [stderr]     |                 ^^ help: remove the final `()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/word_count.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 | /     return wordcount
[INFO] [stderr] 15 | |         .iter()
[INFO] [stderr] 16 | |         .map(|&(w, count)| (w.to_owned(), count))
[INFO] [stderr] 17 | |         .collect();
[INFO] [stderr]    | |___________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 14 |     wordcount
[INFO] [stderr] 15 |         .iter()
[INFO] [stderr] 16 |         .map(|&(w, count)| (w.to_owned(), count))
[INFO] [stderr] 17 |         .collect()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `shear`
[INFO] [stderr]   --> src/traitsamples.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         fn shear(&mut self) {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `hn_client::HNClient`
[INFO] [stderr]   --> src/hn_client.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> Self {
[INFO] [stderr] 37 | |         let https = HttpsConnector::new(4).expect("TLS initialization failed");
[INFO] [stderr] 38 | |         let client = Client::builder().build::<_, Body>(https);
[INFO] [stderr] 39 | |
[INFO] [stderr] 40 | |         HNClient { client }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 | impl Default for hn_client::HNClient {
[INFO] [stderr] 36 |     fn default() -> Self {
[INFO] [stderr] 37 |         Self::new()
[INFO] [stderr] 38 |     }
[INFO] [stderr] 39 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `shear`
[INFO] [stderr]   --> src/traitsamples.rs:28:9
[INFO] [stderr]    |
[INFO] [stderr] 28 |         fn shear(&mut self) {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `hn_client::HNClient`
[INFO] [stderr]   --> src/hn_client.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 | /     pub fn new() -> Self {
[INFO] [stderr] 37 | |         let https = HttpsConnector::new(4).expect("TLS initialization failed");
[INFO] [stderr] 38 | |         let client = Client::builder().build::<_, Body>(https);
[INFO] [stderr] 39 | |
[INFO] [stderr] 40 | |         HNClient { client }
[INFO] [stderr] 41 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 35 | impl Default for hn_client::HNClient {
[INFO] [stderr] 36 |     fn default() -> Self {
[INFO] [stderr] 37 |         Self::new()
[INFO] [stderr] 38 |     }
[INFO] [stderr] 39 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/hn_client.rs:186:9
[INFO] [stderr]     |
[INFO] [stderr] 186 | /         match runtime.block_on(request) {
[INFO] [stderr] 187 | |             Ok(s) => {
[INFO] [stderr] 188 | |                 println!("After wait: Result: {:#?}", &s);
[INFO] [stderr] 189 | |             }
[INFO] [stderr] 190 | |             Err(_) => (),
[INFO] [stderr] 191 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 186 |         if let Ok(s) = runtime.block_on(request) {
[INFO] [stderr] 187 |     println!("After wait: Result: {:#?}", &s);
[INFO] [stderr] 188 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/hn_client.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 | /         match runtime.block_on(future::select_all(futures)) {
[INFO] [stderr] 225 | |             Ok(_) => {
[INFO] [stderr] 226 | |                 ()
[INFO] [stderr] 227 | |             }
[INFO] [stderr] 228 | |             Err(_) => (),
[INFO] [stderr] 229 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 224 |         if let Ok(_) = runtime.block_on(future::select_all(futures)) {
[INFO] [stderr] 225 |     ()
[INFO] [stderr] 226 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/hn_client.rs:246:9
[INFO] [stderr]     |
[INFO] [stderr] 246 | /         match runtime.block_on(future::select_all(futures)) {
[INFO] [stderr] 247 | |             Ok(_) => {
[INFO] [stderr] 248 | |                 ()
[INFO] [stderr] 249 | |             }
[INFO] [stderr] 250 | |             Err(_) => (),
[INFO] [stderr] 251 | |         };
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 246 |         if let Ok(_) = runtime.block_on(future::select_all(futures)) {
[INFO] [stderr] 247 |     ()
[INFO] [stderr] 248 | };
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/hn_client.rs:266:23
[INFO] [stderr]     |
[INFO] [stderr] 266 |               .and_then(|fs|
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 267 | |                 future::join_all(fs)
[INFO] [stderr]     | |____________________________________^ help: remove closure as shown: `future::join_all`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ownership_demo.rs:82:38
[INFO] [stderr]    |
[INFO] [stderr] 82 |         fn f2<'a: 'c, 'b: 'c, 'c>(a: &'a i64, b: &'b i64) -> &'c i64 {
[INFO] [stderr]    |                                      ^^^^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ownership_demo.rs:82:50
[INFO] [stderr]    |
[INFO] [stderr] 82 |         fn f2<'a: 'c, 'b: 'c, 'c>(a: &'a i64, b: &'b i64) -> &'c i64 {
[INFO] [stderr]    |                                                  ^^^^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/ownership_demo.rs:90:43
[INFO] [stderr]    |
[INFO] [stderr] 90 |         fn f3<'a: 'b, 'b>(a: &'a i64, _b: &'b i64) -> &'a i64 {
[INFO] [stderr]    |                                           ^^^^^^^ help: consider passing by value instead: `i64`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 25.40s
[INFO] running `"docker" "inspect" "e374667321aeca9e119383ec886601ad7e83db74086d2c55c0d2b485a9a7fd5d"`
[INFO] running `"docker" "rm" "-f" "e374667321aeca9e119383ec886601ad7e83db74086d2c55c0d2b485a9a7fd5d"`
[INFO] [stdout] e374667321aeca9e119383ec886601ad7e83db74086d2c55c0d2b485a9a7fd5d