[INFO] updating cached repository dhild/tanks [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dhild/tanks [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dhild/tanks" "work/ex/clippy-test-run/sources/stable/gh/dhild/tanks"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dhild/tanks'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dhild/tanks" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhild/tanks"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhild/tanks'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] cf50a698e4b3cda58f5d44f4089f2f02c6ab9a2a [INFO] sha for GitHub repo dhild/tanks: cf50a698e4b3cda58f5d44f4089f2f02c6ab9a2a [INFO] validating manifest of dhild/tanks on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dhild/tanks on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dhild/tanks [INFO] finished frobbing dhild/tanks [INFO] frobbed toml for dhild/tanks written to work/ex/clippy-test-run/sources/stable/gh/dhild/tanks/Cargo.toml [INFO] started frobbing dhild/tanks [INFO] finished frobbing dhild/tanks [INFO] frobbed toml for dhild/tanks written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhild/tanks/Cargo.toml [INFO] crate dhild/tanks has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dhild/tanks against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dhild/tanks:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3a347fa0c77dd1b860371214f49e9b7e2d3e881c52aeb391aa3b15697e04bfa0 [INFO] running `"docker" "start" "-a" "3a347fa0c77dd1b860371214f49e9b7e2d3e881c52aeb391aa3b15697e04bfa0"` [INFO] [stderr] Compiling rand v0.3.15 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking ticketed_lock v0.1.0 [INFO] [stderr] Checking humantime v1.0.0 [INFO] [stderr] Checking cgmath v0.12.0 [INFO] [stderr] Checking pulse v0.5.3 [INFO] [stderr] Checking ordered-float v0.4.0 [INFO] [stderr] Checking gfx_core v0.6.1 [INFO] [stderr] Checking serde_yaml v0.6.2 [INFO] [stderr] Checking x11-dl v2.13.0 [INFO] [stderr] Checking serde-value v0.4.1 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking chrono v0.3.0 [INFO] [stderr] Checking specs v0.8.1 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.0 [INFO] [stderr] Checking log4rs v0.6.3 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking gfx_device_gl v0.13.1 [INFO] [stderr] Checking gfx v0.14.1 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking gfx_window_glutin v0.14.0 [INFO] [stderr] Checking tanks v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | rtv: rtv, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rtv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | _dsv: _dsv, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `_dsv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/explosion/draw.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/ai.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/ai.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | controls: controls, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `controls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | world.add_resource(Players { players: players }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/state.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/physics/components.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/projectile/draw.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/projectile/firing.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/control.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | slice_body: slice_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `slice_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | slice_barrel: slice_barrel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `slice_barrel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/draw.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/mod.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | t: t, [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | char_info: char_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | device: device, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `device` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | factory: factory, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `factory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | rtv: rtv, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rtv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw/window.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | _dsv: _dsv, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `_dsv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/explosion/draw.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/ai.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/ai.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | controls: controls, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `controls` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/player.rs:57:38 [INFO] [stderr] | [INFO] [stderr] 57 | world.add_resource(Players { players: players }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `players` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/game/state.rs:115:31 [INFO] [stderr] | [INFO] [stderr] 115 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/physics/components.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/projectile/draw.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/projectile/firing.rs:22:14 [INFO] [stderr] | [INFO] [stderr] 22 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/control.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | player: player, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `player` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:20:17 [INFO] [stderr] | [INFO] [stderr] 20 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:24:17 [INFO] [stderr] | [INFO] [stderr] 24 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | slice_body: slice_body, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `slice_body` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | slice_barrel: slice_barrel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `slice_barrel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tank/draw.rs:105:13 [INFO] [stderr] | [INFO] [stderr] 105 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/draw.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/mod.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | t: t, [INFO] [stderr] | ^^^^ help: replace it with: `t` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/terrain/mod.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | p: p, [INFO] [stderr] | ^^^^ help: replace it with: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:116:13 [INFO] [stderr] | [INFO] [stderr] 116 | font: font, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `font` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/font.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | char_info: char_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `char_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:21:17 [INFO] [stderr] | [INFO] [stderr] 21 | color: color, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `color` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | vbuf: vbuf, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `vbuf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | pso: pso, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pso` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/text/draw/mod.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/explosion/draw.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | const SHADER_VERT: &'static [u8] = include_bytes!("explosion.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/explosion/draw.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | const SHADER_FRAG: &'static [u8] = include_bytes!("explosion.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/explosion/draw.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | const SHADER_VERT: &'static [u8] = include_bytes!("explosion.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/explosion/draw.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | const SHADER_FRAG: &'static [u8] = include_bytes!("explosion.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/projectile/draw.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | const SHADER_VERT: &'static [u8] = include_bytes!("projectile.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/projectile/draw.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | const SHADER_FRAG: &'static [u8] = include_bytes!("projectile.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/projectile/draw.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | const SHADER_VERT: &'static [u8] = include_bytes!("projectile.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/projectile/draw.rs:53:21 [INFO] [stderr] | [INFO] [stderr] 53 | const SHADER_FRAG: &'static [u8] = include_bytes!("projectile.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tank/draw.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | const SHADER_VERT: &'static [u8] = include_bytes!("tank.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tank/draw.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | const SHADER_FRAG: &'static [u8] = include_bytes!("tank.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/terrain/draw.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | const SHADER_VERT: &'static [u8] = include_bytes!("terrain.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/terrain/draw.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | const SHADER_FRAG: &'static [u8] = include_bytes!("terrain.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tank/draw.rs:64:21 [INFO] [stderr] | [INFO] [stderr] 64 | const SHADER_VERT: &'static [u8] = include_bytes!("tank.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tank/draw.rs:65:21 [INFO] [stderr] | [INFO] [stderr] 65 | const SHADER_FRAG: &'static [u8] = include_bytes!("tank.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/terrain/draw.rs:62:21 [INFO] [stderr] | [INFO] [stderr] 62 | const SHADER_VERT: &'static [u8] = include_bytes!("terrain.v.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/terrain/draw.rs:63:21 [INFO] [stderr] | [INFO] [stderr] 63 | const SHADER_FRAG: &'static [u8] = include_bytes!("terrain.f.glsl"); [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tank/control.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut tank = match tanks.get_mut(player.id()) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tank/control.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | let mut tank = match tanks.get_mut(player.id()) { [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game/state.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | if !(&projectiles.check()).join().next().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&projectiles.check()).join().next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/draw.rs:54:49 [INFO] [stderr] | [INFO] [stderr] 54 | vec![Vertex::new(i as f32, *h as f32), [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | x if x < 0.0 => self.heightmap[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:35:60 [INFO] [stderr] | [INFO] [stderr] 35 | x if x >= (self.heightmap.len() - 1) as f32 => *self.heightmap.last().unwrap() as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(*self.heightmap.last().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | let y0 = self.heightmap[i as usize] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | let y1 = self.heightmap[i as usize + 1] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | let y0 = self.heightmap[i] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | let y1 = self.heightmap[i + 1] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let min = (height as f64) * 0.3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let max = (height as f64) * 0.7; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | let dx = width as f64 / count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | while last_t <= (width as f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | min: (height as f64) * 0.2, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | max: (height as f64) * 0.8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | let x = x as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/text/draw/mod.rs:27:73 [INFO] [stderr] | [INFO] [stderr] 27 | fn update(&mut self, dim: &Dimensions, text: &str, screen_position: &Point2, scale: f32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Point2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/game/state.rs:147:12 [INFO] [stderr] | [INFO] [stderr] 147 | if !(&projectiles.check()).join().next().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(&projectiles.check()).join().next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/draw.rs:54:49 [INFO] [stderr] | [INFO] [stderr] 54 | vec![Vertex::new(i as f32, *h as f32), [INFO] [stderr] | ^^^^^^^^^ help: try: `f32::from(*h)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:34:29 [INFO] [stderr] | [INFO] [stderr] 34 | x if x < 0.0 => self.heightmap[0] as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:35:60 [INFO] [stderr] | [INFO] [stderr] 35 | x if x >= (self.heightmap.len() - 1) as f32 => *self.heightmap.last().unwrap() as f32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(*self.heightmap.last().unwrap())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | let y0 = self.heightmap[i as usize] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i as usize])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:38:26 [INFO] [stderr] | [INFO] [stderr] 38 | let y1 = self.heightmap[i as usize + 1] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:51:22 [INFO] [stderr] | [INFO] [stderr] 51 | let y0 = self.heightmap[i] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:52:22 [INFO] [stderr] | [INFO] [stderr] 52 | let y1 = self.heightmap[i + 1] as f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.heightmap[i + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:67:19 [INFO] [stderr] | [INFO] [stderr] 67 | let min = (height as f64) * 0.3; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:68:19 [INFO] [stderr] | [INFO] [stderr] 68 | let max = (height as f64) * 0.7; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | let dx = width as f64 / count as f64; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:78:25 [INFO] [stderr] | [INFO] [stderr] 78 | while last_t <= (width as f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:87:18 [INFO] [stderr] | [INFO] [stderr] 87 | min: (height as f64) * 0.2, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:88:18 [INFO] [stderr] | [INFO] [stderr] 88 | max: (height as f64) * 0.8, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/terrain/mod.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | let x = x as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/text/draw/mod.rs:27:73 [INFO] [stderr] | [INFO] [stderr] 27 | fn update(&mut self, dim: &Dimensions, text: &str, screen_position: &Point2, scale: f32) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `Point2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.56s [INFO] running `"docker" "inspect" "3a347fa0c77dd1b860371214f49e9b7e2d3e881c52aeb391aa3b15697e04bfa0"` [INFO] running `"docker" "rm" "-f" "3a347fa0c77dd1b860371214f49e9b7e2d3e881c52aeb391aa3b15697e04bfa0"` [INFO] [stdout] 3a347fa0c77dd1b860371214f49e9b7e2d3e881c52aeb391aa3b15697e04bfa0