[INFO] updating cached repository dherman/headless-tarball-fetch
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dherman/headless-tarball-fetch
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dherman/headless-tarball-fetch" "work/ex/clippy-test-run/sources/stable/gh/dherman/headless-tarball-fetch"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dherman/headless-tarball-fetch'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dherman/headless-tarball-fetch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dherman/headless-tarball-fetch"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dherman/headless-tarball-fetch'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 43c25302eee394af05a6444bd06b45308113a32f
[INFO] sha for GitHub repo dherman/headless-tarball-fetch: 43c25302eee394af05a6444bd06b45308113a32f
[INFO] validating manifest of dherman/headless-tarball-fetch on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dherman/headless-tarball-fetch on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dherman/headless-tarball-fetch
[INFO] finished frobbing dherman/headless-tarball-fetch
[INFO] frobbed toml for dherman/headless-tarball-fetch written to work/ex/clippy-test-run/sources/stable/gh/dherman/headless-tarball-fetch/Cargo.toml
[INFO] started frobbing dherman/headless-tarball-fetch
[INFO] finished frobbing dherman/headless-tarball-fetch
[INFO] frobbed toml for dherman/headless-tarball-fetch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dherman/headless-tarball-fetch/Cargo.toml
[INFO] crate dherman/headless-tarball-fetch has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] [stderr]     Blocking waiting for file lock on the registry index
[INFO] linting dherman/headless-tarball-fetch against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dherman/headless-tarball-fetch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ca4d1ceb89a034a35c90c9a7a46d18b605e2b6f57d6c8027370c3430c6102b55
[INFO] running `"docker" "start" "-a" "ca4d1ceb89a034a35c90c9a7a46d18b605e2b6f57d6c8027370c3430c6102b55"`
[INFO] [stderr]     Checking serde_urlencoded v0.5.4
[INFO] [stderr]     Checking h2 v0.1.14
[INFO] [stderr]     Checking tokio-reactor v0.1.7
[INFO] [stderr]     Checking tokio-threadpool v0.1.9
[INFO] [stderr]     Checking tokio-uds v0.2.4
[INFO] [stderr]     Checking tokio-udp v0.1.3
[INFO] [stderr]     Checking tokio-tcp v0.1.2
[INFO] [stderr]     Checking tokio-fs v0.1.4
[INFO] [stderr]     Checking tokio v0.1.13
[INFO] [stderr]     Checking hyper v0.12.17
[INFO] [stderr]     Checking hyper-tls v0.3.1
[INFO] [stderr]     Checking reqwest v0.9.5
[INFO] [stderr]     Checking headless-tarball-fetch v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/remote_tarball.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         ((packed[0] as u32)      ) +
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/remote_tarball.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/main.rs:8:14
[INFO] [stderr]   |
[INFO] [stderr] 8 | const NODE: &'static str = "https://nodejs.org/dist/v6.15.1/node-v6.15.1-darwin-x64.tar.gz";
[INFO] [stderr]   |             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:10:14
[INFO] [stderr]    |
[INFO] [stderr] 10 | const YARN: &'static str = "https://github.com/yarnpkg/yarn/releases/download/v1.12.3/yarn-v1.12.3.tar.gz";
[INFO] [stderr]    |             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:23:43
[INFO] [stderr]    |
[INFO] [stderr] 23 |     assert_eq!(tarball.compressed_size(), 12294157);
[INFO] [stderr]    |                                           ^^^^^^^^ help: consider: `12_294_157`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:24:59
[INFO] [stderr]    |
[INFO] [stderr] 24 |     assert_eq!(tarball.uncompressed_size().unwrap(), Some(46173184));
[INFO] [stderr]    |                                                           ^^^^^^^^ help: consider: `46_173_184`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:30:43
[INFO] [stderr]    |
[INFO] [stderr] 30 |     assert_eq!(tarball.compressed_size(), 1166553);
[INFO] [stderr]    |                                           ^^^^^^^ help: consider: `1_166_553`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:31:59
[INFO] [stderr]    |
[INFO] [stderr] 31 |     assert_eq!(tarball.uncompressed_size().unwrap(), Some(4904960));
[INFO] [stderr]    |                                                           ^^^^^^^ help: consider: `4_904_960`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Consider removing unnecessary double parentheses
[INFO] [stderr]   --> src/remote_tarball.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         ((packed[0] as u32)      ) +
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::double_parens)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/remote_tarball.rs:103:9
[INFO] [stderr]     |
[INFO] [stderr] 103 |         return false;
[INFO] [stderr]     |         ^^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/main.rs:10:14
[INFO] [stderr]    |
[INFO] [stderr] 10 | const YARN: &'static str = "https://github.com/yarnpkg/yarn/releases/download/v1.12.3/yarn-v1.12.3.tar.gz";
[INFO] [stderr]    |             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         ((packed[0] as u32)      ) +
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:32:10
[INFO] [stderr]    |
[INFO] [stderr] 32 |         ((packed[1] as u32) <<  8) +
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:33:10
[INFO] [stderr]    |
[INFO] [stderr] 33 |         ((packed[2] as u32) << 16) +
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:34:10
[INFO] [stderr]    |
[INFO] [stderr] 34 |         ((packed[3] as u32) << 24);
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     unpacked32 as u64
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: try: `u64::from(unpacked32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/remote_tarball.rs:99:13
[INFO] [stderr]     |
[INFO] [stderr] 99  | /             if let Some(s) = value.to_str().ok() {
[INFO] [stderr] 100 | |                 return s.trim() == "bytes";
[INFO] [stderr] 101 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(s)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         ((packed[0] as u32)      ) +
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[0])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:32:10
[INFO] [stderr]    |
[INFO] [stderr] 32 |         ((packed[1] as u32) <<  8) +
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[1])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:33:10
[INFO] [stderr]    |
[INFO] [stderr] 33 |         ((packed[2] as u32) << 16) +
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[2])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:34:10
[INFO] [stderr]    |
[INFO] [stderr] 34 |         ((packed[3] as u32) << 24);
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(packed[3])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/remote_tarball.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     unpacked32 as u64
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^ help: try: `u64::from(unpacked32)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: Matching on `Some` with `ok()` is redundant
[INFO] [stderr]    --> src/remote_tarball.rs:99:13
[INFO] [stderr]     |
[INFO] [stderr] 99  | /             if let Some(s) = value.to_str().ok() {
[INFO] [stderr] 100 | |                 return s.trim() == "bytes";
[INFO] [stderr] 101 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::if_let_some_result)] on by default
[INFO] [stderr]     = help: Consider matching on `Ok(s)` and removing the call to `ok` instead
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_let_some_result
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 31.28s
[INFO] running `"docker" "inspect" "ca4d1ceb89a034a35c90c9a7a46d18b605e2b6f57d6c8027370c3430c6102b55"`
[INFO] running `"docker" "rm" "-f" "ca4d1ceb89a034a35c90c9a7a46d18b605e2b6f57d6c8027370c3430c6102b55"`
[INFO] [stdout] ca4d1ceb89a034a35c90c9a7a46d18b605e2b6f57d6c8027370c3430c6102b55