[INFO] updating cached repository dhad05/GoL [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dhad05/GoL [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dhad05/GoL" "work/ex/clippy-test-run/sources/stable/gh/dhad05/GoL"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dhad05/GoL'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dhad05/GoL" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhad05/GoL"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhad05/GoL'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1fd595c08af0c30127fef610fb69d55efeef789f [INFO] sha for GitHub repo dhad05/GoL: 1fd595c08af0c30127fef610fb69d55efeef789f [INFO] validating manifest of dhad05/GoL on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dhad05/GoL on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dhad05/GoL [INFO] finished frobbing dhad05/GoL [INFO] frobbed toml for dhad05/GoL written to work/ex/clippy-test-run/sources/stable/gh/dhad05/GoL/Cargo.toml [INFO] started frobbing dhad05/GoL [INFO] finished frobbing dhad05/GoL [INFO] frobbed toml for dhad05/GoL written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dhad05/GoL/Cargo.toml [INFO] crate dhad05/GoL has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dhad05/GoL against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dhad05/GoL:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dc3470f5b1447b36f3d84cf8a00912efa0d57379668ea43ad3963acf69fa3973 [INFO] running `"docker" "start" "-a" "dc3470f5b1447b36f3d84cf8a00912efa0d57379668ea43ad3963acf69fa3973"` [INFO] [stderr] Checking libc v0.2.11 [INFO] [stderr] Checking bitflags v0.5.0 [INFO] [stderr] Compiling gdk-pixbuf v0.1.3 [INFO] [stderr] Compiling gio v0.1.3 [INFO] [stderr] Compiling cairo-rs v0.1.3 [INFO] [stderr] Compiling gdk v0.5.3 [INFO] [stderr] Compiling gtk v0.1.3 [INFO] [stderr] Compiling glib-sys v0.3.4 [INFO] [stderr] Compiling gobject-sys v0.3.4 [INFO] [stderr] Compiling gio-sys v0.3.4 [INFO] [stderr] Compiling cairo-sys-rs v0.3.4 [INFO] [stderr] Compiling pango-sys v0.3.4 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.3.4 [INFO] [stderr] Compiling atk-sys v0.3.4 [INFO] [stderr] Compiling gdk-sys v0.3.4 [INFO] [stderr] Compiling gtk-sys v0.3.4 [INFO] [stderr] Checking rand v0.3.14 [INFO] [stderr] Checking glib v0.1.3 [INFO] [stderr] Checking pango v0.1.3 [INFO] [stderr] Checking GoL v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | / (|x: i32| { [INFO] [stderr] 205 | | this.set_size_request(WIDTH*x, HEIGHT*x); [INFO] [stderr] 206 | | cr.scale(x as f64, x as f64); [INFO] [stderr] 207 | | }) (*cell_size.lock().unwrap()); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: crate `GoL` should have a snake case name such as `go_l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ret`. [INFO] [stderr] --> src/main.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | for i in 0..WIDTH as usize { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for in ret.iter_mut().take(WIDTH as usize) { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match self.get(x, y) { [INFO] [stderr] 106 | | Some(u) => nei[i as usize][j as usize] += u, [INFO] [stderr] 107 | | None => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(u) = self.get(x, y) { nei[i as usize][j as usize] += u }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:126:47 [INFO] [stderr] | [INFO] [stderr] 126 | for i in 0..WIDTH as usize { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self[i][..HEIGHT as usize].clone_from_slice(&s[i][..HEIGHT as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | cr.scale(x as f64, x as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:206:36 [INFO] [stderr] | [INFO] [stderr] 206 | cr.scale(x as f64, x as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `map` [INFO] [stderr] --> src/main.rs:211:22 [INFO] [stderr] | [INFO] [stderr] 211 | for i in 0..WIDTH as usize { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 211 | for (i, ) in map.iter().enumerate().take(WIDTH as usize) { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / match loop_thread.join() { [INFO] [stderr] 370 | | Err(_) => println!("Some error ocured"), [INFO] [stderr] 371 | | Ok(_) => (), [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = loop_thread.join() { println!("Some error ocured") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: Try not to call a closure in the expression where it is declared. [INFO] [stderr] --> src/main.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | / (|x: i32| { [INFO] [stderr] 205 | | this.set_size_request(WIDTH*x, HEIGHT*x); [INFO] [stderr] 206 | | cr.scale(x as f64, x as f64); [INFO] [stderr] 207 | | }) (*cell_size.lock().unwrap()); [INFO] [stderr] | |___________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_call [INFO] [stderr] [INFO] [stderr] warning: crate `GoL` should have a snake case name such as `go_l` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `ret`. [INFO] [stderr] --> src/main.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | for i in 0..WIDTH as usize { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 72 | for in ret.iter_mut().take(WIDTH as usize) { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | / match self.get(x, y) { [INFO] [stderr] 106 | | Some(u) => nei[i as usize][j as usize] += u, [INFO] [stderr] 107 | | None => (), [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(u) = self.get(x, y) { nei[i as usize][j as usize] += u }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/main.rs:126:47 [INFO] [stderr] | [INFO] [stderr] 126 | for i in 0..WIDTH as usize { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try replacing the loop by: `self[i][..HEIGHT as usize].clone_from_slice(&s[i][..HEIGHT as usize])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:206:26 [INFO] [stderr] | [INFO] [stderr] 206 | cr.scale(x as f64, x as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:206:36 [INFO] [stderr] | [INFO] [stderr] 206 | cr.scale(x as f64, x as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `map` [INFO] [stderr] --> src/main.rs:211:22 [INFO] [stderr] | [INFO] [stderr] 211 | for i in 0..WIDTH as usize { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 211 | for (i, ) in map.iter().enumerate().take(WIDTH as usize) { for j in 0..HEIGHT as usize { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:369:5 [INFO] [stderr] | [INFO] [stderr] 369 | / match loop_thread.join() { [INFO] [stderr] 370 | | Err(_) => println!("Some error ocured"), [INFO] [stderr] 371 | | Ok(_) => (), [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(_) = loop_thread.join() { println!("Some error ocured") }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 44.88s [INFO] running `"docker" "inspect" "dc3470f5b1447b36f3d84cf8a00912efa0d57379668ea43ad3963acf69fa3973"` [INFO] running `"docker" "rm" "-f" "dc3470f5b1447b36f3d84cf8a00912efa0d57379668ea43ad3963acf69fa3973"` [INFO] [stdout] dc3470f5b1447b36f3d84cf8a00912efa0d57379668ea43ad3963acf69fa3973