[INFO] updating cached repository dgtony/jctl2gray [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dgtony/jctl2gray [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dgtony/jctl2gray" "work/ex/clippy-test-run/sources/stable/gh/dgtony/jctl2gray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dgtony/jctl2gray'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dgtony/jctl2gray" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgtony/jctl2gray"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgtony/jctl2gray'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2191fa326acb0edf3f06b1a2a35725bbd2805deb [INFO] sha for GitHub repo dgtony/jctl2gray: 2191fa326acb0edf3f06b1a2a35725bbd2805deb [INFO] validating manifest of dgtony/jctl2gray on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dgtony/jctl2gray on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dgtony/jctl2gray [INFO] finished frobbing dgtony/jctl2gray [INFO] frobbed toml for dgtony/jctl2gray written to work/ex/clippy-test-run/sources/stable/gh/dgtony/jctl2gray/Cargo.toml [INFO] started frobbing dgtony/jctl2gray [INFO] finished frobbing dgtony/jctl2gray [INFO] frobbed toml for dgtony/jctl2gray written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgtony/jctl2gray/Cargo.toml [INFO] crate dgtony/jctl2gray has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dgtony/jctl2gray against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dgtony/jctl2gray:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b31aacfeb68f0403563bf50d1b1bd100924debe3c358c1f0faa4c7e3af743d0 [INFO] running `"docker" "start" "-a" "1b31aacfeb68f0403563bf50d1b1bd100924debe3c358c1f0faa4c7e3af743d0"` [INFO] [stderr] Checking loggerv v0.7.1 [INFO] [stderr] Checking jctl2gray v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gelf/chunked_message.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return ChunkedMessageId::from_bytes(bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ChunkedMessageId::from_bytes(bytes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gelf/compression.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | encoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gelf/compression.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | let encoded = encoder.finish().into_result()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gelf/compression.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | encoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gelf/compression.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | let encoded = encoder.finish().into_result()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/processing.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gelf/chunked_message.rs:163:9 [INFO] [stderr] | [INFO] [stderr] 163 | return ChunkedMessageId::from_bytes(bytes); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ChunkedMessageId::from_bytes(bytes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:219:13 [INFO] [stderr] | [INFO] [stderr] 219 | 0xffffffffffffffff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | 0x0000000000000000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:221:13 [INFO] [stderr] | [INFO] [stderr] 221 | 0xaaaaaaaaaaaaaaaa, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xaaaa_aaaa_aaaa_aaaa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:222:13 [INFO] [stderr] | [INFO] [stderr] 222 | 0x5555555555555555, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x5555_5555_5555_5555` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:223:13 [INFO] [stderr] | [INFO] [stderr] 223 | 0x0001020304050607, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0001_0203_0405_0607` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | 0x0706050403020100, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0706_0504_0302_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | 0x0010203040506070, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0010_2030_4050_6070` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:226:13 [INFO] [stderr] | [INFO] [stderr] 226 | 0x7060504030201000, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x7060_5040_3020_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/gelf/chunked_message.rs:306:34 [INFO] [stderr] | [INFO] [stderr] 306 | chunking(CHUNK_SIZE_WAN, 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gelf/compression.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | encoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gelf/compression.rs:45:31 [INFO] [stderr] | [INFO] [stderr] 45 | let encoded = encoder.finish().into_result()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/gelf/compression.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | encoded [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/gelf/compression.rs:53:31 [INFO] [stderr] | [INFO] [stderr] 53 | let encoded = encoder.finish().into_result()?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/processing.rs:233:5 [INFO] [stderr] | [INFO] [stderr] 233 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gelf/chunked_message.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn size(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `gelf::chunked_message::ChunkedMessage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/gelf/chunked_message.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / impl ChunkedMessage { [INFO] [stderr] 46 | | /// Construct a new ChunkedMessage [INFO] [stderr] 47 | | /// [INFO] [stderr] 48 | | /// Several sanity checks are performed on construction: [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | let size = chunk_size.size() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chunk_size.size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.num_chunks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:76:66 [INFO] [stderr] | [INFO] [stderr] 76 | self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CHUNK_OVERHEAD)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chunk_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `b` is only used to index `bytes`. [INFO] [stderr] --> src/gelf/chunked_message.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | for b in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 159 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:189:54 [INFO] [stderr] | [INFO] [stderr] 189 | self.0.iter().fold(0_u64, |id, &i| id << 8 | i as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gelf/compression.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn compress(&self, message: &WireMessage) -> Result> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gelf/level.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn to_num(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/gelf/wire_message.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | ChunkedMessage::new(chunk_size, msg).ok_or(Error::InternalError(format!( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 51 | | "failed to split message on {}-bytes chunks", [INFO] [stderr] 52 | | chunk_size.size() [INFO] [stderr] 53 | | ))) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | ChunkedMessage::new(chunk_size, msg).ok_or_else(|| Error::InternalError(format!( [INFO] [stderr] 51 | "failed to split message on {}-bytes chunks", [INFO] [stderr] 52 | chunk_size.size() [INFO] [stderr] 53 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/gelf/wire_message.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | for (k, v) in self.optional.clone().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.optional.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gelf/wire_message.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn new(fields: &'a Vec<(String, String)>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/wire_message.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | ts.as_secs() as f64 + ts.subsec_nanos() as f64 / 1_000_000_000 as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ts.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/wire_message.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | ts.as_secs() as f64 + ts.subsec_nanos() as f64 / 1_000_000_000 as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1_000_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processing.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | format!("operating system currently unsupported"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"operating system currently unsupported".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/processing.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if msg.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/processing.rs:208:44 [INFO] [stderr] | [INFO] [stderr] 208 | Some(msg.set_timestamp(t / 1_000_000 as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(1_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/processing.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / if cfg!(target_os = "linux") { [INFO] [stderr] 238 | | true [INFO] [stderr] 239 | | } else { [INFO] [stderr] 240 | | false [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `cfg!(target_os = "linux")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/processing.rs:265:36 [INFO] [stderr] | [INFO] [stderr] 265 | let target_addr = addrs.next().ok_or(io::Error::new( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 266 | | io::ErrorKind::Other, [INFO] [stderr] 267 | | "empty address list", [INFO] [stderr] 268 | | ))?; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 265 | let target_addr = addrs.next().ok_or_else(|| io::Error::new( [INFO] [stderr] 266 | io::ErrorKind::Other, [INFO] [stderr] 267 | "empty address list", [INFO] [stderr] 268 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gelf/chunked_message.rs:28:17 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn size(&self) -> u16 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `gelf::chunked_message::ChunkedMessage` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/gelf/chunked_message.rs:45:1 [INFO] [stderr] | [INFO] [stderr] 45 | / impl ChunkedMessage { [INFO] [stderr] 46 | | /// Construct a new ChunkedMessage [INFO] [stderr] 47 | | /// [INFO] [stderr] 48 | | /// Several sanity checks are performed on construction: [INFO] [stderr] ... | [INFO] [stderr] 85 | | } [INFO] [stderr] 86 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:58:20 [INFO] [stderr] | [INFO] [stderr] 58 | let size = chunk_size.size() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chunk_size.size())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:76:41 [INFO] [stderr] | [INFO] [stderr] 76 | self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(self.num_chunks)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:76:66 [INFO] [stderr] | [INFO] [stderr] 76 | self.payload.len() as u64 + self.num_chunks as u64 * CHUNK_OVERHEAD as u64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CHUNK_OVERHEAD)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:119:28 [INFO] [stderr] | [INFO] [stderr] 119 | let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.chunk_num)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:119:52 [INFO] [stderr] | [INFO] [stderr] 119 | let slice_start = (self.chunk_num as u32 * chunk_size as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the loop variable `b` is only used to index `bytes`. [INFO] [stderr] --> src/gelf/chunked_message.rs:159:18 [INFO] [stderr] | [INFO] [stderr] 159 | for b in 0..8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 159 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:189:54 [INFO] [stderr] | [INFO] [stderr] 189 | self.0.iter().fold(0_u64, |id, &i| id << 8 | i as u64) [INFO] [stderr] | ^^^^^^^^ help: try: `u64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/gelf/chunked_message.rs:211:51 [INFO] [stderr] | [INFO] [stderr] 211 | let id = ChunkedMessageId::from_bytes(raw_id.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*raw_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:248:55 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(msg_2_chunks.len() as u32, 2 + 2 * CHUNK_OVERHEAD as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(CHUNK_OVERHEAD)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:251:25 [INFO] [stderr] | [INFO] [stderr] 251 | 128 + 128 * (CHUNK_OVERHEAD as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CHUNK_OVERHEAD)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:313:25 [INFO] [stderr] | [INFO] [stderr] 313 | (msg_size / chunk_size as u32) as u8 + 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:352:32 [INFO] [stderr] | [INFO] [stderr] 352 | let first_index = (counter as u32 * chunk_size as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:352:49 [INFO] [stderr] | [INFO] [stderr] 352 | let first_index = (counter as u32 * chunk_size as u32) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:354:35 [INFO] [stderr] | [INFO] [stderr] 354 | (::std::cmp::min((counter as u32 + 1) * chunk_size as u32, msg_size) - 1) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u32::from(counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/gelf/chunked_message.rs:354:57 [INFO] [stderr] | [INFO] [stderr] 354 | (::std::cmp::min((counter as u32 + 1) * chunk_size as u32, msg_size) - 1) as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(chunk_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gelf/compression.rs:35:21 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn compress(&self, message: &WireMessage) -> Result> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/gelf/level.rs:35:19 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn to_num(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/gelf/wire_message.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | ChunkedMessage::new(chunk_size, msg).ok_or(Error::InternalError(format!( [INFO] [stderr] | ______________________________________________^ [INFO] [stderr] 51 | | "failed to split message on {}-bytes chunks", [INFO] [stderr] 52 | | chunk_size.size() [INFO] [stderr] 53 | | ))) [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 50 | ChunkedMessage::new(chunk_size, msg).ok_or_else(|| Error::InternalError(format!( [INFO] [stderr] 51 | "failed to split message on {}-bytes chunks", [INFO] [stderr] 52 | chunk_size.size() [INFO] [stderr] 53 | ))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/gelf/wire_message.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | for (k, v) in self.optional.clone().into_iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.optional.clone()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/gelf/wire_message.rs:117:24 [INFO] [stderr] | [INFO] [stderr] 117 | pub fn new(fields: &'a Vec<(String, String)>) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/wire_message.rs:141:27 [INFO] [stderr] | [INFO] [stderr] 141 | ts.as_secs() as f64 + ts.subsec_nanos() as f64 / 1_000_000_000 as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(ts.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gelf/wire_message.rs:141:54 [INFO] [stderr] | [INFO] [stderr] 141 | ts.as_secs() as f64 + ts.subsec_nanos() as f64 / 1_000_000_000 as f64 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1_000_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/processing.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | format!("operating system currently unsupported"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"operating system currently unsupported".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/processing.rs:66:16 [INFO] [stderr] | [INFO] [stderr] 66 | if msg.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `msg.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/processing.rs:208:44 [INFO] [stderr] | [INFO] [stderr] 208 | Some(msg.set_timestamp(t / 1_000_000 as f64)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(1_000_000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/processing.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | / if cfg!(target_os = "linux") { [INFO] [stderr] 238 | | true [INFO] [stderr] 239 | | } else { [INFO] [stderr] 240 | | false [INFO] [stderr] 241 | | } [INFO] [stderr] | |_____^ help: you can reduce it to: `cfg!(target_os = "linux")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/processing.rs:265:36 [INFO] [stderr] | [INFO] [stderr] 265 | let target_addr = addrs.next().ok_or(io::Error::new( [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 266 | | io::ErrorKind::Other, [INFO] [stderr] 267 | | "empty address list", [INFO] [stderr] 268 | | ))?; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 265 | let target_addr = addrs.next().ok_or_else(|| io::Error::new( [INFO] [stderr] 266 | io::ErrorKind::Other, [INFO] [stderr] 267 | "empty address list", [INFO] [stderr] 268 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/jctl2gray.rs:208:34 [INFO] [stderr] | [INFO] [stderr] 208 | data.map(|field| field.split("=")) [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/jctl2gray.rs:223:26 [INFO] [stderr] | [INFO] [stderr] 223 | fn print_opt_fields(opt: &Vec<(String, String)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/bin/jctl2gray.rs:208:34 [INFO] [stderr] | [INFO] [stderr] 208 | data.map(|field| field.split("=")) [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/jctl2gray.rs:223:26 [INFO] [stderr] | [INFO] [stderr] 223 | fn print_opt_fields(opt: &Vec<(String, String)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(String, String)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.76s [INFO] running `"docker" "inspect" "1b31aacfeb68f0403563bf50d1b1bd100924debe3c358c1f0faa4c7e3af743d0"` [INFO] running `"docker" "rm" "-f" "1b31aacfeb68f0403563bf50d1b1bd100924debe3c358c1f0faa4c7e3af743d0"` [INFO] [stdout] 1b31aacfeb68f0403563bf50d1b1bd100924debe3c358c1f0faa4c7e3af743d0