[INFO] updating cached repository dgryski/rust-bf
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dgryski/rust-bf
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dgryski/rust-bf" "work/ex/clippy-test-run/sources/stable/gh/dgryski/rust-bf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dgryski/rust-bf'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dgryski/rust-bf" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgryski/rust-bf"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgryski/rust-bf'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 55367368761b008d634fa5ca72aafd16ec827eb4
[INFO] sha for GitHub repo dgryski/rust-bf: 55367368761b008d634fa5ca72aafd16ec827eb4
[INFO] validating manifest of dgryski/rust-bf on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dgryski/rust-bf on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dgryski/rust-bf
[INFO] finished frobbing dgryski/rust-bf
[INFO] frobbed toml for dgryski/rust-bf written to work/ex/clippy-test-run/sources/stable/gh/dgryski/rust-bf/Cargo.toml
[INFO] started frobbing dgryski/rust-bf
[INFO] finished frobbing dgryski/rust-bf
[INFO] frobbed toml for dgryski/rust-bf written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgryski/rust-bf/Cargo.toml
[INFO] crate dgryski/rust-bf has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dgryski/rust-bf against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dgryski/rust-bf:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 35a0a810de5442b2fea14a850aff506c74d72a2066819e7663bb76058ba2a4c4
[INFO] running `"docker" "start" "-a" "35a0a810de5442b2fea14a850aff506c74d72a2066819e7663bb76058ba2a4c4"`
[INFO] [stderr]     Checking bf v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `arg1`
[INFO] [stderr]   --> src/main.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let ref arg1 = args[1];
[INFO] [stderr]    |             ^^^^ help: consider using `_arg1` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `arg1`
[INFO] [stderr]   --> src/main.rs:17:13
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let ref arg1 = args[1];
[INFO] [stderr]    |             ^^^^ help: consider using `_arg1` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let ref arg1 = args[1];
[INFO] [stderr]    |     ----^^^^^^^^----------- help: try: `let arg1 = &args[1];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         io::stderr().write(err.as_bytes());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:17:9
[INFO] [stderr]    |
[INFO] [stderr] 17 |     let ref arg1 = args[1];
[INFO] [stderr]    |     ----^^^^^^^^----------- help: try: `let arg1 = &args[1];`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:31:9
[INFO] [stderr]    |
[INFO] [stderr] 31 |         io::stderr().write(err.as_bytes());
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:76:31
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn calculate_offsets(program: &vec::Vec<u8>) -> Vec<usize> {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:100:18
[INFO] [stderr]     |
[INFO] [stderr] 100 |         if *p == '[' as u8 {
[INFO] [stderr]     |                  ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:106:57
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 if seen_open == 0 && program[dst_ip] == ']' as u8 {
[INFO] [stderr]     |                                                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:110:39
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if program[dst_ip] == '[' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:113:39
[INFO] [stderr]     |
[INFO] [stderr] 113 |                 if program[dst_ip] == ']' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:117:25
[INFO] [stderr]     |
[INFO] [stderr] 117 |         } else if *p == ']' as u8 {
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:123:58
[INFO] [stderr]     |
[INFO] [stderr] 123 |                 if seen_close == 0 && program[dst_ip] == '[' as u8 {
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:127:39
[INFO] [stderr]     |
[INFO] [stderr] 127 |                 if program[dst_ip] == ']' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:130:39
[INFO] [stderr]     |
[INFO] [stderr] 130 |                 if program[dst_ip] == '[' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/main.rs:76:31
[INFO] [stderr]    |
[INFO] [stderr] 76 | fn calculate_offsets(program: &vec::Vec<u8>) -> Vec<usize> {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:245:17
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 depth = depth + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `depth += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:249:17
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 depth = depth - 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `depth -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:100:18
[INFO] [stderr]     |
[INFO] [stderr] 100 |         if *p == '[' as u8 {
[INFO] [stderr]     |                  ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::char_lit_as_u8)] on by default
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:106:57
[INFO] [stderr]     |
[INFO] [stderr] 106 |                 if seen_open == 0 && program[dst_ip] == ']' as u8 {
[INFO] [stderr]     |                                                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:110:39
[INFO] [stderr]     |
[INFO] [stderr] 110 |                 if program[dst_ip] == '[' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:113:39
[INFO] [stderr]     |
[INFO] [stderr] 113 |                 if program[dst_ip] == ']' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:117:25
[INFO] [stderr]     |
[INFO] [stderr] 117 |         } else if *p == ']' as u8 {
[INFO] [stderr]     |                         ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:123:58
[INFO] [stderr]     |
[INFO] [stderr] 123 |                 if seen_close == 0 && program[dst_ip] == '[' as u8 {
[INFO] [stderr]     |                                                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:127:39
[INFO] [stderr]     |
[INFO] [stderr] 127 |                 if program[dst_ip] == ']' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b']'
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them
[INFO] [stderr]    --> src/main.rs:130:39
[INFO] [stderr]     |
[INFO] [stderr] 130 |                 if program[dst_ip] == '[' as u8 {
[INFO] [stderr]     |                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: Consider using a byte literal instead:
[INFO] [stderr]             b'['
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:245:17
[INFO] [stderr]     |
[INFO] [stderr] 245 |                 depth = depth + 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `depth += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/main.rs:249:17
[INFO] [stderr]     |
[INFO] [stderr] 249 |                 depth = depth - 1;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^ help: replace it with: `depth -= 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.15s
[INFO] running `"docker" "inspect" "35a0a810de5442b2fea14a850aff506c74d72a2066819e7663bb76058ba2a4c4"`
[INFO] running `"docker" "rm" "-f" "35a0a810de5442b2fea14a850aff506c74d72a2066819e7663bb76058ba2a4c4"`
[INFO] [stdout] 35a0a810de5442b2fea14a850aff506c74d72a2066819e7663bb76058ba2a4c4