[INFO] updating cached repository dgodd/conway_game_of_life_rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dgodd/conway_game_of_life_rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dgodd/conway_game_of_life_rust" "work/ex/clippy-test-run/sources/stable/gh/dgodd/conway_game_of_life_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dgodd/conway_game_of_life_rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dgodd/conway_game_of_life_rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgodd/conway_game_of_life_rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgodd/conway_game_of_life_rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a2d8e0702a2c794a3758ace7133cec15c3c0e64 [INFO] sha for GitHub repo dgodd/conway_game_of_life_rust: 6a2d8e0702a2c794a3758ace7133cec15c3c0e64 [INFO] validating manifest of dgodd/conway_game_of_life_rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dgodd/conway_game_of_life_rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dgodd/conway_game_of_life_rust [INFO] finished frobbing dgodd/conway_game_of_life_rust [INFO] frobbed toml for dgodd/conway_game_of_life_rust written to work/ex/clippy-test-run/sources/stable/gh/dgodd/conway_game_of_life_rust/Cargo.toml [INFO] started frobbing dgodd/conway_game_of_life_rust [INFO] finished frobbing dgodd/conway_game_of_life_rust [INFO] frobbed toml for dgodd/conway_game_of_life_rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgodd/conway_game_of_life_rust/Cargo.toml [INFO] crate dgodd/conway_game_of_life_rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dgodd/conway_game_of_life_rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dgodd/conway_game_of_life_rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b954bd256f18c09a3d4edad4455c8ed9bd7d026f8a8cc8b6aba49d8c1a1df1a0 [INFO] running `"docker" "start" "-a" "b954bd256f18c09a3d4edad4455c8ed9bd7d026f8a8cc8b6aba49d8c1a1df1a0"` [INFO] [stderr] Checking crossterm v0.4.2 [INFO] [stderr] Checking conway_game_of_life_rust v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | fn num_alive_neighbours(old: &Vec>, x: usize, y: usize) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `xp` is used to index `old` [INFO] [stderr] --> src/main.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | for xp in (cmp::max(x, 1)-1)..=cmp::min(x+1,max-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 12 | for (xp, ) in old.iter().enumerate().take(cmp::min(x+1,max-1) + 1).skip((cmp::max(x, 1)-1)) { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | fn conway_string(population: &Vec>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:8:30 [INFO] [stderr] | [INFO] [stderr] 8 | fn num_alive_neighbours(old: &Vec>, x: usize, y: usize) -> u8 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `xp` is used to index `old` [INFO] [stderr] --> src/main.rs:12:19 [INFO] [stderr] | [INFO] [stderr] 12 | for xp in (cmp::max(x, 1)-1)..=cmp::min(x+1,max-1) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 12 | for (xp, ) in old.iter().enumerate().take(cmp::min(x+1,max-1) + 1).skip((cmp::max(x, 1)-1)) { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | fn conway_string(population: &Vec>) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change this to: `&[Vec]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.93s [INFO] running `"docker" "inspect" "b954bd256f18c09a3d4edad4455c8ed9bd7d026f8a8cc8b6aba49d8c1a1df1a0"` [INFO] running `"docker" "rm" "-f" "b954bd256f18c09a3d4edad4455c8ed9bd7d026f8a8cc8b6aba49d8c1a1df1a0"` [INFO] [stdout] b954bd256f18c09a3d4edad4455c8ed9bd7d026f8a8cc8b6aba49d8c1a1df1a0