[INFO] updating cached repository dgodd/concourse-summary-rust-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dgodd/concourse-summary-rust-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dgodd/concourse-summary-rust-2018" "work/ex/clippy-test-run/sources/stable/gh/dgodd/concourse-summary-rust-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dgodd/concourse-summary-rust-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dgodd/concourse-summary-rust-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgodd/concourse-summary-rust-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgodd/concourse-summary-rust-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f330e93bad067f83ee6b58eadd2fed39c29ca626 [INFO] sha for GitHub repo dgodd/concourse-summary-rust-2018: f330e93bad067f83ee6b58eadd2fed39c29ca626 [INFO] validating manifest of dgodd/concourse-summary-rust-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dgodd/concourse-summary-rust-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dgodd/concourse-summary-rust-2018 [INFO] finished frobbing dgodd/concourse-summary-rust-2018 [INFO] frobbed toml for dgodd/concourse-summary-rust-2018 written to work/ex/clippy-test-run/sources/stable/gh/dgodd/concourse-summary-rust-2018/Cargo.toml [INFO] started frobbing dgodd/concourse-summary-rust-2018 [INFO] finished frobbing dgodd/concourse-summary-rust-2018 [INFO] frobbed toml for dgodd/concourse-summary-rust-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgodd/concourse-summary-rust-2018/Cargo.toml [INFO] crate dgodd/concourse-summary-rust-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dgodd/concourse-summary-rust-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dgodd/concourse-summary-rust-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 096f1533b192abbb532bb1d848c7998e339cf7828f8dd8475fe345928700d66b [INFO] running `"docker" "start" "-a" "096f1533b192abbb532bb1d848c7998e339cf7828f8dd8475fe345928700d66b"` [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.2 [INFO] [stderr] Checking concourse-summary-rust-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/main.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fly.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn get_rc(home: &str) -> Result, Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/fly.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | for ref job in &jobs { [INFO] [stderr] | ^^^^^^^ ----- help: try: `let job = &&jobs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/fly.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | let ref mut pipeline = pipelines[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------- help: try: `let pipeline = &mut pipelines[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fly.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | pub fn get_rc(home: &str) -> Result, Box> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/fly.rs:93:9 [INFO] [stderr] | [INFO] [stderr] 93 | for ref job in &jobs { [INFO] [stderr] | ^^^^^^^ ----- help: try: `let job = &&jobs;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/fly.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | let ref mut pipeline = pipelines[*i]; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------- help: try: `let pipeline = &mut pipelines[*i];` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 18.42s [INFO] running `"docker" "inspect" "096f1533b192abbb532bb1d848c7998e339cf7828f8dd8475fe345928700d66b"` [INFO] running `"docker" "rm" "-f" "096f1533b192abbb532bb1d848c7998e339cf7828f8dd8475fe345928700d66b"` [INFO] [stdout] 096f1533b192abbb532bb1d848c7998e339cf7828f8dd8475fe345928700d66b