[INFO] updating cached repository dghaehre/mysql-csv
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dghaehre/mysql-csv
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dghaehre/mysql-csv" "work/ex/clippy-test-run/sources/stable/gh/dghaehre/mysql-csv"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dghaehre/mysql-csv'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dghaehre/mysql-csv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dghaehre/mysql-csv"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dghaehre/mysql-csv'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8383d2690bfdc07025f721cfb8e9f5df75831174
[INFO] sha for GitHub repo dghaehre/mysql-csv: 8383d2690bfdc07025f721cfb8e9f5df75831174
[INFO] validating manifest of dghaehre/mysql-csv on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dghaehre/mysql-csv on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dghaehre/mysql-csv
[INFO] finished frobbing dghaehre/mysql-csv
[INFO] frobbed toml for dghaehre/mysql-csv written to work/ex/clippy-test-run/sources/stable/gh/dghaehre/mysql-csv/Cargo.toml
[INFO] started frobbing dghaehre/mysql-csv
[INFO] finished frobbing dghaehre/mysql-csv
[INFO] frobbed toml for dghaehre/mysql-csv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dghaehre/mysql-csv/Cargo.toml
[INFO] crate dghaehre/mysql-csv has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dghaehre/mysql-csv against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dghaehre/mysql-csv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] d738bb838f2fd8359b877a92f5fc2b0c4844bac4a23f64a1cd53199598e845e1
[INFO] running `"docker" "start" "-a" "d738bb838f2fd8359b877a92f5fc2b0c4844bac4a23f64a1cd53199598e845e1"`
[INFO] [stderr]     Checking libc v0.2.42
[INFO] [stderr]     Checking memchr v2.0.1
[INFO] [stderr]     Checking csv-core v0.1.4
[INFO] [stderr]     Checking csv v1.0.0
[INFO] [stderr]     Checking mysql-csv v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:38:23
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return Rows { id: id, data: HashMap::new()}
[INFO] [stderr]    |                       ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:185:64
[INFO] [stderr]     |
[INFO] [stderr] 185 |     write_file( CsvData { filename: String::from(args.output), header: header, rows: rows })
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:185:80
[INFO] [stderr]     |
[INFO] [stderr] 185 |     write_file( CsvData { filename: String::from(args.output), header: header, rows: rows })
[INFO] [stderr]     |                                                                                ^^^^^^^^^^ help: replace it with: `rows`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:38:23
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return Rows { id: id, data: HashMap::new()}
[INFO] [stderr]    |                       ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:185:64
[INFO] [stderr]     |
[INFO] [stderr] 185 |     write_file( CsvData { filename: String::from(args.output), header: header, rows: rows })
[INFO] [stderr]     |                                                                ^^^^^^^^^^^^^^ help: replace it with: `header`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:185:80
[INFO] [stderr]     |
[INFO] [stderr] 185 |     write_file( CsvData { filename: String::from(args.output), header: header, rows: rows })
[INFO] [stderr]     |                                                                                ^^^^^^^^^^ help: replace it with: `rows`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             return Err("Wrong arguments");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Wrong arguments")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             return Ok(Arguments { input: args[1].clone(), output: args[2].clone() });
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arguments { input: args[1].clone(), output: args[2].clone() })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return Rows { id: id, data: HashMap::new()}
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rows { id: id, data: HashMap::new()}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             nr
[INFO] [stderr]    |             ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:69:22
[INFO] [stderr]    |
[INFO] [stderr] 69 |               let nr = match parsed {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 70 | |                 Ok(nr) => (true, nr),
[INFO] [stderr] 71 | |                 Err(_) => (false, 0)
[INFO] [stderr] 72 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:79:24
[INFO] [stderr]    |
[INFO] [stderr] 79 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 80 | |                     if nr < 10 {
[INFO] [stderr] 81 | |                         id * 10 + nr
[INFO] [stderr] 82 | |                     } else {
[INFO] [stderr] 83 | |                         nr
[INFO] [stderr] 84 | |                     }
[INFO] [stderr] 85 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 } else if nr < 10 {
[INFO] [stderr] 80 |     id * 10 + nr
[INFO] [stderr] 81 | } else {
[INFO] [stderr] 82 |     nr
[INFO] [stderr] 83 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:28:13
[INFO] [stderr]    |
[INFO] [stderr] 28 |             return Err("Wrong arguments");
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Wrong arguments")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:30:13
[INFO] [stderr]    |
[INFO] [stderr] 30 |             return Ok(Arguments { input: args[1].clone(), output: args[2].clone() });
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Arguments { input: args[1].clone(), output: args[2].clone() })`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/lib.rs:38:9
[INFO] [stderr]    |
[INFO] [stderr] 38 |         return Rows { id: id, data: HashMap::new()}
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Rows { id: id, data: HashMap::new()}`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/lib.rs:73:13
[INFO] [stderr]    |
[INFO] [stderr] 73 |             nr
[INFO] [stderr]    |             ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/lib.rs:69:22
[INFO] [stderr]    |
[INFO] [stderr] 69 |               let nr = match parsed {
[INFO] [stderr]    |  ______________________^
[INFO] [stderr] 70 | |                 Ok(nr) => (true, nr),
[INFO] [stderr] 71 | |                 Err(_) => (false, 0)
[INFO] [stderr] 72 | |             };
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/lib.rs:79:24
[INFO] [stderr]    |
[INFO] [stderr] 79 |                   } else {
[INFO] [stderr]    |  ________________________^
[INFO] [stderr] 80 | |                     if nr < 10 {
[INFO] [stderr] 81 | |                         id * 10 + nr
[INFO] [stderr] 82 | |                     } else {
[INFO] [stderr] 83 | |                         nr
[INFO] [stderr] 84 | |                     }
[INFO] [stderr] 85 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 79 |                 } else if nr < 10 {
[INFO] [stderr] 80 |     id * 10 + nr
[INFO] [stderr] 81 | } else {
[INFO] [stderr] 82 |     nr
[INFO] [stderr] 83 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `value`
[INFO] [stderr]    --> src/lib.rs:136:15
[INFO] [stderr]     |
[INFO] [stderr] 136 |     for (key, value) in &row {
[INFO] [stderr]     |               ^^^^^ help: consider using `_value` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `default_no`
[INFO] [stderr]    --> src/lib.rs:146:9
[INFO] [stderr]     |
[INFO] [stderr] 146 |     let default_no = String::from("NOHEADER");
[INFO] [stderr]     |         ^^^^^^^^^^ help: consider using `_default_no` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `value`
[INFO] [stderr]    --> src/lib.rs:136:15
[INFO] [stderr]     |
[INFO] [stderr] 136 |     for (key, value) in &row {
[INFO] [stderr]     |               ^^^^^ help: consider using `_value` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `default_no`
[INFO] [stderr]    --> src/lib.rs:146:9
[INFO] [stderr]     |
[INFO] [stderr] 146 |     let default_no = String::from("NOHEADER");
[INFO] [stderr]     |         ^^^^^^^^^^ help: consider using `_default_no` instead
[INFO] [stderr] warning: field is never used: `id`
[INFO] [stderr]   --> src/lib.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     id: u16,
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:42:30
[INFO] [stderr]    |
[INFO] [stderr] 42 |             self.data.insert(String::from(key), String::from(value));
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `key`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:42:49
[INFO] [stderr]    |
[INFO] [stderr] 42 |             self.data.insert(String::from(key), String::from(value));
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn parse_line(line: &String) -> Option<(String, String)> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib.rs:48:41
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let vec: Vec<&str> = line.split(":").collect();
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:115:51
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     rows[i].add_line(String::from(line.clone()));
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     rows[i].add_line(String::from(&(*line).clone()));
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     rows[i].add_line(String::from(&str::clone(line)));
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:130:24
[INFO] [stderr]     |
[INFO] [stderr] 130 | fn create_header(rows: &Vec<Rows>) -> Result<Vec<String>, &'static str> {
[INFO] [stderr]     |                        ^^^^^^^^^^ help: change this to: `&[Rows]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:185:37
[INFO] [stderr]     |
[INFO] [stderr] 185 |     write_file( CsvData { filename: String::from(args.output), header: header, rows: rows })
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args.output`
[INFO] [stderr] warning: field is never used: `id`
[INFO] [stderr]   --> src/lib.rs:14:5
[INFO] [stderr]    |
[INFO] [stderr] 14 |     id: u16,
[INFO] [stderr]    |     ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:42:30
[INFO] [stderr]    |
[INFO] [stderr] 42 |             self.data.insert(String::from(key), String::from(value));
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `key`
[INFO] [stderr]    |
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:42:49
[INFO] [stderr]    |
[INFO] [stderr] 42 |             self.data.insert(String::from(key), String::from(value));
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `value`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/lib.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 | fn parse_line(line: &String) -> Option<(String, String)> {
[INFO] [stderr]    |                     ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/lib.rs:48:41
[INFO] [stderr]    |
[INFO] [stderr] 48 |         let vec: Vec<&str> = line.split(":").collect();
[INFO] [stderr]    |                                         ^^^ help: try using a char instead: `':'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mysql-csv`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:115:51
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     rows[i].add_line(String::from(line.clone()));
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     rows[i].add_line(String::from(&(*line).clone()));
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 115 |                     rows[i].add_line(String::from(&str::clone(line)));
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/lib.rs:130:24
[INFO] [stderr]     |
[INFO] [stderr] 130 | fn create_header(rows: &Vec<Rows>) -> Result<Vec<String>, &'static str> {
[INFO] [stderr]     |                        ^^^^^^^^^^ help: change this to: `&[Rows]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/lib.rs:185:37
[INFO] [stderr]     |
[INFO] [stderr] 185 |     write_file( CsvData { filename: String::from(args.output), header: header, rows: rows })
[INFO] [stderr]     |                                     ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `args.output`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mysql-csv`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "d738bb838f2fd8359b877a92f5fc2b0c4844bac4a23f64a1cd53199598e845e1"`
[INFO] running `"docker" "rm" "-f" "d738bb838f2fd8359b877a92f5fc2b0c4844bac4a23f64a1cd53199598e845e1"`
[INFO] [stdout] d738bb838f2fd8359b877a92f5fc2b0c4844bac4a23f64a1cd53199598e845e1