[INFO] updating cached repository dgarcia202/rftp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dgarcia202/rftp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dgarcia202/rftp" "work/ex/clippy-test-run/sources/stable/gh/dgarcia202/rftp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dgarcia202/rftp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dgarcia202/rftp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgarcia202/rftp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgarcia202/rftp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3528f25c511c2bdc2fa553908e852d6ec8d5dc8e [INFO] sha for GitHub repo dgarcia202/rftp: 3528f25c511c2bdc2fa553908e852d6ec8d5dc8e [INFO] validating manifest of dgarcia202/rftp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dgarcia202/rftp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dgarcia202/rftp [INFO] finished frobbing dgarcia202/rftp [INFO] frobbed toml for dgarcia202/rftp written to work/ex/clippy-test-run/sources/stable/gh/dgarcia202/rftp/Cargo.toml [INFO] started frobbing dgarcia202/rftp [INFO] finished frobbing dgarcia202/rftp [INFO] frobbed toml for dgarcia202/rftp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dgarcia202/rftp/Cargo.toml [INFO] crate dgarcia202/rftp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dgarcia202/rftp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dgarcia202/rftp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e72509fcbc1844aafe881fea761e732a2d907a797daa7e9601081d638c829075 [INFO] running `"docker" "start" "-a" "e72509fcbc1844aafe881fea761e732a2d907a797daa7e9601081d638c829075"` [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Checking rftp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: The function/method `push_str` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | user_command.push_str(&mut username); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_command_to_server` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | send_command_to_server(writer, &mut user_command)?; // enter login [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `push_str` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | pass_command.push_str(&mut password); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_command_to_server` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | send_command_to_server(writer, &mut pass_command)?; // enter password [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/command.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | writer.write(command.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/command.rs:150:24 [INFO] [stderr] | [INFO] [stderr] 150 | fn save_to_file(bytes: &Vec, file_name: &str) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/command.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | file.write(&buff_small)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_command_to_server` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:77:49 [INFO] [stderr] | [INFO] [stderr] 77 | send_command_to_server(&mut writer, &mut cwd_command)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rftp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: The function/method `push_str` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:29:27 [INFO] [stderr] | [INFO] [stderr] 29 | user_command.push_str(&mut username); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_command_to_server` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:32:36 [INFO] [stderr] | [INFO] [stderr] 32 | send_command_to_server(writer, &mut user_command)?; // enter login [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `push_str` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | pass_command.push_str(&mut password); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_command_to_server` doesn't need a mutable reference [INFO] [stderr] --> src/command.rs:46:36 [INFO] [stderr] | [INFO] [stderr] 46 | send_command_to_server(writer, &mut pass_command)?; // enter password [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/command.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | writer.write(command.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/command.rs:150:24 [INFO] [stderr] | [INFO] [stderr] 150 | fn save_to_file(bytes: &Vec, file_name: &str) -> Result<(), io::Error> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/command.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | file.write(&buff_small)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: The function/method `send_command_to_server` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:77:49 [INFO] [stderr] | [INFO] [stderr] 77 | send_command_to_server(&mut writer, &mut cwd_command)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `rftp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "e72509fcbc1844aafe881fea761e732a2d907a797daa7e9601081d638c829075"` [INFO] running `"docker" "rm" "-f" "e72509fcbc1844aafe881fea761e732a2d907a797daa7e9601081d638c829075"` [INFO] [stdout] e72509fcbc1844aafe881fea761e732a2d907a797daa7e9601081d638c829075