[INFO] updating cached repository dfaust/cockroachdb-test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dfaust/cockroachdb-test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dfaust/cockroachdb-test" "work/ex/clippy-test-run/sources/stable/gh/dfaust/cockroachdb-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dfaust/cockroachdb-test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dfaust/cockroachdb-test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dfaust/cockroachdb-test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dfaust/cockroachdb-test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6094d159ac8df6321fabc2aaa2e39b0e8bb27136 [INFO] sha for GitHub repo dfaust/cockroachdb-test: 6094d159ac8df6321fabc2aaa2e39b0e8bb27136 [INFO] validating manifest of dfaust/cockroachdb-test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dfaust/cockroachdb-test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dfaust/cockroachdb-test [INFO] finished frobbing dfaust/cockroachdb-test [INFO] frobbed toml for dfaust/cockroachdb-test written to work/ex/clippy-test-run/sources/stable/gh/dfaust/cockroachdb-test/Cargo.toml [INFO] started frobbing dfaust/cockroachdb-test [INFO] finished frobbing dfaust/cockroachdb-test [INFO] frobbed toml for dfaust/cockroachdb-test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dfaust/cockroachdb-test/Cargo.toml [INFO] crate dfaust/cockroachdb-test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dfaust/cockroachdb-test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dfaust/cockroachdb-test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 163dd13387995ef5cd000a7c8d5503747ebb2a117e9dff77177d3ebf301117ed [INFO] running `"docker" "start" "-a" "163dd13387995ef5cd000a7c8d5503747ebb2a117e9dff77177d3ebf301117ed"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking socket2 v0.3.1 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking digest v0.7.2 [INFO] [stderr] Checking crypto-mac v0.5.2 [INFO] [stderr] Checking sha2 v0.7.0 [INFO] [stderr] Checking hmac v0.5.0 [INFO] [stderr] Checking postgres-protocol v0.3.2 [INFO] [stderr] Checking rayon v1.0.0 [INFO] [stderr] Checking postgres-shared v0.4.1 [INFO] [stderr] Checking postgres v0.15.2 [INFO] [stderr] Checking r2d2_postgres v0.14.0 [INFO] [stderr] Checking cockroachdb-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | const COCKROACHDB_URL: &'static str = "postgresql://testuser@localhost:26257/testdb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | const POSTGRESQL_URL: &'static str = "postgresql://postgres:testpw@localhost:5432/testdb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | let all_doc_ids = (0..num_docs).into_iter().map(|_| Uuid::rand(&mut rng1)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..num_docs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | let doc_ids = (0..batch_size) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 95 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `(0..batch_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | let user_ids = (0..user_count).into_iter().map(|_| Uuid::rand(&mut rng)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..user_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:175:83 [INFO] [stderr] | [INFO] [stderr] 175 | let duration = (now.elapsed().unwrap().as_secs() as f64) * 1_000_000_000f64 + now.elapsed().unwrap().subsec_nanos() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.elapsed().unwrap().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:35 [INFO] [stderr] | [INFO] [stderr] 177 | let transactions_per_second = user_count as f64 * iterations as f64 * 1_000_000_000f64 / duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(user_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:20:25 [INFO] [stderr] | [INFO] [stderr] 20 | const COCKROACHDB_URL: &'static str = "postgresql://testuser@localhost:26257/testdb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | const POSTGRESQL_URL: &'static str = "postgresql://postgres:testpw@localhost:5432/testdb"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:69:23 [INFO] [stderr] | [INFO] [stderr] 69 | let all_doc_ids = (0..num_docs).into_iter().map(|_| Uuid::rand(&mut rng1)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..num_docs)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:94:27 [INFO] [stderr] | [INFO] [stderr] 94 | let doc_ids = (0..batch_size) [INFO] [stderr] | ___________________________^ [INFO] [stderr] 95 | | .into_iter() [INFO] [stderr] | |____________________________^ help: consider removing `.into_iter()`: `(0..batch_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:145:20 [INFO] [stderr] | [INFO] [stderr] 145 | let user_ids = (0..user_count).into_iter().map(|_| Uuid::rand(&mut rng)).collect::>(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `(0..user_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:175:83 [INFO] [stderr] | [INFO] [stderr] 175 | let duration = (now.elapsed().unwrap().as_secs() as f64) * 1_000_000_000f64 + now.elapsed().unwrap().subsec_nanos() as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(now.elapsed().unwrap().subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:177:35 [INFO] [stderr] | [INFO] [stderr] 177 | let transactions_per_second = user_count as f64 * iterations as f64 * 1_000_000_000f64 / duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(user_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.01s [INFO] running `"docker" "inspect" "163dd13387995ef5cd000a7c8d5503747ebb2a117e9dff77177d3ebf301117ed"` [INFO] running `"docker" "rm" "-f" "163dd13387995ef5cd000a7c8d5503747ebb2a117e9dff77177d3ebf301117ed"` [INFO] [stdout] 163dd13387995ef5cd000a7c8d5503747ebb2a117e9dff77177d3ebf301117ed