[INFO] updating cached repository df5602/lightriders-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/df5602/lightriders-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/df5602/lightriders-bot" "work/ex/clippy-test-run/sources/stable/gh/df5602/lightriders-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/df5602/lightriders-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/df5602/lightriders-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/df5602/lightriders-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/df5602/lightriders-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] afd2273f628a8aeae71addfd9f2f9e63f6438132 [INFO] sha for GitHub repo df5602/lightriders-bot: afd2273f628a8aeae71addfd9f2f9e63f6438132 [INFO] validating manifest of df5602/lightriders-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of df5602/lightriders-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing df5602/lightriders-bot [INFO] finished frobbing df5602/lightriders-bot [INFO] frobbed toml for df5602/lightriders-bot written to work/ex/clippy-test-run/sources/stable/gh/df5602/lightriders-bot/Cargo.toml [INFO] started frobbing df5602/lightriders-bot [INFO] finished frobbing df5602/lightriders-bot [INFO] frobbed toml for df5602/lightriders-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/df5602/lightriders-bot/Cargo.toml [INFO] crate df5602/lightriders-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting df5602/lightriders-bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/df5602/lightriders-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a2204e158634148decd14592e8214658fc20dcf789469b17c2bad99018d456a [INFO] running `"docker" "start" "-a" "9a2204e158634148decd14592e8214658fc20dcf789469b17c2bad99018d456a"` [INFO] [stderr] Checking lightriders-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/reachable.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / let mut sx = x; [INFO] [stderr] 97 | | [INFO] [stderr] 98 | | // handle row starting later than previous row [INFO] [stderr] 99 | | if last_row_length != 0 && cells[y * width + x] != CellReachability::Empty { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let sx = if last_row_length != 0 && cells[y * width + x] != CellReachability::Empty { ..; x } else { ..; x };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/reachable.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / let mut sx = x; [INFO] [stderr] 97 | | [INFO] [stderr] 98 | | // handle row starting later than previous row [INFO] [stderr] 99 | | if last_row_length != 0 && cells[y * width + x] != CellReachability::Empty { [INFO] [stderr] ... | [INFO] [stderr] 124 | | } [INFO] [stderr] 125 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let sx = if last_row_length != 0 && cells[y * width + x] != CellReachability::Empty { ..; x } else { ..; x };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "9a2204e158634148decd14592e8214658fc20dcf789469b17c2bad99018d456a"` [INFO] running `"docker" "rm" "-f" "9a2204e158634148decd14592e8214658fc20dcf789469b17c2bad99018d456a"` [INFO] [stdout] 9a2204e158634148decd14592e8214658fc20dcf789469b17c2bad99018d456a