[INFO] updating cached repository dezmound/graph2vec [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dezmound/graph2vec [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dezmound/graph2vec" "work/ex/clippy-test-run/sources/stable/gh/dezmound/graph2vec"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dezmound/graph2vec'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dezmound/graph2vec" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dezmound/graph2vec"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dezmound/graph2vec'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ce7d4cf4793cf05698707dd6a5fcc156624dc9be [INFO] sha for GitHub repo dezmound/graph2vec: ce7d4cf4793cf05698707dd6a5fcc156624dc9be [INFO] validating manifest of dezmound/graph2vec on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dezmound/graph2vec on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dezmound/graph2vec [INFO] finished frobbing dezmound/graph2vec [INFO] frobbed toml for dezmound/graph2vec written to work/ex/clippy-test-run/sources/stable/gh/dezmound/graph2vec/Cargo.toml [INFO] started frobbing dezmound/graph2vec [INFO] finished frobbing dezmound/graph2vec [INFO] frobbed toml for dezmound/graph2vec written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dezmound/graph2vec/Cargo.toml [INFO] crate dezmound/graph2vec has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dezmound/graph2vec against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dezmound/graph2vec:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0c9be56024ce81e8dcedbcda316f4fd18bbf8f37ca04fdeeccc177699802c3ef [INFO] running `"docker" "start" "-a" "0c9be56024ce81e8dcedbcda316f4fd18bbf8f37ca04fdeeccc177699802c3ef"` [INFO] [stderr] Checking graph2vec v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/vectorize.rs:952:9 [INFO] [stderr] | [INFO] [stderr] 952 | return bow_vertex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bow_vertex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/vectorize.rs:980:9 [INFO] [stderr] | [INFO] [stderr] 980 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/vectorize.rs:1014:25 [INFO] [stderr] | [INFO] [stderr] 1014 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/mod.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/mod.rs:106:29 [INFO] [stderr] | [INFO] [stderr] 106 | return v.id == e.source.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.id == e.source.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `graph::vectorize::BoW` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use graph::vectorize::BoW; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/vectorize.rs:952:9 [INFO] [stderr] | [INFO] [stderr] 952 | return bow_vertex; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `bow_vertex` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/vectorize.rs:980:9 [INFO] [stderr] | [INFO] [stderr] 980 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/vectorize.rs:1014:25 [INFO] [stderr] | [INFO] [stderr] 1014 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/mod.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/graph/mod.rs:106:29 [INFO] [stderr] | [INFO] [stderr] 106 | return v.id == e.source.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `v.id == e.source.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `graph::vectorize::BoW` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use graph::vectorize::BoW; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graph/vectorize.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new(graph: Arc) -> BoW { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:486:40 [INFO] [stderr] | [INFO] [stderr] 486 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:486:55 [INFO] [stderr] | [INFO] [stderr] 486 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 486 | fn count_match_of_word_in_doc(doc: &String, word: &str) -> usize { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `word.clone()` to [INFO] [stderr] | [INFO] [stderr] 487 | let mut searched = word.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:959:40 [INFO] [stderr] | [INFO] [stderr] 959 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:959:55 [INFO] [stderr] | [INFO] [stderr] 959 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 959 | fn count_match_of_word_in_doc(doc: &String, word: &str) -> usize { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `word.clone()` to [INFO] [stderr] | [INFO] [stderr] 960 | let mut searched = word.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph/vectorize.rs:964:38 [INFO] [stderr] | [INFO] [stderr] 964 | fn vertex_to_vec(vocabulary_x32: &Vec, node: & Node) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph/vectorize.rs:971:29 [INFO] [stderr] | [INFO] [stderr] 971 | fn signature_compare(a: & Vec, b: & Vec, delta: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph/vectorize.rs:971:44 [INFO] [stderr] | [INFO] [stderr] 971 | fn signature_compare(a: & Vec, b: & Vec, delta: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:999:36 [INFO] [stderr] | [INFO] [stderr] 999 | let start_index = (thread_id as u16 * vertexes_for_tread_length as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(thread_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1003:56 [INFO] [stderr] | [INFO] [stderr] 1003 | vertexes_for_tread_length as u16 + (vertexes_for_tread_length as u8 % _threads_count) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(vertexes_for_tread_length as u8 % _threads_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/graph/vectorize.rs:1008:28 [INFO] [stderr] | [INFO] [stderr] 1008 | if let None = voc.iter().find(|v: && Vec| { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1008 | if voc.iter().find(|v: && Vec| { [INFO] [stderr] 1009 | for i in 0..v.len() { [INFO] [stderr] 1010 | if v[i] != vertex_signature[i] as u16 { [INFO] [stderr] 1011 | return false; [INFO] [stderr] 1012 | } [INFO] [stderr] 1013 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/graph/vectorize.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn new(graph: Arc) -> BoW { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1050:40 [INFO] [stderr] | [INFO] [stderr] 1050 | let start_index = (thread_id as u16 * words_for_thread_length as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(thread_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1054:58 [INFO] [stderr] | [INFO] [stderr] 1054 | words_for_thread_length as u16 + (vocabulary_length as u8 % _threads_count) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(vocabulary_length as u8 % _threads_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1089:40 [INFO] [stderr] | [INFO] [stderr] 1089 | let start_index = (thread_id as u16 * words_for_thread_length as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(thread_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1093:58 [INFO] [stderr] | [INFO] [stderr] 1093 | words_for_thread_length as u16 + (vocabulary_length as u8 % _threads_count) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(vocabulary_length as u8 % _threads_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/mod.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from_json(json: & String) -> Graph { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/graph/mod.rs:50:70 [INFO] [stderr] | [INFO] [stderr] 50 | let source = nodes.iter().find(|&v| v.id == val.get("source").unwrap().to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val.get("source").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/graph/mod.rs:51:70 [INFO] [stderr] | [INFO] [stderr] 51 | let target = nodes.iter().find(|&v| v.id == val.get("target").unwrap().to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val.get("target").unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/graph/mod.rs:102:32 [INFO] [stderr] | [INFO] [stderr] 102 | if let None = self.graph.visit_stack.iter().find(|&v| { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if self.graph.visit_stack.iter().find(|&v| { [INFO] [stderr] 103 | if e.target.id != current_node.id { [INFO] [stderr] 104 | return v.id == e.target.id; [INFO] [stderr] 105 | } [INFO] [stderr] 106 | return v.id == e.source.id; [INFO] [stderr] 107 | }).is_none() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:486:40 [INFO] [stderr] | [INFO] [stderr] 486 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:486:55 [INFO] [stderr] | [INFO] [stderr] 486 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 486 | fn count_match_of_word_in_doc(doc: &String, word: &str) -> usize { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `word.clone()` to [INFO] [stderr] | [INFO] [stderr] 487 | let mut searched = word.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:959:40 [INFO] [stderr] | [INFO] [stderr] 959 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/vectorize.rs:959:55 [INFO] [stderr] | [INFO] [stderr] 959 | fn count_match_of_word_in_doc(doc: &String, word: &String) -> usize { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 959 | fn count_match_of_word_in_doc(doc: &String, word: &str) -> usize { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `word.clone()` to [INFO] [stderr] | [INFO] [stderr] 960 | let mut searched = word.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph/vectorize.rs:964:38 [INFO] [stderr] | [INFO] [stderr] 964 | fn vertex_to_vec(vocabulary_x32: &Vec, node: & Node) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph/vectorize.rs:971:29 [INFO] [stderr] | [INFO] [stderr] 971 | fn signature_compare(a: & Vec, b: & Vec, delta: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph/vectorize.rs:971:44 [INFO] [stderr] | [INFO] [stderr] 971 | fn signature_compare(a: & Vec, b: & Vec, delta: u16) -> bool { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[u16]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:999:36 [INFO] [stderr] | [INFO] [stderr] 999 | let start_index = (thread_id as u16 * vertexes_for_tread_length as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(thread_id)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1003:56 [INFO] [stderr] | [INFO] [stderr] 1003 | vertexes_for_tread_length as u16 + (vertexes_for_tread_length as u8 % _threads_count) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(vertexes_for_tread_length as u8 % _threads_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/graph/vectorize.rs:1008:28 [INFO] [stderr] | [INFO] [stderr] 1008 | if let None = voc.iter().find(|v: && Vec| { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1008 | if voc.iter().find(|v: && Vec| { [INFO] [stderr] 1009 | for i in 0..v.len() { [INFO] [stderr] 1010 | if v[i] != vertex_signature[i] as u16 { [INFO] [stderr] 1011 | return false; [INFO] [stderr] 1012 | } [INFO] [stderr] 1013 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1050:40 [INFO] [stderr] | [INFO] [stderr] 1050 | let start_index = (thread_id as u16 * words_for_thread_length as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(thread_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1054:58 [INFO] [stderr] | [INFO] [stderr] 1054 | words_for_thread_length as u16 + (vocabulary_length as u8 % _threads_count) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(vocabulary_length as u8 % _threads_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1089:40 [INFO] [stderr] | [INFO] [stderr] 1089 | let start_index = (thread_id as u16 * words_for_thread_length as u16) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(thread_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/graph/vectorize.rs:1093:58 [INFO] [stderr] | [INFO] [stderr] 1093 | words_for_thread_length as u16 + (vocabulary_length as u8 % _threads_count) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(vocabulary_length as u8 % _threads_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/graph/mod.rs:35:28 [INFO] [stderr] | [INFO] [stderr] 35 | pub fn from_json(json: & String) -> Graph { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/graph/mod.rs:50:70 [INFO] [stderr] | [INFO] [stderr] 50 | let source = nodes.iter().find(|&v| v.id == val.get("source").unwrap().to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val.get("source").unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/graph/mod.rs:51:70 [INFO] [stderr] | [INFO] [stderr] 51 | let target = nodes.iter().find(|&v| v.id == val.get("target").unwrap().to_string()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `val.get("target").unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_none()` [INFO] [stderr] --> src/graph/mod.rs:102:32 [INFO] [stderr] | [INFO] [stderr] 102 | if let None = self.graph.visit_stack.iter().find(|&v| { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if self.graph.visit_stack.iter().find(|&v| { [INFO] [stderr] 103 | if e.target.id != current_node.id { [INFO] [stderr] 104 | return v.id == e.target.id; [INFO] [stderr] 105 | } [INFO] [stderr] 106 | return v.id == e.source.id; [INFO] [stderr] 107 | }).is_none() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.09s [INFO] running `"docker" "inspect" "0c9be56024ce81e8dcedbcda316f4fd18bbf8f37ca04fdeeccc177699802c3ef"` [INFO] running `"docker" "rm" "-f" "0c9be56024ce81e8dcedbcda316f4fd18bbf8f37ca04fdeeccc177699802c3ef"` [INFO] [stdout] 0c9be56024ce81e8dcedbcda316f4fd18bbf8f37ca04fdeeccc177699802c3ef