[INFO] updating cached repository dezgeg/nix-rebuild-stats [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dezgeg/nix-rebuild-stats [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dezgeg/nix-rebuild-stats" "work/ex/clippy-test-run/sources/stable/gh/dezgeg/nix-rebuild-stats"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dezgeg/nix-rebuild-stats'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dezgeg/nix-rebuild-stats" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dezgeg/nix-rebuild-stats"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dezgeg/nix-rebuild-stats'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 909b97402dad8ecc95d96dc685e4024476819496 [INFO] sha for GitHub repo dezgeg/nix-rebuild-stats: 909b97402dad8ecc95d96dc685e4024476819496 [INFO] validating manifest of dezgeg/nix-rebuild-stats on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dezgeg/nix-rebuild-stats on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dezgeg/nix-rebuild-stats [INFO] finished frobbing dezgeg/nix-rebuild-stats [INFO] frobbed toml for dezgeg/nix-rebuild-stats written to work/ex/clippy-test-run/sources/stable/gh/dezgeg/nix-rebuild-stats/Cargo.toml [INFO] started frobbing dezgeg/nix-rebuild-stats [INFO] finished frobbing dezgeg/nix-rebuild-stats [INFO] frobbed toml for dezgeg/nix-rebuild-stats written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dezgeg/nix-rebuild-stats/Cargo.toml [INFO] crate dezgeg/nix-rebuild-stats has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dezgeg/nix-rebuild-stats against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dezgeg/nix-rebuild-stats:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30c2c181bdd0b3843e922b8eba7b4a637ac191390bdcf6e14145d3005e6072a5 [INFO] running `"docker" "start" "-a" "30c2c181bdd0b3843e922b8eba7b4a637ac191390bdcf6e14145d3005e6072a5"` [INFO] [stderr] Checking from-ascii v0.0.1 [INFO] [stderr] Checking encoding_rs v0.5.0 [INFO] [stderr] Checking backtrace v0.3.0 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking quick-xml v0.6.2 [INFO] [stderr] Checking nix-rebuild-stats v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `drv_paths` [INFO] [stderr] --> src/main.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | fn build_dep_tree(drv_paths: Vec) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_drv_paths` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `drv_paths` [INFO] [stderr] --> src/main.rs:40:19 [INFO] [stderr] | [INFO] [stderr] 40 | fn build_dep_tree(drv_paths: Vec) -> HashMap> { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_drv_paths` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:62:52 [INFO] [stderr] | [INFO] [stderr] 62 | res.entry(drv).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | res.entry(src).or_insert(Vec::new()).push(dst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:99:136 [INFO] [stderr] | [INFO] [stderr] 99 | fn calculate_revdep_closure(revdep_map: &HashMap>, revdep_closure_map: &mut HashMap>, drv: &String) -> HashSet { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / match revdep_closure_map.get(drv) { [INFO] [stderr] 102 | | Some(x) => return x.clone(), [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(x) = revdep_closure_map.get(drv) { return x.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:120:38 [INFO] [stderr] | [INFO] [stderr] 120 | let revdep_tree = build_dep_tree(attr_map.values().map(|x| x.clone()).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `attr_map.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:62:52 [INFO] [stderr] | [INFO] [stderr] 62 | res.entry(drv).or_insert(Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | res.entry(src).or_insert(Vec::new()).push(dst); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:99:136 [INFO] [stderr] | [INFO] [stderr] 99 | fn calculate_revdep_closure(revdep_map: &HashMap>, revdep_closure_map: &mut HashMap>, drv: &String) -> HashSet { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | / match revdep_closure_map.get(drv) { [INFO] [stderr] 102 | | Some(x) => return x.clone(), [INFO] [stderr] 103 | | _ => (), [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____^ help: try this: `if let Some(x) = revdep_closure_map.get(drv) { return x.clone() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:120:38 [INFO] [stderr] | [INFO] [stderr] 120 | let revdep_tree = build_dep_tree(attr_map.values().map(|x| x.clone()).collect()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `attr_map.values().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.13s [INFO] running `"docker" "inspect" "30c2c181bdd0b3843e922b8eba7b4a637ac191390bdcf6e14145d3005e6072a5"` [INFO] running `"docker" "rm" "-f" "30c2c181bdd0b3843e922b8eba7b4a637ac191390bdcf6e14145d3005e6072a5"` [INFO] [stdout] 30c2c181bdd0b3843e922b8eba7b4a637ac191390bdcf6e14145d3005e6072a5