[INFO] updating cached repository devashishdxt/todo-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/devashishdxt/todo-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/devashishdxt/todo-rs" "work/ex/clippy-test-run/sources/stable/gh/devashishdxt/todo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/devashishdxt/todo-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/devashishdxt/todo-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devashishdxt/todo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devashishdxt/todo-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b29660fba203db82440742a21aa19952d6927f34 [INFO] sha for GitHub repo devashishdxt/todo-rs: b29660fba203db82440742a21aa19952d6927f34 [INFO] validating manifest of devashishdxt/todo-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of devashishdxt/todo-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing devashishdxt/todo-rs [INFO] finished frobbing devashishdxt/todo-rs [INFO] frobbed toml for devashishdxt/todo-rs written to work/ex/clippy-test-run/sources/stable/gh/devashishdxt/todo-rs/Cargo.toml [INFO] started frobbing devashishdxt/todo-rs [INFO] finished frobbing devashishdxt/todo-rs [INFO] frobbed toml for devashishdxt/todo-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/devashishdxt/todo-rs/Cargo.toml [INFO] crate devashishdxt/todo-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting devashishdxt/todo-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/devashishdxt/todo-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34ec6d5796bc1506947e7af3a7df9cbaaa0d279c1d7164f8f7acf0b9da2443b1 [INFO] running `"docker" "start" "-a" "34ec6d5796bc1506947e7af3a7df9cbaaa0d279c1d7164f8f7acf0b9da2443b1"` [INFO] [stderr] Checking encode_unicode v0.3.2 [INFO] [stderr] Compiling memchr v2.1.0 [INFO] [stderr] Compiling structopt-derive v0.2.11 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Checking structopt v0.2.11 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking todo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/service.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | if todos.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!todos.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/service.rs:159:8 [INFO] [stderr] | [INFO] [stderr] 159 | if todos.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!todos.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.22s [INFO] running `"docker" "inspect" "34ec6d5796bc1506947e7af3a7df9cbaaa0d279c1d7164f8f7acf0b9da2443b1"` [INFO] running `"docker" "rm" "-f" "34ec6d5796bc1506947e7af3a7df9cbaaa0d279c1d7164f8f7acf0b9da2443b1"` [INFO] [stdout] 34ec6d5796bc1506947e7af3a7df9cbaaa0d279c1d7164f8f7acf0b9da2443b1