[INFO] updating cached repository deuszex/torrentjson-cli
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/deuszex/torrentjson-cli
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/deuszex/torrentjson-cli" "work/ex/clippy-test-run/sources/stable/gh/deuszex/torrentjson-cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deuszex/torrentjson-cli'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/deuszex/torrentjson-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deuszex/torrentjson-cli"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deuszex/torrentjson-cli'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] bc1b90892560ed8b600f1c2fb297a576462953f1
[INFO] sha for GitHub repo deuszex/torrentjson-cli: bc1b90892560ed8b600f1c2fb297a576462953f1
[INFO] validating manifest of deuszex/torrentjson-cli on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of deuszex/torrentjson-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing deuszex/torrentjson-cli
[INFO] finished frobbing deuszex/torrentjson-cli
[INFO] frobbed toml for deuszex/torrentjson-cli written to work/ex/clippy-test-run/sources/stable/gh/deuszex/torrentjson-cli/Cargo.toml
[INFO] started frobbing deuszex/torrentjson-cli
[INFO] finished frobbing deuszex/torrentjson-cli
[INFO] frobbed toml for deuszex/torrentjson-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deuszex/torrentjson-cli/Cargo.toml
[INFO] crate deuszex/torrentjson-cli has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting deuszex/torrentjson-cli against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deuszex/torrentjson-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 39c304a575bd7b05c369949f6df1f48aba762d9dd9bc4f0361bfbb4d7567e3ec
[INFO] running `"docker" "start" "-a" "39c304a575bd7b05c369949f6df1f48aba762d9dd9bc4f0361bfbb4d7567e3ec"`
[INFO] [stderr]     Checking hostname v0.1.3
[INFO] [stderr]     Checking serde_bytes v0.10.2
[INFO] [stderr]     Checking serde_json v1.0.6
[INFO] [stderr]     Checking base64 v0.7.0
[INFO] [stderr]     Checking rust-crypto v0.2.36
[INFO] [stderr]     Checking bip_bencode v0.4.2
[INFO] [stderr]     Checking serde_bencode v0.2.0
[INFO] [stderr]     Checking bson v0.10.0
[INFO] [stderr]     Checking torrentjson-cli v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `self`
[INFO] [stderr]   --> src/main.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 | use std::io::{self, Read};
[INFO] [stderr]    |               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `self`
[INFO] [stderr]   --> src/main.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 | use std::io::{self, Read};
[INFO] [stderr]    |               ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `while` condition
[INFO] [stderr]    --> src/main.rs:136:10
[INFO] [stderr]     |
[INFO] [stderr] 136 |     while(i < bf.len()){
[INFO] [stderr]     |          ^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/main.rs:156:8
[INFO] [stderr]     |
[INFO] [stderr] 156 |     if (&pieces_bytes%20!=0){return Err(TorrentError::InvalidPiecesLength)};
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `while` condition
[INFO] [stderr]    --> src/main.rs:136:10
[INFO] [stderr]     |
[INFO] [stderr] 136 |     while(i < bf.len()){
[INFO] [stderr]     |          ^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around `if` condition
[INFO] [stderr]    --> src/main.rs:156:8
[INFO] [stderr]     |
[INFO] [stderr] 156 |     if (&pieces_bytes%20!=0){return Err(TorrentError::InvalidPiecesLength)};
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: variable `start` is assigned to, but never used
[INFO] [stderr]    --> src/main.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |     let mut start : i64 = 0;
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr]     = note: consider using `_start` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `actual_byte` is never read
[INFO] [stderr]    --> src/main.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 |     let mut actual_byte = 0;
[INFO] [stderr]     |             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `start` is never read
[INFO] [stderr]    --> src/main.rs:169:17
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 start = piece_index;
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/main.rs:285:16
[INFO] [stderr]     |
[INFO] [stderr] 285 |     if let Err(e) = file{println!("{:?}", "           File not found");std::process::exit(666)}
[INFO] [stderr]     |                ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:284:9
[INFO] [stderr]     |
[INFO] [stderr] 284 |     let mut file = F::open(&input);
[INFO] [stderr]     |         ----^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `render_torrent`
[INFO] [stderr]    --> src/main.rs:254:1
[INFO] [stderr]     |
[INFO] [stderr] 254 | fn render_torrent(torrent: &Torrent) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable `start` is assigned to, but never used
[INFO] [stderr]    --> src/main.rs:149:13
[INFO] [stderr]     |
[INFO] [stderr] 149 |     let mut start : i64 = 0;
[INFO] [stderr]     |             ^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr]     = note: consider using `_start` instead
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `actual_byte` is never read
[INFO] [stderr]    --> src/main.rs:151:13
[INFO] [stderr]     |
[INFO] [stderr] 151 |     let mut actual_byte = 0;
[INFO] [stderr]     |             ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_assignments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: value assigned to `start` is never read
[INFO] [stderr]    --> src/main.rs:169:17
[INFO] [stderr]     |
[INFO] [stderr] 169 |                 start = piece_index;
[INFO] [stderr]     |                 ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e`
[INFO] [stderr]    --> src/main.rs:285:16
[INFO] [stderr]     |
[INFO] [stderr] 285 |     if let Err(e) = file{println!("{:?}", "           File not found");std::process::exit(666)}
[INFO] [stderr]     |                ^ help: consider using `_e` instead
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 | /     loop {
[INFO] [stderr] 162 | |         match iter.next() {
[INFO] [stderr] 163 | |             Some(file) => {
[INFO] [stderr] 164 | |                 let startp = PiecePoint{piece: piece_index+1, byte_point: (start_byte%piece_length)+1};
[INFO] [stderr] ...   |
[INFO] [stderr] 185 | |         }
[INFO] [stderr] 186 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(file) = iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:258:5
[INFO] [stderr]     |
[INFO] [stderr] 258 | /     if let &Some(ref al) = &torrent.announce_list {
[INFO] [stderr] 259 | |         for a in al {
[INFO] [stderr] 260 | |             println!("announce list:\t{}", a[0]);
[INFO] [stderr] 261 | |         }
[INFO] [stderr] 262 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 258 |     if let Some(ref al) = torrent.announce_list {
[INFO] [stderr]     |            ^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:273:5
[INFO] [stderr]     |
[INFO] [stderr] 273 | /     if let &Some(ref files) = &torrent.info.files {
[INFO] [stderr] 274 | |         for f in files {
[INFO] [stderr] 275 | |             println!("file path:\t{:?}", f.path);
[INFO] [stderr] 276 | |             println!("file length:\t{}", f.length);
[INFO] [stderr] 277 | |             println!("file md5sum:\t{:?}", f.md5sum);
[INFO] [stderr] 278 | |         }
[INFO] [stderr] 279 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 273 |     if let Some(ref files) = torrent.info.files {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:289:5
[INFO] [stderr]     |
[INFO] [stderr] 289 |     readable.read_to_end(&mut contents);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:284:9
[INFO] [stderr]     |
[INFO] [stderr] 284 |     let mut file = F::open(&input);
[INFO] [stderr]     |         ----^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `render_torrent`
[INFO] [stderr]    --> src/main.rs:254:1
[INFO] [stderr]     |
[INFO] [stderr] 254 | fn render_torrent(torrent: &Torrent) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/main.rs:161:5
[INFO] [stderr]     |
[INFO] [stderr] 161 | /     loop {
[INFO] [stderr] 162 | |         match iter.next() {
[INFO] [stderr] 163 | |             Some(file) => {
[INFO] [stderr] 164 | |                 let startp = PiecePoint{piece: piece_index+1, byte_point: (start_byte%piece_length)+1};
[INFO] [stderr] ...   |
[INFO] [stderr] 185 | |         }
[INFO] [stderr] 186 | |     }
[INFO] [stderr]     | |_____^ help: try: `while let Some(file) = iter.next() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:258:5
[INFO] [stderr]     |
[INFO] [stderr] 258 | /     if let &Some(ref al) = &torrent.announce_list {
[INFO] [stderr] 259 | |         for a in al {
[INFO] [stderr] 260 | |             println!("announce list:\t{}", a[0]);
[INFO] [stderr] 261 | |         }
[INFO] [stderr] 262 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 258 |     if let Some(ref al) = torrent.announce_list {
[INFO] [stderr]     |            ^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns
[INFO] [stderr]    --> src/main.rs:273:5
[INFO] [stderr]     |
[INFO] [stderr] 273 | /     if let &Some(ref files) = &torrent.info.files {
[INFO] [stderr] 274 | |         for f in files {
[INFO] [stderr] 275 | |             println!("file path:\t{:?}", f.path);
[INFO] [stderr] 276 | |             println!("file length:\t{}", f.length);
[INFO] [stderr] 277 | |             println!("file md5sum:\t{:?}", f.md5sum);
[INFO] [stderr] 278 | |         }
[INFO] [stderr] 279 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 273 |     if let Some(ref files) = torrent.info.files {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^   ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:289:5
[INFO] [stderr]     |
[INFO] [stderr] 289 |     readable.read_to_end(&mut contents);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 15.21s
[INFO] running `"docker" "inspect" "39c304a575bd7b05c369949f6df1f48aba762d9dd9bc4f0361bfbb4d7567e3ec"`
[INFO] running `"docker" "rm" "-f" "39c304a575bd7b05c369949f6df1f48aba762d9dd9bc4f0361bfbb4d7567e3ec"`
[INFO] [stdout] 39c304a575bd7b05c369949f6df1f48aba762d9dd9bc4f0361bfbb4d7567e3ec