[INFO] updating cached repository detro/mooncell [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/detro/mooncell [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/detro/mooncell" "work/ex/clippy-test-run/sources/stable/gh/detro/mooncell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/detro/mooncell'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/detro/mooncell" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/detro/mooncell"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/detro/mooncell'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c535af868023ef39d55c1b1e544b489971c62f44 [INFO] sha for GitHub repo detro/mooncell: c535af868023ef39d55c1b1e544b489971c62f44 [INFO] validating manifest of detro/mooncell on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of detro/mooncell on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing detro/mooncell [INFO] finished frobbing detro/mooncell [INFO] frobbed toml for detro/mooncell written to work/ex/clippy-test-run/sources/stable/gh/detro/mooncell/Cargo.toml [INFO] started frobbing detro/mooncell [INFO] finished frobbing detro/mooncell [INFO] frobbed toml for detro/mooncell written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/detro/mooncell/Cargo.toml [INFO] crate detro/mooncell has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting detro/mooncell against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/detro/mooncell:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fe4bc22a56fd569b347407600715ac6f62ee4cf1eac9e31d992f492c81fe90bb [INFO] running `"docker" "start" "-a" "fe4bc22a56fd569b347407600715ac6f62ee4cf1eac9e31d992f492c81fe90bb"` [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking serde_yaml v0.8.7 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking serde-value v0.5.3 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking log4rs v0.8.1 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking trust-dns-proto v0.5.0 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.17 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking mooncell v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const ARG_IPV4: &'static str = "ipv4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const ARG_IPV4_SHORT: &'static str = "4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | const ARG_IPV6: &'static str = "ipv6"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const ARG_IPV6_SHORT: &'static str = "6"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const ARG_PORT: &'static str = "port"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | const ARG_PORT_SHORT: &'static str = "p"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | const ARG_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | const ARG_VERBOSE_SHORT: &'static str = "v"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | const ARG_QUIET: &'static str = "quiet"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const ARG_QUIET_SHORT: &'static str = "q"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/defaults.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | pub const IPV4_DEFAULT: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/defaults.rs:8:26 [INFO] [stderr] | [INFO] [stderr] 8 | pub const IPV6_DEFAULT: &'static str = "::1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/defaults.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PORT_DEFAULT: &'static str = "53"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `bind_tcp_listeners` [INFO] [stderr] --> src/net/server.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | use net::{utils::{bind_udp_sockets, bind_tcp_listeners}, request_responder::DnsRequestResponder}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `dns_proto::DnsMessage` [INFO] [stderr] --> src/core/processor.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use dns_proto::DnsMessage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `doh::protocol::DoHResponse` [INFO] [stderr] --> src/core/processor.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use doh::protocol::DoHResponse; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:8:18 [INFO] [stderr] | [INFO] [stderr] 8 | const ARG_IPV4: &'static str = "ipv4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const ARG_IPV4_SHORT: &'static str = "4"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:10:18 [INFO] [stderr] | [INFO] [stderr] 10 | const ARG_IPV6: &'static str = "ipv6"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:11:24 [INFO] [stderr] | [INFO] [stderr] 11 | const ARG_IPV6_SHORT: &'static str = "6"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:12:18 [INFO] [stderr] | [INFO] [stderr] 12 | const ARG_PORT: &'static str = "port"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:13:24 [INFO] [stderr] | [INFO] [stderr] 13 | const ARG_PORT_SHORT: &'static str = "p"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:14:21 [INFO] [stderr] | [INFO] [stderr] 14 | const ARG_VERBOSE: &'static str = "verbose"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:15:27 [INFO] [stderr] | [INFO] [stderr] 15 | const ARG_VERBOSE_SHORT: &'static str = "v"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:16:19 [INFO] [stderr] | [INFO] [stderr] 16 | const ARG_QUIET: &'static str = "quiet"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/cli.rs:17:25 [INFO] [stderr] | [INFO] [stderr] 17 | const ARG_QUIET_SHORT: &'static str = "q"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/defaults.rs:7:26 [INFO] [stderr] | [INFO] [stderr] 7 | pub const IPV4_DEFAULT: &'static str = "127.0.0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/defaults.rs:8:26 [INFO] [stderr] | [INFO] [stderr] 8 | pub const IPV6_DEFAULT: &'static str = "::1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config/defaults.rs:9:26 [INFO] [stderr] | [INFO] [stderr] 9 | pub const PORT_DEFAULT: &'static str = "53"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `bind_tcp_listeners` [INFO] [stderr] --> src/net/server.rs:4:37 [INFO] [stderr] | [INFO] [stderr] 4 | use net::{utils::{bind_udp_sockets, bind_tcp_listeners}, request_responder::DnsRequestResponder}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `dns_proto::DnsMessage` [INFO] [stderr] --> src/core/processor.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use dns_proto::DnsMessage; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `doh::protocol::DoHResponse` [INFO] [stderr] --> src/core/processor.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use doh::protocol::DoHResponse; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `response` [INFO] [stderr] --> src/net/request_responder.rs:74:25 [INFO] [stderr] | [INFO] [stderr] 74 | pub fn respond(&self, response: &DoHResponse) { [INFO] [stderr] | ^^^^^^^^ help: consider using `_response` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `receiver` [INFO] [stderr] --> src/core/processor.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | receiver: Receiver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `config::cli::CLI<'a>` [INFO] [stderr] --> src/config/cli.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> CLI<'a> { [INFO] [stderr] 32 | | let matches = App::new(crate_name!()) [INFO] [stderr] 33 | | .version(crate_version!()) [INFO] [stderr] 34 | | .about(crate_description!()) [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/net/utils.rs:12:41 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn bind_udp_sockets(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Ipv4Addr]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/net/utils.rs:12:73 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn bind_udp_sockets(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Ipv6Addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/net/utils.rs:12:95 [INFO] [stderr] | [INFO] [stderr] 12 | pub fn bind_udp_sockets(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/net/utils.rs:16:34 [INFO] [stderr] | [INFO] [stderr] 16 | UdpSocket::bind(sock_addr).expect(&format!("Could not bind to UDP: {}", sock_addr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not bind to UDP: {}", sock_addr))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/net/utils.rs:25:43 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn bind_tcp_listeners(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Ipv4Addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/net/utils.rs:25:75 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn bind_tcp_listeners(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Ipv6Addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/net/utils.rs:25:97 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn bind_tcp_listeners(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/net/utils.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | TcpListener::bind(sock_addr).expect(&format!("Could not bind to TCP: {}", sock_addr)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Could not bind to TCP: {}", sock_addr))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/net/utils.rs:40:48 [INFO] [stderr] | [INFO] [stderr] 40 | fn map_ips_to_socket_addresses(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Ipv4Addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/net/utils.rs:40:80 [INFO] [stderr] | [INFO] [stderr] 40 | fn map_ips_to_socket_addresses(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Ipv6Addr]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/net/utils.rs:40:102 [INFO] [stderr] | [INFO] [stderr] 40 | fn map_ips_to_socket_addresses(ipv4_addresses: &Vec, ipv6_addresses: &Vec, port: &u16) -> Vec { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/net/utils.rs:42:6 [INFO] [stderr] | [INFO] [stderr] 42 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/utils.rs:43:25 [INFO] [stderr] | [INFO] [stderr] 43 | .map(|x| IpAddr::V4(x.clone())) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/net/utils.rs:45:8 [INFO] [stderr] | [INFO] [stderr] 45 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/utils.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | .map(|x| IpAddr::V6(x.clone()))) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/net/utils.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | .flat_map(|addr| (addr, port.clone()).to_socket_addrs().unwrap()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error[E0369]: binary operation `==` cannot be applied to type `&hyper::Body` [INFO] [stderr] --> src/doh/protocol.rs:237:5 [INFO] [stderr] | [INFO] [stderr] 237 | assert_eq!(request.body(), &()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: an implementation of `std::cmp::PartialEq` might be missing for `&hyper::Body` [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error[E0369]: binary operation `==` cannot be applied to type `&hyper::Body` [INFO] [stderr] --> src/doh/protocol.rs:244:5 [INFO] [stderr] | [INFO] [stderr] 244 | assert_eq!(request.body(), &()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: an implementation of `std::cmp::PartialEq` might be missing for `&hyper::Body` [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0369`. [INFO] [stderr] error: Could not compile `mooncell`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "fe4bc22a56fd569b347407600715ac6f62ee4cf1eac9e31d992f492c81fe90bb"` [INFO] running `"docker" "rm" "-f" "fe4bc22a56fd569b347407600715ac6f62ee4cf1eac9e31d992f492c81fe90bb"` [INFO] [stdout] fe4bc22a56fd569b347407600715ac6f62ee4cf1eac9e31d992f492c81fe90bb