[INFO] updating cached repository dergroncki/parse_ft_gfx_xml [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dergroncki/parse_ft_gfx_xml [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dergroncki/parse_ft_gfx_xml" "work/ex/clippy-test-run/sources/stable/gh/dergroncki/parse_ft_gfx_xml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dergroncki/parse_ft_gfx_xml'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dergroncki/parse_ft_gfx_xml" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dergroncki/parse_ft_gfx_xml"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dergroncki/parse_ft_gfx_xml'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6ba6466b2bdecee6caf2812d5825e7f0c174c0f4 [INFO] sha for GitHub repo dergroncki/parse_ft_gfx_xml: 6ba6466b2bdecee6caf2812d5825e7f0c174c0f4 [INFO] validating manifest of dergroncki/parse_ft_gfx_xml on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dergroncki/parse_ft_gfx_xml on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dergroncki/parse_ft_gfx_xml [INFO] finished frobbing dergroncki/parse_ft_gfx_xml [INFO] frobbed toml for dergroncki/parse_ft_gfx_xml written to work/ex/clippy-test-run/sources/stable/gh/dergroncki/parse_ft_gfx_xml/Cargo.toml [INFO] started frobbing dergroncki/parse_ft_gfx_xml [INFO] finished frobbing dergroncki/parse_ft_gfx_xml [INFO] frobbed toml for dergroncki/parse_ft_gfx_xml written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dergroncki/parse_ft_gfx_xml/Cargo.toml [INFO] crate dergroncki/parse_ft_gfx_xml has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dergroncki/parse_ft_gfx_xml against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dergroncki/parse_ft_gfx_xml:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 895202f62d01efc77b0d62902c7112096a839ebdb2aae142ecca610f80223790 [INFO] running `"docker" "start" "-a" "895202f62d01efc77b0d62902c7112096a839ebdb2aae142ecca610f80223790"` [INFO] [stderr] Checking term_size v0.3.0 [INFO] [stderr] Checking atty v0.2.2 [INFO] [stderr] Checking encoding_rs v0.6.11 [INFO] [stderr] Checking backtrace-sys v0.1.11 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking quick-xml v0.8.0 [INFO] [stderr] Checking parse_gfx_xml v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | write!(output, "{}\r\n", name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/main.rs:216:13 [INFO] [stderr] | [INFO] [stderr] 216 | write!(output, "{}\r\n", name).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:97:33 [INFO] [stderr] | [INFO] [stderr] 97 | / if my_key == "isReferenceObject" { [INFO] [stderr] 98 | | if my_value == "true" { [INFO] [stderr] 99 | | [INFO] [stderr] 100 | | main_group = true; [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | if my_key == "isReferenceObject" && my_value == "true" { [INFO] [stderr] 98 | [INFO] [stderr] 99 | main_group = true; [INFO] [stderr] 100 | //println!("The group is reference object!"); [INFO] [stderr] 101 | let mut names:Vec = Vec::new(); //save all tags found during search here [INFO] [stderr] 102 | let mut buf_group = Vec::new(); //buffer of group reader [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let file_name_in = format!("{}", entry); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `entry.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | / match e.name() { [INFO] [stderr] 89 | | b"group" => { [INFO] [stderr] 90 | | for attrib in e.attributes() { [INFO] [stderr] 91 | | [INFO] [stderr] ... | [INFO] [stderr] 169 | | _ => (), //Nothing else to do [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let b"group" = e.name() { [INFO] [stderr] 89 | for attrib in e.attributes() { [INFO] [stderr] 90 | [INFO] [stderr] 91 | let my_attrib:quick_xml::events::attributes::Attribute = attrib.unwrap(); [INFO] [stderr] 92 | [INFO] [stderr] 93 | let my_key = str::from_utf8(my_attrib.key).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:121:117 [INFO] [stderr] | [INFO] [stderr] 121 | if str::from_utf8(my_result[2].value).unwrap().contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:132:57 [INFO] [stderr] | [INFO] [stderr] 132 | / match e.name() { [INFO] [stderr] 133 | | b"group" => { [INFO] [stderr] 134 | | if main_group == false { [INFO] [stderr] 135 | | //println!("End of group reached!"); [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => (), [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let b"group" = e.name() { [INFO] [stderr] 133 | if main_group == false { [INFO] [stderr] 134 | //println!("End of group reached!"); [INFO] [stderr] 135 | break; [INFO] [stderr] 136 | } [INFO] [stderr] 137 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:134:68 [INFO] [stderr] | [INFO] [stderr] 134 | if main_group == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!main_group` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:160:44 [INFO] [stderr] | [INFO] [stderr] 160 | if parameters.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parameters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:180:49 [INFO] [stderr] | [INFO] [stderr] 180 | if my_name.contains("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:185:53 [INFO] [stderr] | [INFO] [stderr] 185 | if my_name.contains("{") & my_name.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:185:77 [INFO] [stderr] | [INFO] [stderr] 185 | if my_name.contains("{") & my_name.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:97:33 [INFO] [stderr] | [INFO] [stderr] 97 | / if my_key == "isReferenceObject" { [INFO] [stderr] 98 | | if my_value == "true" { [INFO] [stderr] 99 | | [INFO] [stderr] 100 | | main_group = true; [INFO] [stderr] ... | [INFO] [stderr] 165 | | } [INFO] [stderr] 166 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 97 | if my_key == "isReferenceObject" && my_value == "true" { [INFO] [stderr] 98 | [INFO] [stderr] 99 | main_group = true; [INFO] [stderr] 100 | //println!("The group is reference object!"); [INFO] [stderr] 101 | let mut names:Vec = Vec::new(); //save all tags found during search here [INFO] [stderr] 102 | let mut buf_group = Vec::new(); //buffer of group reader [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let file_name_in = format!("{}", entry); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `entry.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | / match e.name() { [INFO] [stderr] 89 | | b"group" => { [INFO] [stderr] 90 | | for attrib in e.attributes() { [INFO] [stderr] 91 | | [INFO] [stderr] ... | [INFO] [stderr] 169 | | _ => (), //Nothing else to do [INFO] [stderr] 170 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | if let b"group" = e.name() { [INFO] [stderr] 89 | for attrib in e.attributes() { [INFO] [stderr] 90 | [INFO] [stderr] 91 | let my_attrib:quick_xml::events::attributes::Attribute = attrib.unwrap(); [INFO] [stderr] 92 | [INFO] [stderr] 93 | let my_key = str::from_utf8(my_attrib.key).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:121:117 [INFO] [stderr] | [INFO] [stderr] 121 | if str::from_utf8(my_result[2].value).unwrap().contains("{") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:132:57 [INFO] [stderr] | [INFO] [stderr] 132 | / match e.name() { [INFO] [stderr] 133 | | b"group" => { [INFO] [stderr] 134 | | if main_group == false { [INFO] [stderr] 135 | | //println!("End of group reached!"); [INFO] [stderr] ... | [INFO] [stderr] 139 | | _ => (), [INFO] [stderr] 140 | | } [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 132 | if let b"group" = e.name() { [INFO] [stderr] 133 | if main_group == false { [INFO] [stderr] 134 | //println!("End of group reached!"); [INFO] [stderr] 135 | break; [INFO] [stderr] 136 | } [INFO] [stderr] 137 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:134:68 [INFO] [stderr] | [INFO] [stderr] 134 | if main_group == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!main_group` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:160:44 [INFO] [stderr] | [INFO] [stderr] 160 | if parameters.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!parameters.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:180:49 [INFO] [stderr] | [INFO] [stderr] 180 | if my_name.contains("#") { [INFO] [stderr] | ^^^ help: try using a char instead: `'#'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:185:53 [INFO] [stderr] | [INFO] [stderr] 185 | if my_name.contains("{") & my_name.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'{'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:185:77 [INFO] [stderr] | [INFO] [stderr] 185 | if my_name.contains("{") & my_name.contains("}") { [INFO] [stderr] | ^^^ help: try using a char instead: `'}'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.45s [INFO] running `"docker" "inspect" "895202f62d01efc77b0d62902c7112096a839ebdb2aae142ecca610f80223790"` [INFO] running `"docker" "rm" "-f" "895202f62d01efc77b0d62902c7112096a839ebdb2aae142ecca610f80223790"` [INFO] [stdout] 895202f62d01efc77b0d62902c7112096a839ebdb2aae142ecca610f80223790