[INFO] updating cached repository derekmorr/rust-rc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/derekmorr/rust-rc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/derekmorr/rust-rc" "work/ex/clippy-test-run/sources/stable/gh/derekmorr/rust-rc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/derekmorr/rust-rc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/derekmorr/rust-rc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/derekmorr/rust-rc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/derekmorr/rust-rc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 746e1be1e4c7a2c47a43fcc33d6c738f3b4ec165 [INFO] sha for GitHub repo derekmorr/rust-rc: 746e1be1e4c7a2c47a43fcc33d6c738f3b4ec165 [INFO] validating manifest of derekmorr/rust-rc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of derekmorr/rust-rc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing derekmorr/rust-rc [INFO] finished frobbing derekmorr/rust-rc [INFO] frobbed toml for derekmorr/rust-rc written to work/ex/clippy-test-run/sources/stable/gh/derekmorr/rust-rc/Cargo.toml [INFO] started frobbing derekmorr/rust-rc [INFO] finished frobbing derekmorr/rust-rc [INFO] frobbed toml for derekmorr/rust-rc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/derekmorr/rust-rc/Cargo.toml [INFO] crate derekmorr/rust-rc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting derekmorr/rust-rc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/derekmorr/rust-rc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8da4a64c83eb32997a9bbb91552776a7fe8665ff68225513fcf5bd98ff811091 [INFO] running `"docker" "start" "-a" "8da4a64c83eb32997a9bbb91552776a7fe8665ff68225513fcf5bd98ff811091"` [INFO] [stderr] Compiling serde v1.0.70 [INFO] [stderr] Checking bytecount v0.3.1 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking multimap v0.4.0 [INFO] [stderr] Checking bv v0.7.4 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking bio v0.21.0 [INFO] [stderr] Checking rust-rc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:38:49 [INFO] [stderr] | [INFO] [stderr] 38 | fn format_output(str: &String, line_len: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | fn format_output(str: &String, line_len: usize) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/main.rs:38:49 [INFO] [stderr] | [INFO] [stderr] 38 | fn format_output(str: &String, line_len: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:38:23 [INFO] [stderr] | [INFO] [stderr] 38 | fn format_output(str: &String, line_len: usize) -> () { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.28s [INFO] running `"docker" "inspect" "8da4a64c83eb32997a9bbb91552776a7fe8665ff68225513fcf5bd98ff811091"` [INFO] running `"docker" "rm" "-f" "8da4a64c83eb32997a9bbb91552776a7fe8665ff68225513fcf5bd98ff811091"` [INFO] [stdout] 8da4a64c83eb32997a9bbb91552776a7fe8665ff68225513fcf5bd98ff811091