[INFO] updating cached repository der-On/Children-Audio-Library
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/der-On/Children-Audio-Library
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/der-On/Children-Audio-Library" "work/ex/clippy-test-run/sources/stable/gh/der-On/Children-Audio-Library"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/der-On/Children-Audio-Library'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/der-On/Children-Audio-Library" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/der-On/Children-Audio-Library"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/der-On/Children-Audio-Library'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] c8cf2ff75c6f7d8ba46929e7b3aed891debe255d
[INFO] sha for GitHub repo der-On/Children-Audio-Library: c8cf2ff75c6f7d8ba46929e7b3aed891debe255d
[INFO] validating manifest of der-On/Children-Audio-Library on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of der-On/Children-Audio-Library on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing der-On/Children-Audio-Library
[INFO] finished frobbing der-On/Children-Audio-Library
[INFO] frobbed toml for der-On/Children-Audio-Library written to work/ex/clippy-test-run/sources/stable/gh/der-On/Children-Audio-Library/Cargo.toml
[INFO] started frobbing der-On/Children-Audio-Library
[INFO] finished frobbing der-On/Children-Audio-Library
[INFO] frobbed toml for der-On/Children-Audio-Library written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/der-On/Children-Audio-Library/Cargo.toml
[INFO] crate der-On/Children-Audio-Library has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting der-On/Children-Audio-Library against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/der-On/Children-Audio-Library:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2520fc2c07bdce8a17e8ce557f07707f467714566e6ed232bff882c65325cef9
[INFO] running `"docker" "start" "-a" "2520fc2c07bdce8a17e8ce557f07707f467714566e6ed232bff882c65325cef9"`
[INFO] [stderr]     Checking tokio-io v0.1.6
[INFO] [stderr]    Compiling syn v0.13.9
[INFO] [stderr]     Checking tokio-threadpool v0.1.3
[INFO] [stderr]     Checking tokio-reactor v0.1.1
[INFO] [stderr]     Checking tokio-fs v0.1.0
[INFO] [stderr]     Checking tokio-udp v0.1.0
[INFO] [stderr]     Checking tokio-tcp v0.1.0
[INFO] [stderr]     Checking tokio v0.1.6
[INFO] [stderr]     Checking tokio-core v0.1.17
[INFO] [stderr]    Compiling serde_derive v1.0.55
[INFO] [stderr]     Checking tokio-proto v0.1.1
[INFO] [stderr]     Checking hyper v0.11.26
[INFO] [stderr]     Checking hyper-staticfile v0.2.0
[INFO] [stderr]     Checking children-audio-library v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/config.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     return Ok(config);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(config)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/library.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return library;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `library`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:103:5
[INFO] [stderr]     |
[INFO] [stderr] 103 |     return files;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `files`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 |     return dirs;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `dirs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:167:5
[INFO] [stderr]     |
[INFO] [stderr] 167 |     return album;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `album`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:174:22
[INFO] [stderr]     |
[INFO] [stderr] 174 |           Some(ext) => return IMAGE_EXTENSIONS.contains(
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 175 | |             &ext
[INFO] [stderr] 176 | |             .to_str()
[INFO] [stderr] 177 | |             .unwrap()
[INFO] [stderr] 178 | |             .to_lowercase()
[INFO] [stderr] 179 | |             .as_str()
[INFO] [stderr] 180 | |         ),
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 174 |         Some(ext) => IMAGE_EXTENSIONS.contains(
[INFO] [stderr] 175 |             &ext
[INFO] [stderr] 176 |             .to_str()
[INFO] [stderr] 177 |             .unwrap()
[INFO] [stderr] 178 |             .to_lowercase()
[INFO] [stderr] 179 |             .as_str()
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:181:17
[INFO] [stderr]     |
[INFO] [stderr] 181 |         None => return false,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:187:22
[INFO] [stderr]     |
[INFO] [stderr] 187 |           Some(ext) => return MEDIA_EXTENSIONS.contains(
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 188 | |             &ext
[INFO] [stderr] 189 | |             .to_str()
[INFO] [stderr] 190 | |             .unwrap()
[INFO] [stderr] 191 | |             .to_lowercase()
[INFO] [stderr] 192 | |             .as_str()
[INFO] [stderr] 193 | |         ),
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Some(ext) => MEDIA_EXTENSIONS.contains(
[INFO] [stderr] 188 |             &ext
[INFO] [stderr] 189 |             .to_str()
[INFO] [stderr] 190 |             .unwrap()
[INFO] [stderr] 191 |             .to_lowercase()
[INFO] [stderr] 192 |             .as_str()
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:194:17
[INFO] [stderr]     |
[INFO] [stderr] 194 |         None => return false,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:206:17
[INFO] [stderr]     |
[INFO] [stderr] 206 | /                 return humanize_filename(
[INFO] [stderr] 207 | |                     file_name.split(" - ").last().unwrap().to_string()
[INFO] [stderr] 208 | |                 )
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 humanize_filename(
[INFO] [stderr] 207 |                     file_name.split(" - ").last().unwrap().to_string()
[INFO] [stderr] 208 |                 )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:210:17
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 return file_name.trim().to_string()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:212:14
[INFO] [stderr]     |
[INFO] [stderr] 212 |         _ => return file_name.trim().to_string(),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:224:17
[INFO] [stderr]     |
[INFO] [stderr] 224 | /                 return humanize_filename(
[INFO] [stderr] 225 | |                     file_name.split(" - ").next().unwrap().to_string()
[INFO] [stderr] 226 | |                 )
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 224 |                 humanize_filename(
[INFO] [stderr] 225 |                     file_name.split(" - ").next().unwrap().to_string()
[INFO] [stderr] 226 |                 )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:228:17
[INFO] [stderr]     |
[INFO] [stderr] 228 |                 return file_name.trim().to_string()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:230:14
[INFO] [stderr]     |
[INFO] [stderr] 230 |         _ => return file_name.trim().to_string(),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:243:5
[INFO] [stderr]     |
[INFO] [stderr] 243 |     return cover;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `cover`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:260:5
[INFO] [stderr]     |
[INFO] [stderr] 260 |     return albums;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `albums`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/config.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     return Ok(config);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(config)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/library.rs:81:5
[INFO] [stderr]    |
[INFO] [stderr] 81 |     return library;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^ help: remove `return` as shown: `library`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:103:5
[INFO] [stderr]     |
[INFO] [stderr] 103 |     return files;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `files`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:128:5
[INFO] [stderr]     |
[INFO] [stderr] 128 |     return dirs;
[INFO] [stderr]     |     ^^^^^^^^^^^^ help: remove `return` as shown: `dirs`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:167:5
[INFO] [stderr]     |
[INFO] [stderr] 167 |     return album;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `album`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:174:22
[INFO] [stderr]     |
[INFO] [stderr] 174 |           Some(ext) => return IMAGE_EXTENSIONS.contains(
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 175 | |             &ext
[INFO] [stderr] 176 | |             .to_str()
[INFO] [stderr] 177 | |             .unwrap()
[INFO] [stderr] 178 | |             .to_lowercase()
[INFO] [stderr] 179 | |             .as_str()
[INFO] [stderr] 180 | |         ),
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 174 |         Some(ext) => IMAGE_EXTENSIONS.contains(
[INFO] [stderr] 175 |             &ext
[INFO] [stderr] 176 |             .to_str()
[INFO] [stderr] 177 |             .unwrap()
[INFO] [stderr] 178 |             .to_lowercase()
[INFO] [stderr] 179 |             .as_str()
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:181:17
[INFO] [stderr]     |
[INFO] [stderr] 181 |         None => return false,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:187:22
[INFO] [stderr]     |
[INFO] [stderr] 187 |           Some(ext) => return MEDIA_EXTENSIONS.contains(
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 188 | |             &ext
[INFO] [stderr] 189 | |             .to_str()
[INFO] [stderr] 190 | |             .unwrap()
[INFO] [stderr] 191 | |             .to_lowercase()
[INFO] [stderr] 192 | |             .as_str()
[INFO] [stderr] 193 | |         ),
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 187 |         Some(ext) => MEDIA_EXTENSIONS.contains(
[INFO] [stderr] 188 |             &ext
[INFO] [stderr] 189 |             .to_str()
[INFO] [stderr] 190 |             .unwrap()
[INFO] [stderr] 191 |             .to_lowercase()
[INFO] [stderr] 192 |             .as_str()
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:194:17
[INFO] [stderr]     |
[INFO] [stderr] 194 |         None => return false,
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `false`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:206:17
[INFO] [stderr]     |
[INFO] [stderr] 206 | /                 return humanize_filename(
[INFO] [stderr] 207 | |                     file_name.split(" - ").last().unwrap().to_string()
[INFO] [stderr] 208 | |                 )
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 206 |                 humanize_filename(
[INFO] [stderr] 207 |                     file_name.split(" - ").last().unwrap().to_string()
[INFO] [stderr] 208 |                 )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:210:17
[INFO] [stderr]     |
[INFO] [stderr] 210 |                 return file_name.trim().to_string()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:212:14
[INFO] [stderr]     |
[INFO] [stderr] 212 |         _ => return file_name.trim().to_string(),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:224:17
[INFO] [stderr]     |
[INFO] [stderr] 224 | /                 return humanize_filename(
[INFO] [stderr] 225 | |                     file_name.split(" - ").next().unwrap().to_string()
[INFO] [stderr] 226 | |                 )
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 224 |                 humanize_filename(
[INFO] [stderr] 225 |                     file_name.split(" - ").next().unwrap().to_string()
[INFO] [stderr] 226 |                 )
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:228:17
[INFO] [stderr]     |
[INFO] [stderr] 228 |                 return file_name.trim().to_string()
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:230:14
[INFO] [stderr]     |
[INFO] [stderr] 230 |         _ => return file_name.trim().to_string(),
[INFO] [stderr]     |              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `file_name.trim().to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:243:5
[INFO] [stderr]     |
[INFO] [stderr] 243 |     return cover;
[INFO] [stderr]     |     ^^^^^^^^^^^^^ help: remove `return` as shown: `cover`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/library.rs:260:5
[INFO] [stderr]     |
[INFO] [stderr] 260 |     return albums;
[INFO] [stderr]     |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `albums`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `file`
[INFO] [stderr]    --> src/library.rs:143:14
[INFO] [stderr]     |
[INFO] [stderr] 143 | fn file_size(file: &File) {
[INFO] [stderr]     |              ^^^^ help: consider using `_file` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `file_size`
[INFO] [stderr]    --> src/library.rs:143:1
[INFO] [stderr]     |
[INFO] [stderr] 143 | fn file_size(file: &File) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_album_cover`
[INFO] [stderr]    --> src/library.rs:170:1
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn is_album_cover(path: &Path) -> bool {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `lastFmApiKey` should have a snake case name such as `last_fm_api_key`
[INFO] [stderr]   --> src/config.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub lastFmApiKey: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `discogsConsumerKey` should have a snake case name such as `discogs_consumer_key`
[INFO] [stderr]   --> src/config.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     pub discogsConsumerKey: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `discogsConsumerSecret` should have a snake case name such as `discogs_consumer_secret`
[INFO] [stderr]   --> src/config.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     pub discogsConsumerSecret: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `bluetoothSpeaker` should have a snake case name such as `bluetooth_speaker`
[INFO] [stderr]   --> src/config.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub bluetoothSpeaker: String
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/server.rs:40:12
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if req.path().starts_with("/library/") == true {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `req.path().starts_with("/library/")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `file`
[INFO] [stderr]    --> src/library.rs:143:14
[INFO] [stderr]     |
[INFO] [stderr] 143 | fn file_size(file: &File) {
[INFO] [stderr]     |              ^^^^ help: consider using `_file` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `updatedAt` should have a snake case name such as `updated_at`
[INFO] [stderr]   --> src/library.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub updatedAt: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/library.rs:47:12
[INFO] [stderr]    |
[INFO] [stderr] 47 |         if album_contains_media(&album) == false {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!album_contains_media(&album)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/library.rs:136:5
[INFO] [stderr]     |
[INFO] [stderr] 136 |     album.media.len() > 0
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!album.media.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/library.rs:156:59
[INFO] [stderr]     |
[INFO] [stderr] 156 |     media_files.retain(|ref file| is_media_file(Path::new(file.clone().as_str())));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 156 |     media_files.retain(|ref file| is_media_file(Path::new(&(*file).clone().as_str())));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 156 |     media_files.retain(|ref file| is_media_file(Path::new(&std::string::String::clone(file).as_str())));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/library.rs:251:40
[INFO] [stderr]     |
[INFO] [stderr] 251 |     dirs.retain(|dir| !dir.starts_with(".") && !dir.starts_with("__MACOSX"));
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `children-audio-library`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: function is never used: `file_size`
[INFO] [stderr]    --> src/library.rs:143:1
[INFO] [stderr]     |
[INFO] [stderr] 143 | fn file_size(file: &File) {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `is_album_cover`
[INFO] [stderr]    --> src/library.rs:170:1
[INFO] [stderr]     |
[INFO] [stderr] 170 | fn is_album_cover(path: &Path) -> bool {
[INFO] [stderr]     | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `lastFmApiKey` should have a snake case name such as `last_fm_api_key`
[INFO] [stderr]   --> src/config.rs:10:5
[INFO] [stderr]    |
[INFO] [stderr] 10 |     pub lastFmApiKey: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `discogsConsumerKey` should have a snake case name such as `discogs_consumer_key`
[INFO] [stderr]   --> src/config.rs:11:5
[INFO] [stderr]    |
[INFO] [stderr] 11 |     pub discogsConsumerKey: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `discogsConsumerSecret` should have a snake case name such as `discogs_consumer_secret`
[INFO] [stderr]   --> src/config.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 |     pub discogsConsumerSecret: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `bluetoothSpeaker` should have a snake case name such as `bluetooth_speaker`
[INFO] [stderr]   --> src/config.rs:13:5
[INFO] [stderr]    |
[INFO] [stderr] 13 |     pub bluetoothSpeaker: String
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/server.rs:40:12
[INFO] [stderr]    |
[INFO] [stderr] 40 |         if req.path().starts_with("/library/") == true {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `req.path().starts_with("/library/")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: structure field `updatedAt` should have a snake case name such as `updated_at`
[INFO] [stderr]   --> src/library.rs:24:5
[INFO] [stderr]    |
[INFO] [stderr] 24 |     pub updatedAt: String,
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]   --> src/library.rs:47:12
[INFO] [stderr]    |
[INFO] [stderr] 47 |         if album_contains_media(&album) == false {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!album_contains_media(&album)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/library.rs:136:5
[INFO] [stderr]     |
[INFO] [stderr] 136 |     album.media.len() > 0
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!album.media.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/library.rs:156:59
[INFO] [stderr]     |
[INFO] [stderr] 156 |     media_files.retain(|ref file| is_media_file(Path::new(file.clone().as_str())));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 156 |     media_files.retain(|ref file| is_media_file(Path::new(&(*file).clone().as_str())));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 156 |     media_files.retain(|ref file| is_media_file(Path::new(&std::string::String::clone(file).as_str())));
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/library.rs:251:40
[INFO] [stderr]     |
[INFO] [stderr] 251 |     dirs.retain(|dir| !dir.starts_with(".") && !dir.starts_with("__MACOSX"));
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `children-audio-library`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "2520fc2c07bdce8a17e8ce557f07707f467714566e6ed232bff882c65325cef9"`
[INFO] running `"docker" "rm" "-f" "2520fc2c07bdce8a17e8ce557f07707f467714566e6ed232bff882c65325cef9"`
[INFO] [stdout] 2520fc2c07bdce8a17e8ce557f07707f467714566e6ed232bff882c65325cef9