[INFO] updating cached repository deployc/cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deployc/cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deployc/cli" "work/ex/clippy-test-run/sources/stable/gh/deployc/cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deployc/cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deployc/cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deployc/cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deployc/cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6b7e1ab0ee9edf24b536dea5064934b54aedd6ab [INFO] sha for GitHub repo deployc/cli: 6b7e1ab0ee9edf24b536dea5064934b54aedd6ab [INFO] validating manifest of deployc/cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deployc/cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deployc/cli [INFO] finished frobbing deployc/cli [INFO] frobbed toml for deployc/cli written to work/ex/clippy-test-run/sources/stable/gh/deployc/cli/Cargo.toml [INFO] started frobbing deployc/cli [INFO] finished frobbing deployc/cli [INFO] frobbed toml for deployc/cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deployc/cli/Cargo.toml [INFO] crate deployc/cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deployc/cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deployc/cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d3e103ae37f233c1433a14546e74ae4a66bd584ebddf9f27c65a57a88c3908ea [INFO] running `"docker" "start" "-a" "d3e103ae37f233c1433a14546e74ae4a66bd584ebddf9f27c65a57a88c3908ea"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking xattr v0.2.1 [INFO] [stderr] Checking filetime v0.2.1 [INFO] [stderr] Checking termion v1.5.1 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking serde_yaml v0.7.4 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking url_serde v0.2.0 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking tar v0.4.15 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking prettytable-rs v0.7.0 [INFO] [stderr] Checking chrono-humanize v0.0.11 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio v0.1.6 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking hyper v0.11.27 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking deployc-cli v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cli.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cli.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / write!( [INFO] [stderr] 84 | | stdout, [INFO] [stderr] 85 | | " {} {}\r\n", [INFO] [stderr] 86 | | POINTER.cyan().bold(), [INFO] [stderr] 87 | | format!("{}", opt).cyan().bold() [INFO] [stderr] 88 | | ).unwrap(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cli.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | write!(stdout, " {} {}\r\n", opt, "(current)".dimmed()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cli.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | write!(stdout, " {}\r\n", opt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/config.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | "Could not get home directory. Using local directory for user config." [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/cli.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cli.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | / write!( [INFO] [stderr] 84 | | stdout, [INFO] [stderr] 85 | | " {} {}\r\n", [INFO] [stderr] 86 | | POINTER.cyan().bold(), [INFO] [stderr] 87 | | format!("{}", opt).cyan().bold() [INFO] [stderr] 88 | | ).unwrap(); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cli.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | write!(stdout, " {} {}\r\n", opt, "(current)".dimmed()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cli.rs:93:13 [INFO] [stderr] | [INFO] [stderr] 93 | write!(stdout, " {}\r\n", opt).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/config.rs:80:21 [INFO] [stderr] | [INFO] [stderr] 80 | "Could not get home directory. Using local directory for user config." [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const API_VERSION: &'static str = "2018-06-01"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const POINTER: &'static str = "❯"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | const DEFAULT_ENDPOINT: &'static str = "https://deployc.io/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/api.rs:9:21 [INFO] [stderr] | [INFO] [stderr] 9 | const API_VERSION: &'static str = "2018-06-01"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/cli.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | const POINTER: &'static str = "❯"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | let dir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | const DEFAULT_ENDPOINT: &'static str = "https://deployc.io/"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:57:9 [INFO] [stderr] | [INFO] [stderr] 57 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:69:25 [INFO] [stderr] | [INFO] [stderr] 69 | let dir = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/api.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn app(&self, name: &String) -> APIRequestBuilder { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/app/secret.rs:70:42 [INFO] [stderr] | [INFO] [stderr] 70 | SecretType::from_str(&s).map_err(|err| de::Error::custom(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `de::Error::custom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app/mod.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_zero(u: &u16) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/app/mod.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn create(name: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 58 | pub fn create(name: &str) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 60 | app.name = name.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | prompt(" Username: ".bold()).ok_or(CommandError::with_message("Invalid username."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid username."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | .ok_or(CommandError::with_message("Invalid password."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid password."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | options: &Vec, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn get_option(options: &Vec, current_value: Option) -> Result, CommandError> [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/cli.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | let curr_idx = current_value.map_or(None, |opt| options.iter().position(|o| o == &opt)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `current_value.and_then(|opt| options.iter().position(|o| o == &opt))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cli.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn ellipsis(s: &String, max_len: usize) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 176 | pub fn ellipsis(s: &str, max_len: usize) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 180 | s.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/commands/delete.rs:30:39 [INFO] [stderr] | [INFO] [stderr] 30 | Some(ref app_name) if app_name.trim() == &app.name => println!("Deleting app..."), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `app.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/env.rs:28:51 [INFO] [stderr] | [INFO] [stderr] 28 | EnvVar::Value(val) => format!("{}", val), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/api.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | pub fn app(&self, name: &String) -> APIRequestBuilder { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/list.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if apps.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `apps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commands/secrets.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | fn encode(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/app/secret.rs:70:42 [INFO] [stderr] | [INFO] [stderr] 70 | SecretType::from_str(&s).map_err(|err| de::Error::custom(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `de::Error::custom` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app/mod.rs:21:15 [INFO] [stderr] | [INFO] [stderr] 21 | fn is_zero(u: &u16) -> bool { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/signup.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | .ok_or(CommandError::with_message("Invalid username."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid username."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/app/mod.rs:58:25 [INFO] [stderr] | [INFO] [stderr] 58 | pub fn create(name: &String) -> Result { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/signup.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | .ok_or(CommandError::with_message("Invalid email."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid email."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 58 | pub fn create(name: &str) -> Result { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `name.clone()` to [INFO] [stderr] | [INFO] [stderr] 60 | app.name = name.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/signup.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | .ok_or(CommandError::with_message("Invalid password."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid password."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:52:39 [INFO] [stderr] | [INFO] [stderr] 52 | prompt(" Username: ".bold()).ok_or(CommandError::with_message("Invalid username."))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid username."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/cli.rs:55:10 [INFO] [stderr] | [INFO] [stderr] 55 | .ok_or(CommandError::with_message("Invalid password."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid password."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:75:14 [INFO] [stderr] | [INFO] [stderr] 75 | options: &Vec, [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/cli.rs:100:31 [INFO] [stderr] | [INFO] [stderr] 100 | pub fn get_option(options: &Vec, current_value: Option) -> Result, CommandError> [INFO] [stderr] | ^^^^^^^ help: change this to: `&[T]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead [INFO] [stderr] --> src/cli.rs:116:20 [INFO] [stderr] | [INFO] [stderr] 116 | let curr_idx = current_value.map_or(None, |opt| options.iter().position(|o| o == &opt)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `current_value.and_then(|opt| options.iter().position(|o| o == &opt))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_or_none)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/cli.rs:176:20 [INFO] [stderr] | [INFO] [stderr] 176 | pub fn ellipsis(s: &String, max_len: usize) -> String { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 176 | pub fn ellipsis(s: &str, max_len: usize) -> String { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `s.clone()` to [INFO] [stderr] | [INFO] [stderr] 180 | s.to_string() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/commands/tier.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(_) = matches.subcommand_matches("upgrade") { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 42 | | check_card(config)?; [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | let ListTiersResponse { tiers } = API::new(config).tiers().get()?; [INFO] [stderr] ... | [INFO] [stderr] 57 | | println!("{} {}", "Pricing:".bold(), pricing); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("upgrade").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/commands/delete.rs:30:39 [INFO] [stderr] | [INFO] [stderr] 30 | Some(ref app_name) if app_name.trim() == &app.name => println!("Deleting app..."), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^--------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `app.name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/up.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if error_lines.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!error_lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/commands/env.rs:28:51 [INFO] [stderr] | [INFO] [stderr] 28 | EnvVar::Value(val) => format!("{}", val), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `val.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:40:54 [INFO] [stderr] | [INFO] [stderr] 40 | Url::parse(&env::var("DEPLOYC_ENDPOINT").unwrap_or(DEFAULT_ENDPOINT.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_ENDPOINT.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/list.rs:23:12 [INFO] [stderr] | [INFO] [stderr] 23 | if apps.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `apps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/commands/secrets.rs:73:18 [INFO] [stderr] | [INFO] [stderr] 73 | fn encode(s: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/signup.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | .ok_or(CommandError::with_message("Invalid username."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid username."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/signup.rs:48:14 [INFO] [stderr] | [INFO] [stderr] 48 | .ok_or(CommandError::with_message("Invalid email."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid email."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/commands/signup.rs:61:14 [INFO] [stderr] | [INFO] [stderr] 61 | .ok_or(CommandError::with_message("Invalid password."))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| CommandError::with_message("Invalid password."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/commands/tier.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | if let Some(_) = matches.subcommand_matches("upgrade") { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 42 | | check_card(config)?; [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | let ListTiersResponse { tiers } = API::new(config).tiers().get()?; [INFO] [stderr] ... | [INFO] [stderr] 57 | | println!("{} {}", "Pricing:".bold(), pricing); [INFO] [stderr] 58 | | } [INFO] [stderr] | |_________- help: try this: `if matches.subcommand_matches("upgrade").is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/commands/up.rs:95:12 [INFO] [stderr] | [INFO] [stderr] 95 | if error_lines.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!error_lines.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/config.rs:40:54 [INFO] [stderr] | [INFO] [stderr] 40 | Url::parse(&env::var("DEPLOYC_ENDPOINT").unwrap_or(DEFAULT_ENDPOINT.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| DEFAULT_ENDPOINT.to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 40.14s [INFO] running `"docker" "inspect" "d3e103ae37f233c1433a14546e74ae4a66bd584ebddf9f27c65a57a88c3908ea"` [INFO] running `"docker" "rm" "-f" "d3e103ae37f233c1433a14546e74ae4a66bd584ebddf9f27c65a57a88c3908ea"` [INFO] [stdout] d3e103ae37f233c1433a14546e74ae4a66bd584ebddf9f27c65a57a88c3908ea