[INFO] updating cached repository denysvitali/TheRealLPTBot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/denysvitali/TheRealLPTBot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/denysvitali/TheRealLPTBot" "work/ex/clippy-test-run/sources/stable/gh/denysvitali/TheRealLPTBot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/denysvitali/TheRealLPTBot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/denysvitali/TheRealLPTBot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denysvitali/TheRealLPTBot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denysvitali/TheRealLPTBot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bf44e7cb851fe6fb974d0196d3c8ade5faeb8d1b [INFO] sha for GitHub repo denysvitali/TheRealLPTBot: bf44e7cb851fe6fb974d0196d3c8ade5faeb8d1b [INFO] validating manifest of denysvitali/TheRealLPTBot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of denysvitali/TheRealLPTBot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing denysvitali/TheRealLPTBot [INFO] finished frobbing denysvitali/TheRealLPTBot [INFO] frobbed toml for denysvitali/TheRealLPTBot written to work/ex/clippy-test-run/sources/stable/gh/denysvitali/TheRealLPTBot/Cargo.toml [INFO] started frobbing denysvitali/TheRealLPTBot [INFO] finished frobbing denysvitali/TheRealLPTBot [INFO] frobbed toml for denysvitali/TheRealLPTBot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denysvitali/TheRealLPTBot/Cargo.toml [INFO] crate denysvitali/TheRealLPTBot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting denysvitali/TheRealLPTBot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/denysvitali/TheRealLPTBot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31aeefe92cd68435fb5479cc41484d418c3bcd3fa68c16f643d4eabf33b8e340 [INFO] running `"docker" "start" "-a" "31aeefe92cd68435fb5479cc41484d418c3bcd3fa68c16f643d4eabf33b8e340"` [INFO] [stderr] Compiling libz-sys v1.0.16 [INFO] [stderr] Compiling curl-sys v0.3.13 [INFO] [stderr] Checking thread-id v3.1.0 [INFO] [stderr] Checking socket2 v0.2.1 [INFO] [stderr] Checking rusqlite v0.12.0 [INFO] [stderr] Checking thread_local v0.3.3 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking curl v0.4.7 [INFO] [stderr] Checking lptbot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = "0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | const SUBREDDIT_SOURCE: &'static str = "LifeProTips"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | const SUBREDDIT_DEST: &'static str = "TheRealLPT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | return ret_vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `ret_vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:26:17 [INFO] [stderr] | [INFO] [stderr] 26 | const VERSION: &'static str = "0.1"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:28:26 [INFO] [stderr] | [INFO] [stderr] 28 | const SUBREDDIT_SOURCE: &'static str = "LifeProTips"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/main.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | const SUBREDDIT_DEST: &'static str = "TheRealLPT"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:334:5 [INFO] [stderr] | [INFO] [stderr] 334 | return ret_vec; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `ret_vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `comments` [INFO] [stderr] --> src/main.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | let comments = get_comments(id, title, author, conn, access_token); [INFO] [stderr] | ^^^^^^^^ help: consider using `_comments` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body_text` [INFO] [stderr] --> src/main.rs:301:9 [INFO] [stderr] | [INFO] [stderr] 301 | let body_text = parent["data"]["body"].as_str().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_body_text` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `row` [INFO] [stderr] --> src/main.rs:356:93 [INFO] [stderr] | [INFO] [stderr] 356 | match conn.query_row("SELECT lpt_tcid FROM posts WHERE lpt_tcid=?", &[&post.lpt_tcid], |row| { [INFO] [stderr] | ^^^ help: consider using `_row` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `comment` [INFO] [stderr] --> src/main.rs:423:53 [INFO] [stderr] | [INFO] [stderr] 423 | fn make_text(lpt: &serde_json::Value, lpt_id: &str, comment: &serde_json::Value, title: &str, lpt_author: &str) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_comment` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `title` [INFO] [stderr] --> src/main.rs:423:82 [INFO] [stderr] | [INFO] [stderr] 423 | fn make_text(lpt: &serde_json::Value, lpt_id: &str, comment: &serde_json::Value, title: &str, lpt_author: &str) -> String { [INFO] [stderr] | ^^^^^ help: consider using `_title` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `comments` [INFO] [stderr] --> src/main.rs:243:17 [INFO] [stderr] | [INFO] [stderr] 243 | let comments = get_comments(id, title, author, conn, access_token); [INFO] [stderr] | ^^^^^^^^ help: consider using `_comments` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `body_text` [INFO] [stderr] --> src/main.rs:301:9 [INFO] [stderr] | [INFO] [stderr] 301 | let body_text = parent["data"]["body"].as_str().unwrap(); [INFO] [stderr] | ^^^^^^^^^ help: consider using `_body_text` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `row` [INFO] [stderr] --> src/main.rs:356:93 [INFO] [stderr] | [INFO] [stderr] 356 | match conn.query_row("SELECT lpt_tcid FROM posts WHERE lpt_tcid=?", &[&post.lpt_tcid], |row| { [INFO] [stderr] | ^^^ help: consider using `_row` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `comment` [INFO] [stderr] --> src/main.rs:423:53 [INFO] [stderr] | [INFO] [stderr] 423 | fn make_text(lpt: &serde_json::Value, lpt_id: &str, comment: &serde_json::Value, title: &str, lpt_author: &str) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_comment` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `title` [INFO] [stderr] --> src/main.rs:423:82 [INFO] [stderr] | [INFO] [stderr] 423 | fn make_text(lpt: &serde_json::Value, lpt_id: &str, comment: &serde_json::Value, title: &str, lpt_author: &str) -> String { [INFO] [stderr] | ^^^^^ help: consider using `_title` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_me` [INFO] [stderr] --> src/main.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | fn get_me(access_token : &str){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match File::create(path) { [INFO] [stderr] 50 | | Err(why) => panic!("Unable to create file {}: {}", display, why), [INFO] [stderr] 51 | | _ => (), [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = File::create(path) { panic!("Unable to create file {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / match file.read_to_string(&mut contents) { [INFO] [stderr] 62 | | Err(why) => panic!("Cannot read credentials.yml: {}", why), [INFO] [stderr] 63 | | Ok(_) => (), [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut contents) { panic!("Cannot read credentials.yml: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | if yaml.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `yaml.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:239:29 [INFO] [stderr] | [INFO] [stderr] 239 | let re = Regex::new(r"^LPT: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | easy.follow_location(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | / match j { [INFO] [stderr] 281 | | Some(val) => { [INFO] [stderr] 282 | | parse_real_lpt(val[0], val[1], lpt_id, title, author, conn, access_token); [INFO] [stderr] 283 | | }, [INFO] [stderr] 284 | | [INFO] [stderr] 285 | | _ => {} [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 280 | if let Some(val) = j { [INFO] [stderr] 281 | parse_real_lpt(val[0], val[1], lpt_id, title, author, conn, access_token); [INFO] [stderr] 282 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | / match comment_children { [INFO] [stderr] 311 | | Some(some) => { [INFO] [stderr] 312 | | for j in some { [INFO] [stderr] 313 | | if j["kind"].as_str().unwrap() != "t1" { [INFO] [stderr] ... | [INFO] [stderr] 331 | | _ => {}, [INFO] [stderr] 332 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | if let Some(some) = comment_children { [INFO] [stderr] 311 | for j in some { [INFO] [stderr] 312 | if j["kind"].as_str().unwrap() != "t1" { [INFO] [stderr] 313 | continue; [INFO] [stderr] 314 | } [INFO] [stderr] 315 | let child_text = j["data"]["body"].as_str().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:339:40 [INFO] [stderr] | [INFO] [stderr] 339 | let v: Vec<&str> = body_text.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: function is never used: `get_me` [INFO] [stderr] --> src/main.rs:185:1 [INFO] [stderr] | [INFO] [stderr] 185 | fn get_me(access_token : &str){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match File::create(path) { [INFO] [stderr] 50 | | Err(why) => panic!("Unable to create file {}: {}", display, why), [INFO] [stderr] 51 | | _ => (), [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Err(why) = File::create(path) { panic!("Unable to create file {}: {}", display, why) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:61:5 [INFO] [stderr] | [INFO] [stderr] 61 | / match file.read_to_string(&mut contents) { [INFO] [stderr] 62 | | Err(why) => panic!("Cannot read credentials.yml: {}", why), [INFO] [stderr] 63 | | Ok(_) => (), [INFO] [stderr] 64 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(why) = file.read_to_string(&mut contents) { panic!("Cannot read credentials.yml: {}", why) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:67:8 [INFO] [stderr] | [INFO] [stderr] 67 | if yaml.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `yaml.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:415:5 [INFO] [stderr] | [INFO] [stderr] 415 | String::from(format!("TheRealLPTBot ({})", VERSION)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("TheRealLPTBot ({})", VERSION)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:432:18 [INFO] [stderr] | [INFO] [stderr] 432 | rv.push_str(&format!("^[Source](https://github.com/denysvitali/TheRealLPTBot) ^| ^[Author](https://reddit.com/u/denvit)")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"^[Source](https://github.com/denysvitali/TheRealLPTBot) ^| ^[Author](https://reddit.com/u/denvit)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/main.rs:239:29 [INFO] [stderr] | [INFO] [stderr] 239 | let re = Regex::new(r"^LPT: ").unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::starts_with` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:256:5 [INFO] [stderr] | [INFO] [stderr] 256 | easy.follow_location(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | / match j { [INFO] [stderr] 281 | | Some(val) => { [INFO] [stderr] 282 | | parse_real_lpt(val[0], val[1], lpt_id, title, author, conn, access_token); [INFO] [stderr] 283 | | }, [INFO] [stderr] 284 | | [INFO] [stderr] 285 | | _ => {} [INFO] [stderr] 286 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 280 | if let Some(val) = j { [INFO] [stderr] 281 | parse_real_lpt(val[0], val[1], lpt_id, title, author, conn, access_token); [INFO] [stderr] 282 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:310:5 [INFO] [stderr] | [INFO] [stderr] 310 | / match comment_children { [INFO] [stderr] 311 | | Some(some) => { [INFO] [stderr] 312 | | for j in some { [INFO] [stderr] 313 | | if j["kind"].as_str().unwrap() != "t1" { [INFO] [stderr] ... | [INFO] [stderr] 331 | | _ => {}, [INFO] [stderr] 332 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | if let Some(some) = comment_children { [INFO] [stderr] 311 | for j in some { [INFO] [stderr] 312 | if j["kind"].as_str().unwrap() != "t1" { [INFO] [stderr] 313 | continue; [INFO] [stderr] 314 | } [INFO] [stderr] 315 | let child_text = j["data"]["body"].as_str().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:339:40 [INFO] [stderr] | [INFO] [stderr] 339 | let v: Vec<&str> = body_text.split("\n").collect(); [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:415:5 [INFO] [stderr] | [INFO] [stderr] 415 | String::from(format!("TheRealLPTBot ({})", VERSION)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("TheRealLPTBot ({})", VERSION)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:432:18 [INFO] [stderr] | [INFO] [stderr] 432 | rv.push_str(&format!("^[Source](https://github.com/denysvitali/TheRealLPTBot) ^| ^[Author](https://reddit.com/u/denvit)")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"^[Source](https://github.com/denysvitali/TheRealLPTBot) ^| ^[Author](https://reddit.com/u/denvit)".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 41s [INFO] running `"docker" "inspect" "31aeefe92cd68435fb5479cc41484d418c3bcd3fa68c16f643d4eabf33b8e340"` [INFO] running `"docker" "rm" "-f" "31aeefe92cd68435fb5479cc41484d418c3bcd3fa68c16f643d4eabf33b8e340"` [INFO] [stdout] 31aeefe92cd68435fb5479cc41484d418c3bcd3fa68c16f643d4eabf33b8e340