[INFO] updating cached repository denniscollective/herstory [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/denniscollective/herstory [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/denniscollective/herstory" "work/ex/clippy-test-run/sources/stable/gh/denniscollective/herstory"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/denniscollective/herstory'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/denniscollective/herstory" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denniscollective/herstory"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denniscollective/herstory'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a4e229442f934facaf5435055b254781c1c1dec2 [INFO] sha for GitHub repo denniscollective/herstory: a4e229442f934facaf5435055b254781c1c1dec2 [INFO] validating manifest of denniscollective/herstory on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of denniscollective/herstory on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing denniscollective/herstory [INFO] finished frobbing denniscollective/herstory [INFO] frobbed toml for denniscollective/herstory written to work/ex/clippy-test-run/sources/stable/gh/denniscollective/herstory/Cargo.toml [INFO] started frobbing denniscollective/herstory [INFO] finished frobbing denniscollective/herstory [INFO] frobbed toml for denniscollective/herstory written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denniscollective/herstory/Cargo.toml [INFO] crate denniscollective/herstory has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting denniscollective/herstory against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/denniscollective/herstory:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2988709dfc34d100a73f3e27b414a071345936b7f37248bc2f64f4f5ce8bf352 [INFO] running `"docker" "start" "-a" "2988709dfc34d100a73f3e27b414a071345936b7f37248bc2f64f4f5ce8bf352"` [INFO] [stderr] Checking socket2 v0.2.2 [INFO] [stderr] Checking libz-sys v1.0.16 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking curl-sys v0.3.14 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking curl v0.4.8 [INFO] [stderr] Checking herstory v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/threadpool.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | func: func, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/models/mod.rs:62:13 [INFO] [stderr] | [INFO] [stderr] 62 | images: images, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `images` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/threadpool.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | func: func, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: structure field `bodyWiter` should have a snake case name such as `body_witer` [INFO] [stderr] --> src/models/request.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | bodyWiter: Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `bodyWriter` should have a snake case name such as `body_writer` [INFO] [stderr] --> src/models/request.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let bodyWriter: Arc>> = Arc::new(Mutex::new(Vec::new())); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/mod.rs:92:48 [INFO] [stderr] | [INFO] [stderr] 92 | fn filename_for(artist: &str, photoset_id: &u32, index: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/mod.rs:92:61 [INFO] [stderr] | [INFO] [stderr] 92 | fn filename_for(artist: &str, photoset_id: &u32, index: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/threadpool.rs:23:53 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn batch(worker_size: usize, collection: &Vec>>, func: F) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/threadpool.rs:45:46 [INFO] [stderr] | [INFO] [stderr] 45 | fn iter_collection(mut self, collection: &Vec>>, func: PassableFunc) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:40:48 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn photoset_dir(artist: &str, photoset_id: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | let json = unsafe { CStr::from_ptr(json_ptr) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | let artist = unsafe { CStr::from_ptr(artist_ptr) }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `herstory`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: structure field `bodyWiter` should have a snake case name such as `body_witer` [INFO] [stderr] --> src/models/request.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | bodyWiter: Arc>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `bodyWriter` should have a snake case name such as `body_writer` [INFO] [stderr] --> src/models/request.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | let bodyWriter: Arc>> = Arc::new(Mutex::new(Vec::new())); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/mod.rs:92:48 [INFO] [stderr] | [INFO] [stderr] 92 | fn filename_for(artist: &str, photoset_id: &u32, index: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/models/mod.rs:92:61 [INFO] [stderr] | [INFO] [stderr] 92 | fn filename_for(artist: &str, photoset_id: &u32, index: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/threadpool.rs:23:53 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn batch(worker_size: usize, collection: &Vec>>, func: F) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc>]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/threadpool.rs:45:46 [INFO] [stderr] | [INFO] [stderr] 45 | fn iter_collection(mut self, collection: &Vec>>, func: PassableFunc) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Arc>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:40:48 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn photoset_dir(artist: &str, photoset_id: &u32) -> String { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:51:40 [INFO] [stderr] | [INFO] [stderr] 51 | let json = unsafe { CStr::from_ptr(json_ptr) }; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:52:42 [INFO] [stderr] | [INFO] [stderr] 52 | let artist = unsafe { CStr::from_ptr(artist_ptr) }; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `herstory`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2988709dfc34d100a73f3e27b414a071345936b7f37248bc2f64f4f5ce8bf352"` [INFO] running `"docker" "rm" "-f" "2988709dfc34d100a73f3e27b414a071345936b7f37248bc2f64f4f5ce8bf352"` [INFO] [stdout] 2988709dfc34d100a73f3e27b414a071345936b7f37248bc2f64f4f5ce8bf352