[INFO] updating cached repository denmilu/badtouch [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/denmilu/badtouch [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/denmilu/badtouch" "work/ex/clippy-test-run/sources/stable/gh/denmilu/badtouch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/denmilu/badtouch'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/denmilu/badtouch" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denmilu/badtouch"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denmilu/badtouch'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3e634d781c5cf8948d50e0252055153719ac6b1d [INFO] sha for GitHub repo denmilu/badtouch: 3e634d781c5cf8948d50e0252055153719ac6b1d [INFO] validating manifest of denmilu/badtouch on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of denmilu/badtouch on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing denmilu/badtouch [INFO] finished frobbing denmilu/badtouch [INFO] frobbed toml for denmilu/badtouch written to work/ex/clippy-test-run/sources/stable/gh/denmilu/badtouch/Cargo.toml [INFO] started frobbing denmilu/badtouch [INFO] finished frobbing denmilu/badtouch [INFO] frobbed toml for denmilu/badtouch written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/denmilu/badtouch/Cargo.toml [INFO] crate denmilu/badtouch has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting denmilu/badtouch against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/denmilu/badtouch:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c06385ac37977b078e5ef6e15704e85d5598c799fff4183bcc5926b804550262 [INFO] running `"docker" "start" "-a" "c06385ac37977b078e5ef6e15704e85d5598c799fff4183bcc5926b804550262"` [INFO] [stderr] Compiling serde v1.0.43 [INFO] [stderr] Compiling procedural-masquerade v0.1.5 [INFO] [stderr] Checking keccak v0.1.0 [INFO] [stderr] Checking termios v0.3.0 [INFO] [stderr] Compiling openssl-sys v0.9.28 [INFO] [stderr] Compiling lua52-sys v0.1.1 [INFO] [stderr] Checking dtoa-short v0.3.2 [INFO] [stderr] Checking servo_arc v0.1.1 [INFO] [stderr] Checking getch v0.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.4.1 [INFO] [stderr] Checking debug_unreachable v0.1.1 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking lber v0.1.6 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Compiling syn v0.13.1 [INFO] [stderr] Checking regex v0.2.10 [INFO] [stderr] Checking futf v0.1.3 [INFO] [stderr] Checking crossbeam-deque v0.3.0 [INFO] [stderr] Checking block-cipher-trait v0.5.0 [INFO] [stderr] Checking pbr v1.0.0 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Compiling openssl v0.9.24 [INFO] [stderr] Checking tendril v0.4.0 [INFO] [stderr] Checking blowfish v0.3.0 [INFO] [stderr] Checking md-5 v0.7.0 [INFO] [stderr] Checking sha3 v0.7.3 [INFO] [stderr] Checking hmac v0.6.2 [INFO] [stderr] Checking tokio-threadpool v0.1.2 [INFO] [stderr] Compiling string_cache_codegen v0.4.1 [INFO] [stderr] Checking mysql_common v0.5.0 [INFO] [stderr] Checking env_logger v0.5.9 [INFO] [stderr] Checking bcrypt v0.2.0 [INFO] [stderr] Compiling selectors v0.19.0 [INFO] [stderr] Checking tokio v0.1.5 [INFO] [stderr] Compiling string_cache v0.7.2 [INFO] [stderr] Checking hlua-badtouch v0.4.2 [INFO] [stderr] Checking mysql v12.3.1 [INFO] [stderr] Checking tokio-core v0.1.17 [INFO] [stderr] Compiling serde_json v1.0.16 [INFO] [stderr] Checking native-tls v0.1.5 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-uds v0.1.7 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Compiling serde_derive_internals v0.23.1 [INFO] [stderr] Compiling cssparser v0.23.6 [INFO] [stderr] Compiling cssparser-macros v0.3.3 [INFO] [stderr] Compiling html5ever v0.22.3 [INFO] [stderr] Compiling structopt-derive v0.2.7 [INFO] [stderr] Checking hyper v0.11.25 [INFO] [stderr] Checking tokio-uds-proto v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.43 [INFO] [stderr] Checking structopt v0.2.7 [INFO] [stderr] Checking ldap3 v0.6.0 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Compiling markup5ever v0.7.2 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Checking kuchiki v0.7.0 [INFO] [stderr] Checking badtouch v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/lib.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | #[macro_use] extern crate structopt; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let home = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/config.rs:27:20 [INFO] [stderr] | [INFO] [stderr] 27 | let home = env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(x) => Ok(x.into_iter().map(|x| transform_element(&x)).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/scheduler.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/scheduler.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:112:38 [INFO] [stderr] | [INFO] [stderr] 112 | pause_trigger: Arc::new((Mutex::new(true), Condvar::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / error_chain! { [INFO] [stderr] 71 | | foreign_links { [INFO] [stderr] 72 | | Io(std::io::Error); [INFO] [stderr] 73 | | Lua(hlua::LuaError); [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:225:40 [INFO] [stderr] | [INFO] [stderr] 225 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 226 | | descr = "verify_false" [INFO] [stderr] 227 | | [INFO] [stderr] 228 | | function verify(user, password) [INFO] [stderr] 229 | | return false [INFO] [stderr] 230 | | end [INFO] [stderr] 231 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 225 | let script = Script::load_from(br#" [INFO] [stderr] 226 | descr = "verify_false" [INFO] [stderr] 227 | [INFO] [stderr] 228 | function verify(user, password) [INFO] [stderr] 229 | return false [INFO] [stderr] 230 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:239:40 [INFO] [stderr] | [INFO] [stderr] 239 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 240 | | descr = "verify_false" [INFO] [stderr] 241 | | [INFO] [stderr] 242 | | function verify(user, password) [INFO] [stderr] 243 | | return true [INFO] [stderr] 244 | | end [INFO] [stderr] 245 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 239 | let script = Script::load_from(br#" [INFO] [stderr] 240 | descr = "verify_false" [INFO] [stderr] 241 | [INFO] [stderr] 242 | function verify(user, password) [INFO] [stderr] 243 | return true [INFO] [stderr] 244 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:253:40 [INFO] [stderr] | [INFO] [stderr] 253 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 254 | | descr = "json" [INFO] [stderr] 255 | | [INFO] [stderr] 256 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 259 | | end [INFO] [stderr] 260 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 253 | let script = Script::load_from(br#" [INFO] [stderr] 254 | descr = "json" [INFO] [stderr] 255 | [INFO] [stderr] 256 | function verify(user, password) [INFO] [stderr] 257 | json_decode("{{{{{{{{{{{{{{{{{{") [INFO] [stderr] 258 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:268:40 [INFO] [stderr] | [INFO] [stderr] 268 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 269 | | descr = "json" [INFO] [stderr] 270 | | [INFO] [stderr] 271 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 275 | | end [INFO] [stderr] 276 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 268 | let script = Script::load_from(br#" [INFO] [stderr] 269 | descr = "json" [INFO] [stderr] 270 | [INFO] [stderr] 271 | function verify(user, password) [INFO] [stderr] 272 | json_decode("{{{{{{{{{{{{{{{{{{") [INFO] [stderr] 273 | clear_err() [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:284:40 [INFO] [stderr] | [INFO] [stderr] 284 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 285 | | descr = "slow script" [INFO] [stderr] 286 | | [INFO] [stderr] 287 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 290 | | end [INFO] [stderr] 291 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 284 | let script = Script::load_from(br#" [INFO] [stderr] 285 | descr = "slow script" [INFO] [stderr] 286 | [INFO] [stderr] 287 | function verify(user, password) [INFO] [stderr] 288 | sleep(1) [INFO] [stderr] 289 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:299:40 [INFO] [stderr] | [INFO] [stderr] 299 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 300 | | descr = "basic auth httpbin.org" [INFO] [stderr] 301 | | [INFO] [stderr] 302 | | function verify(user, password) [INFO] [stderr] 303 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 304 | | end [INFO] [stderr] 305 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 299 | let script = Script::load_from(br#" [INFO] [stderr] 300 | descr = "basic auth httpbin.org" [INFO] [stderr] 301 | [INFO] [stderr] 302 | function verify(user, password) [INFO] [stderr] 303 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 304 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:313:40 [INFO] [stderr] | [INFO] [stderr] 313 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 314 | | descr = "basic auth httpbin.org" [INFO] [stderr] 315 | | [INFO] [stderr] 316 | | function verify(user, password) [INFO] [stderr] 317 | | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 318 | | end [INFO] [stderr] 319 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 313 | let script = Script::load_from(br#" [INFO] [stderr] 314 | descr = "basic auth httpbin.org" [INFO] [stderr] 315 | [INFO] [stderr] 316 | function verify(user, password) [INFO] [stderr] 317 | return http_basic_auth("https://httpbin.org/basic-auth/foo/buzz", user, password) [INFO] [stderr] 318 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:327:40 [INFO] [stderr] | [INFO] [stderr] 327 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 328 | | descr = "hex test" [INFO] [stderr] 329 | | [INFO] [stderr] 330 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 333 | | end [INFO] [stderr] 334 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 327 | let script = Script::load_from(br#" [INFO] [stderr] 328 | descr = "hex test" [INFO] [stderr] 329 | [INFO] [stderr] 330 | function verify(user, password) [INFO] [stderr] 331 | x = hex({0x6F, 0x68, 0x61, 0x69, 0x0A, 0x00}) [INFO] [stderr] 332 | return x == "6f6861690a00" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:342:40 [INFO] [stderr] | [INFO] [stderr] 342 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 343 | | descr = "hex test" [INFO] [stderr] 344 | | [INFO] [stderr] 345 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 348 | | end [INFO] [stderr] 349 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 342 | let script = Script::load_from(br#" [INFO] [stderr] 343 | descr = "hex test" [INFO] [stderr] 344 | [INFO] [stderr] 345 | function verify(user, password) [INFO] [stderr] 346 | x = hex({}) [INFO] [stderr] 347 | return x == "" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:357:40 [INFO] [stderr] | [INFO] [stderr] 357 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 358 | | descr = "json" [INFO] [stderr] 359 | | [INFO] [stderr] 360 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 372 | | end [INFO] [stderr] 373 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 357 | let script = Script::load_from(br#" [INFO] [stderr] 358 | descr = "json" [INFO] [stderr] 359 | [INFO] [stderr] 360 | function verify(user, password) [INFO] [stderr] 361 | json_encode({ [INFO] [stderr] 362 | hello="world", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:381:40 [INFO] [stderr] | [INFO] [stderr] 381 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 382 | | descr = "json" [INFO] [stderr] 383 | | [INFO] [stderr] 384 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 398 | | end [INFO] [stderr] 399 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 381 | let script = Script::load_from(br#" [INFO] [stderr] 382 | descr = "json" [INFO] [stderr] 383 | [INFO] [stderr] 384 | function verify(user, password) [INFO] [stderr] 385 | x = json_encode({ [INFO] [stderr] 386 | hello="world", [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:407:40 [INFO] [stderr] | [INFO] [stderr] 407 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 408 | | descr = "json" [INFO] [stderr] 409 | | [INFO] [stderr] 410 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 413 | | end [INFO] [stderr] 414 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 407 | let script = Script::load_from(br#" [INFO] [stderr] 408 | descr = "json" [INFO] [stderr] 409 | [INFO] [stderr] 410 | function verify(user, password) [INFO] [stderr] 411 | json_decode("{\"almost_one\":0.9999,\"data\":{\"password\":\"fizz\",\"user\":\"bar\"},\"hello\":\"world\",\"list\":[1,3,3,7]}") [INFO] [stderr] 412 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:422:40 [INFO] [stderr] | [INFO] [stderr] 422 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 423 | | descr = "json" [INFO] [stderr] 424 | | [INFO] [stderr] 425 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 428 | | end [INFO] [stderr] 429 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 422 | let script = Script::load_from(br#" [INFO] [stderr] 423 | descr = "json" [INFO] [stderr] 424 | [INFO] [stderr] 425 | function verify(user, password) [INFO] [stderr] 426 | json_decode("{\"almost_one\":0.9999,\"data\":{\"password\":\"fizz\",\"user\":\"bar\"}}}}}}}}}") [INFO] [stderr] 427 | return true [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:437:40 [INFO] [stderr] | [INFO] [stderr] 437 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 438 | | descr = "hmac_md5" [INFO] [stderr] 439 | | [INFO] [stderr] 440 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 444 | | end [INFO] [stderr] 445 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 437 | let script = Script::load_from(br#" [INFO] [stderr] 438 | descr = "hmac_md5" [INFO] [stderr] 439 | [INFO] [stderr] 440 | function verify(user, password) [INFO] [stderr] 441 | x = hex(hmac_md5("foo", "bar")) [INFO] [stderr] 442 | -- print('md5: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:453:40 [INFO] [stderr] | [INFO] [stderr] 453 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 454 | | descr = "hmac_sha1" [INFO] [stderr] 455 | | [INFO] [stderr] 456 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 460 | | end [INFO] [stderr] 461 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 453 | let script = Script::load_from(br#" [INFO] [stderr] 454 | descr = "hmac_sha1" [INFO] [stderr] 455 | [INFO] [stderr] 456 | function verify(user, password) [INFO] [stderr] 457 | x = hex(hmac_sha1("foo", "bar")) [INFO] [stderr] 458 | -- print('sha1: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:469:40 [INFO] [stderr] | [INFO] [stderr] 469 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 470 | | descr = "hmac_sha2_256" [INFO] [stderr] 471 | | [INFO] [stderr] 472 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 476 | | end [INFO] [stderr] 477 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 469 | let script = Script::load_from(br#" [INFO] [stderr] 470 | descr = "hmac_sha2_256" [INFO] [stderr] 471 | [INFO] [stderr] 472 | function verify(user, password) [INFO] [stderr] 473 | x = hex(hmac_sha2_256("foo", "bar")) [INFO] [stderr] 474 | -- print('sha2_256: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:485:40 [INFO] [stderr] | [INFO] [stderr] 485 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 486 | | descr = "hmac_sha2_512" [INFO] [stderr] 487 | | [INFO] [stderr] 488 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 492 | | end [INFO] [stderr] 493 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 485 | let script = Script::load_from(br#" [INFO] [stderr] 486 | descr = "hmac_sha2_512" [INFO] [stderr] 487 | [INFO] [stderr] 488 | function verify(user, password) [INFO] [stderr] 489 | x = hex(hmac_sha2_512("foo", "bar")) [INFO] [stderr] 490 | -- print('sha2_512: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:501:40 [INFO] [stderr] | [INFO] [stderr] 501 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 502 | | descr = "hmac_sha3_256" [INFO] [stderr] 503 | | [INFO] [stderr] 504 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 508 | | end [INFO] [stderr] 509 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 501 | let script = Script::load_from(br#" [INFO] [stderr] 502 | descr = "hmac_sha3_256" [INFO] [stderr] 503 | [INFO] [stderr] 504 | function verify(user, password) [INFO] [stderr] 505 | x = hex(hmac_sha3_256("foo", "bar")) [INFO] [stderr] 506 | -- print('sha3_256: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:517:40 [INFO] [stderr] | [INFO] [stderr] 517 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 518 | | descr = "hmac_sha3_512" [INFO] [stderr] 519 | | [INFO] [stderr] 520 | | function verify(user, password) [INFO] [stderr] ... | [INFO] [stderr] 524 | | end [INFO] [stderr] 525 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 517 | let script = Script::load_from(br#" [INFO] [stderr] 518 | descr = "hmac_sha3_512" [INFO] [stderr] 519 | [INFO] [stderr] 520 | function verify(user, password) [INFO] [stderr] 521 | x = hex(hmac_sha3_512("foo", "bar")) [INFO] [stderr] 522 | -- print('sha3_512: ' .. x) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/ctx.rs:533:40 [INFO] [stderr] | [INFO] [stderr] 533 | let script = Script::load_from(r#" [INFO] [stderr] | ________________________________________^ [INFO] [stderr] 534 | | descr = "bcrypt_verify" [INFO] [stderr] 535 | | [INFO] [stderr] 536 | | function verify(user, password) [INFO] [stderr] 537 | | return bcrypt_verify(password, "$2a$12$ByUlHCHx3rxMsdQONpuFbulQqut6GQ/84I5EAUkCqTTI07JA7wUju") [INFO] [stderr] 538 | | end [INFO] [stderr] 539 | | "#.as_bytes(), empty_config()).unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 533 | let script = Script::load_from(br#" [INFO] [stderr] 534 | descr = "bcrypt_verify" [INFO] [stderr] 535 | [INFO] [stderr] 536 | function verify(user, password) [INFO] [stderr] 537 | return bcrypt_verify(password, "$2a$12$ByUlHCHx3rxMsdQONpuFbulQqut6GQ/84I5EAUkCqTTI07JA7wUju") [INFO] [stderr] 538 | end [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/html.rs:57:21 [INFO] [stderr] | [INFO] [stderr] 57 | Ok(x) => Ok(x.into_iter().map(|x| transform_element(&x)).collect()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/scheduler.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/scheduler.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | Attempt(Box, Result), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/scheduler.rs:112:38 [INFO] [stderr] | [INFO] [stderr] 112 | pause_trigger: Arc::new((Mutex::new(true), Condvar::new())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/lib.rs:70:5 [INFO] [stderr] | [INFO] [stderr] 70 | / error_chain! { [INFO] [stderr] 71 | | foreign_links { [INFO] [stderr] 72 | | Io(std::io::Error); [INFO] [stderr] 73 | | Lua(hlua::LuaError); [INFO] [stderr] ... | [INFO] [stderr] 84 | | } [INFO] [stderr] 85 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> examples/load-creds.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | let path = env::args().skip(1).next().expect("missing argument"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 40s [INFO] running `"docker" "inspect" "c06385ac37977b078e5ef6e15704e85d5598c799fff4183bcc5926b804550262"` [INFO] running `"docker" "rm" "-f" "c06385ac37977b078e5ef6e15704e85d5598c799fff4183bcc5926b804550262"` [INFO] [stdout] c06385ac37977b078e5ef6e15704e85d5598c799fff4183bcc5926b804550262