[INFO] updating cached repository delaemon/rust-greatest-common-divisor [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/delaemon/rust-greatest-common-divisor [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/delaemon/rust-greatest-common-divisor" "work/ex/clippy-test-run/sources/stable/gh/delaemon/rust-greatest-common-divisor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/delaemon/rust-greatest-common-divisor'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/delaemon/rust-greatest-common-divisor" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/delaemon/rust-greatest-common-divisor"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/delaemon/rust-greatest-common-divisor'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8034274b91ae2b60b6ffb99fa30c3f08337021aa [INFO] sha for GitHub repo delaemon/rust-greatest-common-divisor: 8034274b91ae2b60b6ffb99fa30c3f08337021aa [INFO] validating manifest of delaemon/rust-greatest-common-divisor on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of delaemon/rust-greatest-common-divisor on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing delaemon/rust-greatest-common-divisor [INFO] finished frobbing delaemon/rust-greatest-common-divisor [INFO] frobbed toml for delaemon/rust-greatest-common-divisor written to work/ex/clippy-test-run/sources/stable/gh/delaemon/rust-greatest-common-divisor/Cargo.toml [INFO] started frobbing delaemon/rust-greatest-common-divisor [INFO] finished frobbing delaemon/rust-greatest-common-divisor [INFO] frobbed toml for delaemon/rust-greatest-common-divisor written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/delaemon/rust-greatest-common-divisor/Cargo.toml [INFO] crate delaemon/rust-greatest-common-divisor has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting delaemon/rust-greatest-common-divisor against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/delaemon/rust-greatest-common-divisor:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b77aa2c806a1fb0c7da69e4a0a2b3d263fd0ff3384e294121211dc37420eb949 [INFO] running `"docker" "start" "-a" "b77aa2c806a1fb0c7da69e4a0a2b3d263fd0ff3384e294121211dc37420eb949"` [INFO] [stderr] Checking greatest_common_divisor v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return gcd(b, a % b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(b, a % b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | return gcd(b, a % b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `gcd(b, a % b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / io::stdin().read_line(&mut argv) [INFO] [stderr] 13 | | .ok() [INFO] [stderr] 14 | | .expect("Failed to read line"); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / io::stdin().read_line(&mut argv) [INFO] [stderr] 13 | | .ok() [INFO] [stderr] 14 | | .expect("Failed to read line"); [INFO] [stderr] | |______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.82s [INFO] running `"docker" "inspect" "b77aa2c806a1fb0c7da69e4a0a2b3d263fd0ff3384e294121211dc37420eb949"` [INFO] running `"docker" "rm" "-f" "b77aa2c806a1fb0c7da69e4a0a2b3d263fd0ff3384e294121211dc37420eb949"` [INFO] [stdout] b77aa2c806a1fb0c7da69e4a0a2b3d263fd0ff3384e294121211dc37420eb949