[INFO] updating cached repository degroote22/pfclp
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/degroote22/pfclp
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/degroote22/pfclp" "work/ex/clippy-test-run/sources/stable/gh/degroote22/pfclp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/degroote22/pfclp'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/degroote22/pfclp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/degroote22/pfclp"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/degroote22/pfclp'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] ac11da6281b4a96a154bd952437d654b0eef4118
[INFO] sha for GitHub repo degroote22/pfclp: ac11da6281b4a96a154bd952437d654b0eef4118
[INFO] validating manifest of degroote22/pfclp on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of degroote22/pfclp on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing degroote22/pfclp
[INFO] finished frobbing degroote22/pfclp
[INFO] frobbed toml for degroote22/pfclp written to work/ex/clippy-test-run/sources/stable/gh/degroote22/pfclp/Cargo.toml
[INFO] started frobbing degroote22/pfclp
[INFO] finished frobbing degroote22/pfclp
[INFO] frobbed toml for degroote22/pfclp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/degroote22/pfclp/Cargo.toml
[INFO] crate degroote22/pfclp has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting degroote22/pfclp against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/degroote22/pfclp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 59f98e4bdf7e241ac16a7ac7f84a0edc219156f68e7e7fcb99785bbca1484ad3
[INFO] running `"docker" "start" "-a" "59f98e4bdf7e241ac16a7ac7f84a0edc219156f68e7e7fcb99785bbca1484ad3"`
[INFO] [stderr]     Checking pfclp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]   --> src/main.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 |         println!("");
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/falp/lsa.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return s_star;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `s_star`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/falp/lsa.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 | /                         if s_star.contains(col) {
[INFO] [stderr] 26 | |                             if col.index != index {
[INFO] [stderr] 27 | |                                 result += 1;
[INFO] [stderr] 28 | |                             }
[INFO] [stderr] 29 | |                         }
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 25 |                         if s_star.contains(col) && col.index != index {
[INFO] [stderr] 26 |     result += 1;
[INFO] [stderr] 27 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/parser.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 |     collisions
[INFO] [stderr]     |     ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/parser.rs:70:22
[INFO] [stderr]     |
[INFO] [stderr] 70  |       let collisions = all_collisions.iter().enumerate().fold(vec![], |mut p, c| {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 71  | |         let (index, items) = c;
[INFO] [stderr] 72  | |
[INFO] [stderr] 73  | |         let index_to_place = index / num_candidates as usize;
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |         }
[INFO] [stderr] 105 | |     });
[INFO] [stderr]     | |______^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             return p;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `p`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             return p;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `p`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 return InstanceFace::new(item_index_to_place, item_face_to_place as u8);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `InstanceFace::new(item_index_to_place, item_face_to_place as u8)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/calc.rs:4:60
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn calc(instance: &instance::ParsedInstance, solution: &Vec<u8>) -> u64 {
[INFO] [stderr]   |                                                            ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:50:40
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn get_collisions(&self, with: &InstanceFace) -> Option<&HashSet<InstanceFace>> {
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:55:33
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn collides(&self, lhs: &InstanceFace, rhs: &InstanceFace) -> bool {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:55:53
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn collides(&self, lhs: &InstanceFace, rhs: &InstanceFace) -> bool {
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:62:35
[INFO] [stderr]    |
[INFO] [stderr] 62 |     pub fn point_degree(&self, p: &InstanceFace) -> u32 {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/instance.rs:81:36
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn make_collisions_map(collisions: &CollisionVec, len: u32) -> CollisionMap {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/instance.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 | /             if !collisions_bag.contains_key(&face) {
[INFO] [stderr] 91 | |                 collisions_bag.insert(face, HashSet::new());
[INFO] [stderr] 92 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `collisions_bag.entry(face).or_insert(HashSet::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]  --> src/io.rs:5:39
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let mut f = File::open(file_name).expect(&format!("file {} not found", file_name));
[INFO] [stderr]   |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("file {} not found", file_name))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/io.rs:7:37
[INFO] [stderr]    |
[INFO] [stderr] 7  |       f.read_to_string(&mut contents).expect(&format!(
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 8  | |         "something went wrong reading the file {}",
[INFO] [stderr] 9  | |         file_name
[INFO] [stderr] 10 | |     ));
[INFO] [stderr]    | |______^ help: try this: `unwrap_or_else(|_| panic!("something went wrong reading the file {}", file_name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/falp/mnla.rs:22:12
[INFO] [stderr]    |
[INFO] [stderr] 22 |         if l_star.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l_star.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/falp/mnla.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |               if let None = l_star.remove(col) {
[INFO] [stderr]    |  _____________-      ^^^^
[INFO] [stderr] 41 | |                 continue;
[INFO] [stderr] 42 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if l_star.remove(col).is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/falp/mnla.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 | /                 match l_star.get_mut(c) {
[INFO] [stderr] 48 | |                     Some(x) => {
[INFO] [stderr] 49 | |                         *x -= 1;
[INFO] [stderr] 50 | |                     }
[INFO] [stderr] 51 | |                     None => {}
[INFO] [stderr] 52 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 if let Some(x) = l_star.get_mut(c) {
[INFO] [stderr] 48 |     *x -= 1;
[INFO] [stderr] 49 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/falp/plwc.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 44 |         if l_star.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l_star.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/falp/rclv.rs:32:47
[INFO] [stderr]    |
[INFO] [stderr] 32 |         min.unwrap() + ((config.alpha.get() * (max.unwrap() - min.unwrap()) as f64) as u32);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max.unwrap() - min.unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/falp/rclv.rs:37:12
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if deg <= &treshold {
[INFO] [stderr]    |            ^^^^^^^---------
[INFO] [stderr]    |                   |
[INFO] [stderr]    |                   help: use the right value directly: `treshold`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
[INFO] [stderr]   --> src/falp/rclv.rs:50:7
[INFO] [stderr]    |
[INFO] [stderr] 50 |     **v.iter().nth(nth).unwrap()
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_nth)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if clean_line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `clean_line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/parser.rs:87:58
[INFO] [stderr]    |
[INFO] [stderr] 87 |                 let item_index_to_place = correct_item / num_candidates as u32;
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_candidates)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/parser.rs:88:57
[INFO] [stderr]    |
[INFO] [stderr] 88 |                 let item_face_to_place = correct_item % num_candidates as u32;
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_candidates)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:69:50
[INFO] [stderr]    |
[INFO] [stderr] 69 |     let rls: f64 = 100.0 * (conflicting as f64 / instance.get_num_points() as f64);
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(instance.get_num_points())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/falp/lsa.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     return s_star;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^ help: remove `return` as shown: `s_star`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/falp/lsa.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 | /                         if s_star.contains(col) {
[INFO] [stderr] 26 | |                             if col.index != index {
[INFO] [stderr] 27 | |                                 result += 1;
[INFO] [stderr] 28 | |                             }
[INFO] [stderr] 29 | |                         }
[INFO] [stderr]    | |_________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 25 |                         if s_star.contains(col) && col.index != index {
[INFO] [stderr] 26 |     result += 1;
[INFO] [stderr] 27 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/parser.rs:106:5
[INFO] [stderr]     |
[INFO] [stderr] 106 |     collisions
[INFO] [stderr]     |     ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/parser.rs:70:22
[INFO] [stderr]     |
[INFO] [stderr] 70  |       let collisions = all_collisions.iter().enumerate().fold(vec![], |mut p, c| {
[INFO] [stderr]     |  ______________________^
[INFO] [stderr] 71  | |         let (index, items) = c;
[INFO] [stderr] 72  | |
[INFO] [stderr] 73  | |         let index_to_place = index / num_candidates as usize;
[INFO] [stderr] ...   |
[INFO] [stderr] 104 | |         }
[INFO] [stderr] 105 | |     });
[INFO] [stderr]     | |______^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:100:13
[INFO] [stderr]     |
[INFO] [stderr] 100 |             return p;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `p`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:103:13
[INFO] [stderr]     |
[INFO] [stderr] 103 |             return p;
[INFO] [stderr]     |             ^^^^^^^^^ help: remove `return` as shown: `p`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 return InstanceFace::new(item_index_to_place, item_face_to_place as u8);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `InstanceFace::new(item_index_to_place, item_face_to_place as u8)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/parser.rs:187:17
[INFO] [stderr]     |
[INFO] [stderr] 187 |                 return InstanceFace::new(item_index_to_place, item_face_to_place as u8);
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `InstanceFace::new(item_index_to_place, item_face_to_place as u8)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/test_helpers.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     instance
[INFO] [stderr]    |     ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/test_helpers.rs:14:20
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let instance = ParsedInstance::new(4, 2, vec![point_a, point_b]);
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/calc.rs:4:60
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn calc(instance: &instance::ParsedInstance, solution: &Vec<u8>) -> u64 {
[INFO] [stderr]   |                                                            ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:50:40
[INFO] [stderr]    |
[INFO] [stderr] 50 |     pub fn get_collisions(&self, with: &InstanceFace) -> Option<&HashSet<InstanceFace>> {
[INFO] [stderr]    |                                        ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:55:33
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn collides(&self, lhs: &InstanceFace, rhs: &InstanceFace) -> bool {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:55:53
[INFO] [stderr]    |
[INFO] [stderr] 55 |     pub fn collides(&self, lhs: &InstanceFace, rhs: &InstanceFace) -> bool {
[INFO] [stderr]    |                                                     ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/instance.rs:62:35
[INFO] [stderr]    |
[INFO] [stderr] 62 |     pub fn point_degree(&self, p: &InstanceFace) -> u32 {
[INFO] [stderr]    |                                   ^^^^^^^^^^^^^ help: consider passing by value instead: `InstanceFace`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/instance.rs:81:36
[INFO] [stderr]    |
[INFO] [stderr] 81 | fn make_collisions_map(collisions: &CollisionVec, len: u32) -> CollisionMap {
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap`
[INFO] [stderr]   --> src/instance.rs:90:13
[INFO] [stderr]    |
[INFO] [stderr] 90 | /             if !collisions_bag.contains_key(&face) {
[INFO] [stderr] 91 | |                 collisions_bag.insert(face, HashSet::new());
[INFO] [stderr] 92 | |             }
[INFO] [stderr]    | |_____________^ help: consider using: `collisions_bag.entry(face).or_insert(HashSet::new())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::map_entry)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/instance.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |         assert_eq!(map.get(&face_a_0).unwrap(), &set0);
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&map[&face_a_0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]  --> src/io.rs:5:39
[INFO] [stderr]   |
[INFO] [stderr] 5 |     let mut f = File::open(file_name).expect(&format!("file {} not found", file_name));
[INFO] [stderr]   |                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("file {} not found", file_name))`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/io.rs:7:37
[INFO] [stderr]    |
[INFO] [stderr] 7  |       f.read_to_string(&mut contents).expect(&format!(
[INFO] [stderr]    |  _____________________________________^
[INFO] [stderr] 8  | |         "something went wrong reading the file {}",
[INFO] [stderr] 9  | |         file_name
[INFO] [stderr] 10 | |     ));
[INFO] [stderr]    | |______^ help: try this: `unwrap_or_else(|_| panic!("something went wrong reading the file {}", file_name))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/falp/mnla.rs:22:12
[INFO] [stderr]    |
[INFO] [stderr] 22 |         if l_star.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l_star.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_none()`
[INFO] [stderr]   --> src/falp/mnla.rs:40:20
[INFO] [stderr]    |
[INFO] [stderr] 40 |               if let None = l_star.remove(col) {
[INFO] [stderr]    |  _____________-      ^^^^
[INFO] [stderr] 41 | |                 continue;
[INFO] [stderr] 42 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if l_star.remove(col).is_none()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/falp/mnla.rs:47:17
[INFO] [stderr]    |
[INFO] [stderr] 47 | /                 match l_star.get_mut(c) {
[INFO] [stderr] 48 | |                     Some(x) => {
[INFO] [stderr] 49 | |                         *x -= 1;
[INFO] [stderr] 50 | |                     }
[INFO] [stderr] 51 | |                     None => {}
[INFO] [stderr] 52 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 47 |                 if let Some(x) = l_star.get_mut(c) {
[INFO] [stderr] 48 |     *x -= 1;
[INFO] [stderr] 49 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/falp/plwc.rs:44:12
[INFO] [stderr]    |
[INFO] [stderr] 44 |         if l_star.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `l_star.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/falp/rclv.rs:32:47
[INFO] [stderr]    |
[INFO] [stderr] 32 |         min.unwrap() + ((config.alpha.get() * (max.unwrap() - min.unwrap()) as f64) as u32);
[INFO] [stderr]    |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(max.unwrap() - min.unwrap())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]   --> src/falp/rclv.rs:37:12
[INFO] [stderr]    |
[INFO] [stderr] 37 |         if deg <= &treshold {
[INFO] [stderr]    |            ^^^^^^^---------
[INFO] [stderr]    |                   |
[INFO] [stderr]    |                   help: use the right value directly: `treshold`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
[INFO] [stderr]   --> src/falp/rclv.rs:50:7
[INFO] [stderr]    |
[INFO] [stderr] 50 |     **v.iter().nth(nth).unwrap()
[INFO] [stderr]    |       ^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::iter_nth)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_nth
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/parser.rs:35:12
[INFO] [stderr]    |
[INFO] [stderr] 35 |         if clean_line.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `clean_line.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/parser.rs:87:58
[INFO] [stderr]    |
[INFO] [stderr] 87 |                 let item_index_to_place = correct_item / num_candidates as u32;
[INFO] [stderr]    |                                                          ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_candidates)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]   --> src/parser.rs:88:57
[INFO] [stderr]    |
[INFO] [stderr] 88 |                 let item_face_to_place = correct_item % num_candidates as u32;
[INFO] [stderr]    |                                                         ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(num_candidates)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/parser.rs:185:58
[INFO] [stderr]     |
[INFO] [stderr] 185 |                 let item_index_to_place = correct_item / parsed.num_candidates as u32;
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parsed.num_candidates)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change
[INFO] [stderr]    --> src/parser.rs:186:57
[INFO] [stderr]     |
[INFO] [stderr] 186 |                 let item_face_to_place = correct_item % parsed.num_candidates as u32;
[INFO] [stderr]     |                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(parsed.num_candidates)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:69:50
[INFO] [stderr]    |
[INFO] [stderr] 69 |     let rls: f64 = 100.0 * (conflicting as f64 / instance.get_num_points() as f64);
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(instance.get_num_points())`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.31s
[INFO] running `"docker" "inspect" "59f98e4bdf7e241ac16a7ac7f84a0edc219156f68e7e7fcb99785bbca1484ad3"`
[INFO] running `"docker" "rm" "-f" "59f98e4bdf7e241ac16a7ac7f84a0edc219156f68e7e7fcb99785bbca1484ad3"`
[INFO] [stdout] 59f98e4bdf7e241ac16a7ac7f84a0edc219156f68e7e7fcb99785bbca1484ad3