[INFO] updating cached repository defcube/defparallel
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/defcube/defparallel
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/defcube/defparallel" "work/ex/clippy-test-run/sources/stable/gh/defcube/defparallel"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/defcube/defparallel'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/defcube/defparallel" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/defcube/defparallel"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/defcube/defparallel'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f90380f9cdaba71f68ab4c4e64232f8d80fa27a6
[INFO] sha for GitHub repo defcube/defparallel: f90380f9cdaba71f68ab4c4e64232f8d80fa27a6
[INFO] validating manifest of defcube/defparallel on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of defcube/defparallel on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing defcube/defparallel
[INFO] finished frobbing defcube/defparallel
[INFO] frobbed toml for defcube/defparallel written to work/ex/clippy-test-run/sources/stable/gh/defcube/defparallel/Cargo.toml
[INFO] started frobbing defcube/defparallel
[INFO] finished frobbing defcube/defparallel
[INFO] frobbed toml for defcube/defparallel written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/defcube/defparallel/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting defcube/defparallel against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/defcube/defparallel:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0b2c7c77a90c59bcf19e83b5ca67b7997ef1ef67fb954cd15d722062a18d9b82
[INFO] running `"docker" "start" "-a" "0b2c7c77a90c59bcf19e83b5ca67b7997ef1ef67fb954cd15d722062a18d9b82"`
[INFO] [stderr]     Checking ansi-escapes v0.1.0
[INFO] [stderr]    Compiling heck v0.3.1
[INFO] [stderr]     Checking atty v0.2.11
[INFO] [stderr]     Checking termios v0.3.1
[INFO] [stderr]    Compiling syn v0.15.26
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking crossterm v0.4.3
[INFO] [stderr]    Compiling structopt-derive v0.2.14
[INFO] [stderr]     Checking structopt v0.2.14
[INFO] [stderr]     Checking defparallel v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 |     return (cx, threads);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(cx, threads)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/main.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 |             if commands.len() >= 1 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/main.rs:82:20
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 if thread_state.is_running & all_done == true {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `thread_state.is_running & all_done`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:130:12
[INFO] [stderr]     |
[INFO] [stderr] 130 |         if self.stdout.len() > 0 && self.had_error {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stdout.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:140:12
[INFO] [stderr]     |
[INFO] [stderr] 140 |         if self.stderr.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stderr.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:160:12
[INFO] [stderr]     |
[INFO] [stderr] 160 |         if command.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:163:65
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let command_parts: Vec<String> = command.split(' ').map(|x| String::from(x)).collect();
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:187:22
[INFO] [stderr]     |
[INFO] [stderr] 187 |             command: format!("{}", command),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `command.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/main.rs:197:5
[INFO] [stderr]     |
[INFO] [stderr] 197 |     return (cx, threads);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(cx, threads)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/main.rs:27:16
[INFO] [stderr]    |
[INFO] [stderr] 27 |             if commands.len() >= 1 {
[INFO] [stderr]    |                ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!commands.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against true are unnecessary
[INFO] [stderr]   --> src/main.rs:82:20
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 if thread_state.is_running & all_done == true {
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `thread_state.is_running & all_done`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:130:12
[INFO] [stderr]     |
[INFO] [stderr] 130 |         if self.stdout.len() > 0 && self.had_error {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stdout.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:140:12
[INFO] [stderr]     |
[INFO] [stderr] 140 |         if self.stderr.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.stderr.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/main.rs:160:12
[INFO] [stderr]     |
[INFO] [stderr] 160 |         if command.len() == 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `command.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/main.rs:163:65
[INFO] [stderr]     |
[INFO] [stderr] 163 |         let command_parts: Vec<String> = command.split(' ').map(|x| String::from(x)).collect();
[INFO] [stderr]     |                                                                 ^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `String::from`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/main.rs:187:22
[INFO] [stderr]     |
[INFO] [stderr] 187 |             command: format!("{}", command),
[INFO] [stderr]     |                      ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `command.to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 16.88s
[INFO] running `"docker" "inspect" "0b2c7c77a90c59bcf19e83b5ca67b7997ef1ef67fb954cd15d722062a18d9b82"`
[INFO] running `"docker" "rm" "-f" "0b2c7c77a90c59bcf19e83b5ca67b7997ef1ef67fb954cd15d722062a18d9b82"`
[INFO] [stdout] 0b2c7c77a90c59bcf19e83b5ca67b7997ef1ef67fb954cd15d722062a18d9b82