[INFO] updating cached repository defcronyke/rust-struct-optional-field [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/defcronyke/rust-struct-optional-field [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/defcronyke/rust-struct-optional-field" "work/ex/clippy-test-run/sources/stable/gh/defcronyke/rust-struct-optional-field"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/defcronyke/rust-struct-optional-field'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/defcronyke/rust-struct-optional-field" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/defcronyke/rust-struct-optional-field"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/defcronyke/rust-struct-optional-field'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8e1a9be00ad9c6bb799070db1c948f7463a849d7 [INFO] sha for GitHub repo defcronyke/rust-struct-optional-field: 8e1a9be00ad9c6bb799070db1c948f7463a849d7 [INFO] validating manifest of defcronyke/rust-struct-optional-field on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of defcronyke/rust-struct-optional-field on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing defcronyke/rust-struct-optional-field [INFO] finished frobbing defcronyke/rust-struct-optional-field [INFO] frobbed toml for defcronyke/rust-struct-optional-field written to work/ex/clippy-test-run/sources/stable/gh/defcronyke/rust-struct-optional-field/Cargo.toml [INFO] started frobbing defcronyke/rust-struct-optional-field [INFO] finished frobbing defcronyke/rust-struct-optional-field [INFO] frobbed toml for defcronyke/rust-struct-optional-field written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/defcronyke/rust-struct-optional-field/Cargo.toml [INFO] crate defcronyke/rust-struct-optional-field has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting defcronyke/rust-struct-optional-field against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/defcronyke/rust-struct-optional-field:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0fd06fe7376f5e75f49027da4da28c14c39d3a191da1d4612b634e3d9ff1680f [INFO] running `"docker" "start" "-a" "0fd06fe7376f5e75f49027da4da28c14c39d3a191da1d4612b634e3d9ff1680f"` [INFO] [stderr] Checking struct-test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | println!("3. Hello {}", harry.name.clone().unwrap_or("nobody".to_string())); // 3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "nobody".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:93:74 [INFO] [stderr] | [INFO] [stderr] 93 | println!("6. Hello {}", harry.name.map(|name| "Dj".to_string() + &name).unwrap_or("nobody".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "nobody".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:57:45 [INFO] [stderr] | [INFO] [stderr] 57 | println!("3. Hello {}", harry.name.clone().unwrap_or("nobody".to_string())); // 3 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "nobody".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:93:74 [INFO] [stderr] | [INFO] [stderr] 93 | println!("6. Hello {}", harry.name.map(|name| "Dj".to_string() + &name).unwrap_or("nobody".to_string())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "nobody".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.94s [INFO] running `"docker" "inspect" "0fd06fe7376f5e75f49027da4da28c14c39d3a191da1d4612b634e3d9ff1680f"` [INFO] running `"docker" "rm" "-f" "0fd06fe7376f5e75f49027da4da28c14c39d3a191da1d4612b634e3d9ff1680f"` [INFO] [stdout] 0fd06fe7376f5e75f49027da4da28c14c39d3a191da1d4612b634e3d9ff1680f