[INFO] updating cached repository deeso/dns-lookup-service [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deeso/dns-lookup-service [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deeso/dns-lookup-service" "work/ex/clippy-test-run/sources/stable/gh/deeso/dns-lookup-service"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deeso/dns-lookup-service'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deeso/dns-lookup-service" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deeso/dns-lookup-service"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deeso/dns-lookup-service'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b726307ca3213e5516bc4b225c15f5d4be2a8ea6 [INFO] sha for GitHub repo deeso/dns-lookup-service: b726307ca3213e5516bc4b225c15f5d4be2a8ea6 [INFO] validating manifest of deeso/dns-lookup-service on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deeso/dns-lookup-service on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deeso/dns-lookup-service [INFO] finished frobbing deeso/dns-lookup-service [INFO] frobbed toml for deeso/dns-lookup-service written to work/ex/clippy-test-run/sources/stable/gh/deeso/dns-lookup-service/Cargo.toml [INFO] started frobbing deeso/dns-lookup-service [INFO] finished frobbing deeso/dns-lookup-service [INFO] frobbed toml for deeso/dns-lookup-service written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deeso/dns-lookup-service/Cargo.toml [INFO] crate deeso/dns-lookup-service has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deeso/dns-lookup-service against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deeso/dns-lookup-service:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c1fb2012398048fef03d585ea222387b03d11d25f1ec6513458f2bbce8b67a32 [INFO] running `"docker" "start" "-a" "c1fb2012398048fef03d585ea222387b03d11d25f1ec6513458f2bbce8b67a32"` [INFO] [stderr] Checking toml v0.4.5 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Checking serde_json v1.0.13 [INFO] [stderr] Checking tokio-timer v0.2.0 [INFO] [stderr] Checking chrono v0.4.1 [INFO] [stderr] Checking serde_yaml v0.7.3 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.1 [INFO] [stderr] Checking serde-value v0.5.2 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking tokio-threadpool v0.1.2 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Checking data-encoding-macro v0.1.1 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Compiling mime_guess v1.8.4 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking log4rs v0.8.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio v0.1.5 [INFO] [stderr] Checking tokio-core v0.1.16 [INFO] [stderr] Checking iron v0.6.0 [INFO] [stderr] Checking router v0.6.0 [INFO] [stderr] Checking trust-dns-proto v0.2.0 [INFO] [stderr] Checking trust-dns v0.13.0 [INFO] [stderr] Checking dns-lookup-service v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | listen_host: listen_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_host` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | listen_host: listen_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_host` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | listen_port: listen_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | ip6: ip6, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ip6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | ip4: ip4, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ip4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | dns_server: dns_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dns_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | is_server: is_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:245:25 [INFO] [stderr] | [INFO] [stderr] 245 | servers: servers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `servers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | listen_port: listen_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:247:25 [INFO] [stderr] | [INFO] [stderr] 247 | listen_host: listen_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | is_server: is_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | listen_port: listen_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:273:17 [INFO] [stderr] | [INFO] [stderr] 273 | listen_host: listen_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:274:17 [INFO] [stderr] | [INFO] [stderr] 274 | is_server: is_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | time_ms: time_ms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `time_ms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | time_ms: time_ms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `time_ms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | let r = DnsLookupResults {results: results}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:138:37 [INFO] [stderr] | [INFO] [stderr] 138 | let dlr = DnsLookupResults {results: results}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:253:37 [INFO] [stderr] | [INFO] [stderr] 253 | let dlr = DnsLookupResults {results: results}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | listen_port: listen_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | ip6: ip6, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ip6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | ip4: ip4, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ip4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | dns_server: dns_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dns_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:142:9 [INFO] [stderr] | [INFO] [stderr] 142 | hostname: hostname, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | is_server: is_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:245:25 [INFO] [stderr] | [INFO] [stderr] 245 | servers: servers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `servers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:246:25 [INFO] [stderr] | [INFO] [stderr] 246 | listen_port: listen_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:247:25 [INFO] [stderr] | [INFO] [stderr] 247 | listen_host: listen_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:248:25 [INFO] [stderr] | [INFO] [stderr] 248 | is_server: is_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:272:17 [INFO] [stderr] | [INFO] [stderr] 272 | listen_port: listen_port, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:273:17 [INFO] [stderr] | [INFO] [stderr] 273 | listen_host: listen_host, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_host` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:274:17 [INFO] [stderr] | [INFO] [stderr] 274 | is_server: is_server, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:84:21 [INFO] [stderr] | [INFO] [stderr] 84 | time_ms: time_ms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `time_ms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:95:21 [INFO] [stderr] | [INFO] [stderr] 95 | time_ms: time_ms, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `time_ms` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:102:31 [INFO] [stderr] | [INFO] [stderr] 102 | let r = DnsLookupResults {results: results}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:138:37 [INFO] [stderr] | [INFO] [stderr] 138 | let dlr = DnsLookupResults {results: results}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:172:13 [INFO] [stderr] | [INFO] [stderr] 172 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | start_time: start_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `start_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:210:13 [INFO] [stderr] | [INFO] [stderr] 210 | end_time: end_time, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `end_time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lookup.rs:253:37 [INFO] [stderr] | [INFO] [stderr] 253 | let dlr = DnsLookupResults {results: results}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `results` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / return DnsServiceArgs { [INFO] [stderr] 135 | | listen_host: listen_host, [INFO] [stderr] 136 | | listen_port: listen_port, [INFO] [stderr] 137 | | config: config_file, [INFO] [stderr] ... | [INFO] [stderr] 144 | | is_server: is_server, [INFO] [stderr] 145 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 134 | DnsServiceArgs { [INFO] [stderr] 135 | listen_host: listen_host, [INFO] [stderr] 136 | listen_port: listen_port, [INFO] [stderr] 137 | config: config_file, [INFO] [stderr] 138 | log_config: log_config_file, [INFO] [stderr] 139 | ip6: ip6, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | return odscs; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `odscs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Some(DnsLookupRequest{hostname: hostname.clone()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(DnsLookupRequest{hostname: hostname.clone()})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return dlr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dlr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lookup.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | let name = Name::from_str(*&hostname).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `hostname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | / return Some(DnsLookupServices{ [INFO] [stderr] 235 | | servicers:results, [INFO] [stderr] 236 | | listen_port: dsc.listen_port.clone(), [INFO] [stderr] 237 | | listen_host: dsc.listen_host.clone(), [INFO] [stderr] 238 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 234 | Some(DnsLookupServices{ [INFO] [stderr] 235 | servicers:results, [INFO] [stderr] 236 | listen_port: dsc.listen_port.clone(), [INFO] [stderr] 237 | listen_host: dsc.listen_host.clone(), [INFO] [stderr] 238 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return dlr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dlr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(Response::with((status::Ok, json_result.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, json_result.clone())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(Response::with((status::Ok, json_result.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, json_result.clone())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | / return DnsServiceArgs { [INFO] [stderr] 135 | | listen_host: listen_host, [INFO] [stderr] 136 | | listen_port: listen_port, [INFO] [stderr] 137 | | config: config_file, [INFO] [stderr] ... | [INFO] [stderr] 144 | | is_server: is_server, [INFO] [stderr] 145 | | }; [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 134 | DnsServiceArgs { [INFO] [stderr] 135 | listen_host: listen_host, [INFO] [stderr] 136 | listen_port: listen_port, [INFO] [stderr] 137 | config: config_file, [INFO] [stderr] 138 | log_config: log_config_file, [INFO] [stderr] 139 | ip6: ip6, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:197:5 [INFO] [stderr] | [INFO] [stderr] 197 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:223:5 [INFO] [stderr] | [INFO] [stderr] 223 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | return odscs; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `odscs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:42:9 [INFO] [stderr] | [INFO] [stderr] 42 | return Some(DnsLookupRequest{hostname: hostname.clone()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(DnsLookupRequest{hostname: hostname.clone()})` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:103:5 [INFO] [stderr] | [INFO] [stderr] 103 | return r; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `r` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return dlr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dlr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:174:9 [INFO] [stderr] | [INFO] [stderr] 174 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/lookup.rs:143:35 [INFO] [stderr] | [INFO] [stderr] 143 | let name = Name::from_str(*&hostname).unwrap(); [INFO] [stderr] | ^^^^^^^^^^ help: try this: `hostname` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:212:9 [INFO] [stderr] | [INFO] [stderr] 212 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | / return Some(DnsLookupServices{ [INFO] [stderr] 235 | | servicers:results, [INFO] [stderr] 236 | | listen_port: dsc.listen_port.clone(), [INFO] [stderr] 237 | | listen_host: dsc.listen_host.clone(), [INFO] [stderr] 238 | | }) [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 234 | Some(DnsLookupServices{ [INFO] [stderr] 235 | servicers:results, [INFO] [stderr] 236 | listen_port: dsc.listen_port.clone(), [INFO] [stderr] 237 | listen_host: dsc.listen_host.clone(), [INFO] [stderr] 238 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lookup.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | return dlr; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `dlr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | return Ok(Response::with((status::Ok, json_result.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, json_result.clone())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | return Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | return Ok(Response::with((status::Ok, json_result.clone()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, json_result.clone())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webserver.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | return Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string()))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Response::with((status::Ok, UNPARSEABLE_ERROR.to_string())))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:167:34 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn read_servers_config(name: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / match o_servers { [INFO] [stderr] 176 | | &Some(servers) => { [INFO] [stderr] 177 | | for sc in servers.values() { [INFO] [stderr] 178 | | let ds_str = sc.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 192 | | [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *o_servers { [INFO] [stderr] 176 | Some(servers) => { [INFO] [stderr] 177 | for sc in servers.values() { [INFO] [stderr] 178 | let ds_str = sc.to_string(); [INFO] [stderr] 179 | let r_sc = serde_json::from_value(sc.clone()); [INFO] [stderr] 180 | match r_sc { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:200:26 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn read_config(name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:233:25 [INFO] [stderr] | [INFO] [stderr] 233 | let is_server = dsa.is_server.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dsa.is_server` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if dsa.log_config.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dsa.log_config.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:239:12 [INFO] [stderr] | [INFO] [stderr] 239 | if dsa.config.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dsa.config.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:266:22 [INFO] [stderr] | [INFO] [stderr] 266 | ip4: dsa.ip4.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dsa.ip4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:267:22 [INFO] [stderr] | [INFO] [stderr] 267 | ip6: dsa.ip6.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dsa.ip6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn from_key(hostname: &String) -> Option { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 41 | pub fn from_key(hostname: &str) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `hostname.clone()` to [INFO] [stderr] | [INFO] [stderr] 42 | return Some(DnsLookupRequest{hostname: hostname.to_string()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:67:53 [INFO] [stderr] | [INFO] [stderr] 67 | fn extract_results(dsr: &DnsServerResponse, source: &String) -> DnsLookupResults { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 67 | fn extract_results(dsr: &DnsServerResponse, source: &str) -> DnsLookupResults { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `source.clone()` to [INFO] [stderr] | [INFO] [stderr] 80 | source: source.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `source.clone()` to [INFO] [stderr] | [INFO] [stderr] 91 | source: source.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lookup.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | let time_ms = &dsr.end_time - &dsr.start_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 72 | let time_ms = dsr.end_time - dsr.start_time; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lookup.rs:73:8 [INFO] [stderr] | [INFO] [stderr] 73 | if answers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!answers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:118:35 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn check(&self, hostname: &String) -> DnsLookupResults{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:142:35 [INFO] [stderr] | [INFO] [stderr] 142 | fn check_ip4(&self, hostname: &String) -> DnsServerResponse{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / match now_epoch { [INFO] [stderr] 153 | | Ok(result) => { [INFO] [stderr] 154 | | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 155 | | }, [INFO] [stderr] 156 | | Err(_) => {} [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | if let Ok(result) = now_epoch { [INFO] [stderr] 153 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 154 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:154:56 [INFO] [stderr] | [INFO] [stderr] 154 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match now_epoch { [INFO] [stderr] 163 | | Ok(result) => { [INFO] [stderr] 164 | | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 165 | | }, [INFO] [stderr] 166 | | Err(_) => {} [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | if let Ok(result) = now_epoch { [INFO] [stderr] 163 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 164 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:164:54 [INFO] [stderr] | [INFO] [stderr] 164 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:178:35 [INFO] [stderr] | [INFO] [stderr] 178 | fn check_ip6(&self, hostname: &String) -> DnsServerResponse{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match now_epoch { [INFO] [stderr] 190 | | Ok(result) => { [INFO] [stderr] 191 | | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 192 | | }, [INFO] [stderr] 193 | | Err(_) => {} [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 189 | if let Ok(result) = now_epoch { [INFO] [stderr] 190 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 191 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:191:56 [INFO] [stderr] | [INFO] [stderr] 191 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match now_epoch { [INFO] [stderr] 201 | | Ok(result) => { [INFO] [stderr] 202 | | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 203 | | }, [INFO] [stderr] 204 | | Err(_) => {} [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | if let Ok(result) = now_epoch { [INFO] [stderr] 201 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 202 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:202:54 [INFO] [stderr] | [INFO] [stderr] 202 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lookup.rs:229:22 [INFO] [stderr] | [INFO] [stderr] 229 | ip4: c.ip4.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `c.ip4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lookup.rs:230:22 [INFO] [stderr] | [INFO] [stderr] 230 | ip6: c.ip6.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `c.ip6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn check(&self, hostname: &String) -> DnsLookupResults{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/webserver.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref hostname = request.extensions.get::().unwrap().find("hostname").unwrap_or("/"); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------------------------------------- help: try: `let hostname = &request.extensions.get::().unwrap().find("hostname").unwrap_or("/");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:167:34 [INFO] [stderr] | [INFO] [stderr] 167 | pub fn read_servers_config(name: &String) -> Option> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/config.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | / match o_servers { [INFO] [stderr] 176 | | &Some(servers) => { [INFO] [stderr] 177 | | for sc in servers.values() { [INFO] [stderr] 178 | | let ds_str = sc.to_string(); [INFO] [stderr] ... | [INFO] [stderr] 192 | | [INFO] [stderr] 193 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 175 | match *o_servers { [INFO] [stderr] 176 | Some(servers) => { [INFO] [stderr] 177 | for sc in servers.values() { [INFO] [stderr] 178 | let ds_str = sc.to_string(); [INFO] [stderr] 179 | let r_sc = serde_json::from_value(sc.clone()); [INFO] [stderr] 180 | match r_sc { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/config.rs:200:26 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn read_config(name: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:233:25 [INFO] [stderr] | [INFO] [stderr] 233 | let is_server = dsa.is_server.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dsa.is_server` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:236:12 [INFO] [stderr] | [INFO] [stderr] 236 | if dsa.log_config.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dsa.log_config.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:239:12 [INFO] [stderr] | [INFO] [stderr] 239 | if dsa.config.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!dsa.config.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:266:22 [INFO] [stderr] | [INFO] [stderr] 266 | ip4: dsa.ip4.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dsa.ip4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/config.rs:267:22 [INFO] [stderr] | [INFO] [stderr] 267 | ip6: dsa.ip6.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `dsa.ip6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:41:31 [INFO] [stderr] | [INFO] [stderr] 41 | pub fn from_key(hostname: &String) -> Option { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 41 | pub fn from_key(hostname: &str) -> Option { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `hostname.clone()` to [INFO] [stderr] | [INFO] [stderr] 42 | return Some(DnsLookupRequest{hostname: hostname.to_string()}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:67:53 [INFO] [stderr] | [INFO] [stderr] 67 | fn extract_results(dsr: &DnsServerResponse, source: &String) -> DnsLookupResults { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 67 | fn extract_results(dsr: &DnsServerResponse, source: &str) -> DnsLookupResults { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `source.clone()` to [INFO] [stderr] | [INFO] [stderr] 80 | source: source.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: change `source.clone()` to [INFO] [stderr] | [INFO] [stderr] 91 | source: source.to_string(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lookup.rs:72:19 [INFO] [stderr] | [INFO] [stderr] 72 | let time_ms = &dsr.end_time - &dsr.start_time; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 72 | let time_ms = dsr.end_time - dsr.start_time; [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lookup.rs:73:8 [INFO] [stderr] | [INFO] [stderr] 73 | if answers.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!answers.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:118:35 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn check(&self, hostname: &String) -> DnsLookupResults{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:142:35 [INFO] [stderr] | [INFO] [stderr] 142 | fn check_ip4(&self, hostname: &String) -> DnsServerResponse{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | / match now_epoch { [INFO] [stderr] 153 | | Ok(result) => { [INFO] [stderr] 154 | | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 155 | | }, [INFO] [stderr] 156 | | Err(_) => {} [INFO] [stderr] 157 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | if let Ok(result) = now_epoch { [INFO] [stderr] 153 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 154 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:154:56 [INFO] [stderr] | [INFO] [stderr] 154 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / match now_epoch { [INFO] [stderr] 163 | | Ok(result) => { [INFO] [stderr] 164 | | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 165 | | }, [INFO] [stderr] 166 | | Err(_) => {} [INFO] [stderr] 167 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 162 | if let Ok(result) = now_epoch { [INFO] [stderr] 163 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 164 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:164:54 [INFO] [stderr] | [INFO] [stderr] 164 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:178:35 [INFO] [stderr] | [INFO] [stderr] 178 | fn check_ip6(&self, hostname: &String) -> DnsServerResponse{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / match now_epoch { [INFO] [stderr] 190 | | Ok(result) => { [INFO] [stderr] 191 | | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 192 | | }, [INFO] [stderr] 193 | | Err(_) => {} [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 189 | if let Ok(result) = now_epoch { [INFO] [stderr] 190 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 191 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:191:56 [INFO] [stderr] | [INFO] [stderr] 191 | start_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lookup.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | / match now_epoch { [INFO] [stderr] 201 | | Ok(result) => { [INFO] [stderr] 202 | | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 203 | | }, [INFO] [stderr] 204 | | Err(_) => {} [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 200 | if let Ok(result) = now_epoch { [INFO] [stderr] 201 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] 202 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lookup.rs:202:54 [INFO] [stderr] | [INFO] [stderr] 202 | end_time = result.as_secs() * 1000 + result.subsec_nanos() as u64 / 1_000_000; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(result.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lookup.rs:229:22 [INFO] [stderr] | [INFO] [stderr] 229 | ip4: c.ip4.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `c.ip4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/lookup.rs:230:22 [INFO] [stderr] | [INFO] [stderr] 230 | ip6: c.ip6.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `c.ip6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/lookup.rs:241:35 [INFO] [stderr] | [INFO] [stderr] 241 | pub fn check(&self, hostname: &String) -> DnsLookupResults{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/webserver.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let ref hostname = request.extensions.get::().unwrap().find("hostname").unwrap_or("/"); [INFO] [stderr] | ----^^^^^^^^^^^^------------------------------------------------------------------------------- help: try: `let hostname = &request.extensions.get::().unwrap().find("hostname").unwrap_or("/");` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 33.09s [INFO] running `"docker" "inspect" "c1fb2012398048fef03d585ea222387b03d11d25f1ec6513458f2bbce8b67a32"` [INFO] running `"docker" "rm" "-f" "c1fb2012398048fef03d585ea222387b03d11d25f1ec6513458f2bbce8b67a32"` [INFO] [stdout] c1fb2012398048fef03d585ea222387b03d11d25f1ec6513458f2bbce8b67a32