[INFO] updating cached repository deecewan/prompt [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deecewan/prompt [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deecewan/prompt" "work/ex/clippy-test-run/sources/stable/gh/deecewan/prompt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deecewan/prompt'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deecewan/prompt" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deecewan/prompt"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deecewan/prompt'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e775e11e59cc518722ada27ac6fe2aa0cab41b74 [INFO] sha for GitHub repo deecewan/prompt: e775e11e59cc518722ada27ac6fe2aa0cab41b74 [INFO] validating manifest of deecewan/prompt on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deecewan/prompt on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deecewan/prompt [INFO] finished frobbing deecewan/prompt [INFO] frobbed toml for deecewan/prompt written to work/ex/clippy-test-run/sources/stable/gh/deecewan/prompt/Cargo.toml [INFO] started frobbing deecewan/prompt [INFO] finished frobbing deecewan/prompt [INFO] frobbed toml for deecewan/prompt written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deecewan/prompt/Cargo.toml [INFO] crate deecewan/prompt has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deecewan/prompt against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deecewan/prompt:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cda001e6d74f548c37a24121d1e431750d0c3432768940187f40b911b6216b66 [INFO] running `"docker" "start" "-a" "cda001e6d74f548c37a24121d1e431750d0c3432768940187f40b911b6216b66"` [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.7.1 [INFO] [stderr] Checking git2 v0.7.1 [INFO] [stderr] Checking prompt v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return shortened; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `shortened` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | let shortened = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or(String::from("Unknown")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("Unknown"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(head) => match head.is_branch() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 52 | | true => String::from(head.shorthand().unwrap()), [INFO] [stderr] 53 | | false => process_non_standard_head(&repo, &head), [INFO] [stderr] 54 | | }, [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if head.is_branch() { String::from(head.shorthand().unwrap()) } else { process_non_standard_head(&repo, &head) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | let keymap = env::args().nth(2).unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | return shortened; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `shortened` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:86:27 [INFO] [stderr] | [INFO] [stderr] 86 | let shortened = match env::home_dir() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or(String::from("Unknown")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("Unknown"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:51:21 [INFO] [stderr] | [INFO] [stderr] 51 | Ok(head) => match head.is_branch() { [INFO] [stderr] | _____________________^ [INFO] [stderr] 52 | | true => String::from(head.shorthand().unwrap()), [INFO] [stderr] 53 | | false => process_non_standard_head(&repo, &head), [INFO] [stderr] 54 | | }, [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if head.is_branch() { String::from(head.shorthand().unwrap()) } else { process_non_standard_head(&repo, &head) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:106:37 [INFO] [stderr] | [INFO] [stderr] 106 | let keymap = env::args().nth(2).unwrap_or(String::from("")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| String::from(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 34s [INFO] running `"docker" "inspect" "cda001e6d74f548c37a24121d1e431750d0c3432768940187f40b911b6216b66"` [INFO] running `"docker" "rm" "-f" "cda001e6d74f548c37a24121d1e431750d0c3432768940187f40b911b6216b66"` [INFO] [stdout] cda001e6d74f548c37a24121d1e431750d0c3432768940187f40b911b6216b66