[INFO] updating cached repository deecewan/dotter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deecewan/dotter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deecewan/dotter" "work/ex/clippy-test-run/sources/stable/gh/deecewan/dotter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deecewan/dotter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deecewan/dotter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deecewan/dotter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deecewan/dotter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1827754b09963a3e90ead18dee84b10ab8ca1f15 [INFO] sha for GitHub repo deecewan/dotter: 1827754b09963a3e90ead18dee84b10ab8ca1f15 [INFO] validating manifest of deecewan/dotter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deecewan/dotter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deecewan/dotter [INFO] finished frobbing deecewan/dotter [INFO] frobbed toml for deecewan/dotter written to work/ex/clippy-test-run/sources/stable/gh/deecewan/dotter/Cargo.toml [INFO] started frobbing deecewan/dotter [INFO] finished frobbing deecewan/dotter [INFO] frobbed toml for deecewan/dotter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deecewan/dotter/Cargo.toml [INFO] crate deecewan/dotter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deecewan/dotter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deecewan/dotter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a93b9dbfd524a78f35e3a94303a3477dbcfe4243885ec248fe8098ac94f91cb [INFO] running `"docker" "start" "-a" "9a93b9dbfd524a78f35e3a94303a3477dbcfe4243885ec248fe8098ac94f91cb"` [INFO] [stderr] Compiling deque v0.3.2 [INFO] [stderr] Checking untrusted v0.5.0 [INFO] [stderr] Compiling num_cpus v1.5.1 [INFO] [stderr] Checking clap v2.24.2 [INFO] [stderr] Compiling rayon-core v1.0.2 [INFO] [stderr] Compiling rayon v0.7.1 [INFO] [stderr] Compiling ring v0.11.0 [INFO] [stderr] Checking dotter v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/secure.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/secure.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checkin.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / return match stats { [INFO] [stderr] 28 | | Ok(stats) => Ok(stats.is_dir()), [INFO] [stderr] 29 | | Err(err) => Err(err), [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 27 | match stats { [INFO] [stderr] 28 | Ok(stats) => Ok(stats.is_dir()), [INFO] [stderr] 29 | Err(err) => Err(err), [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checkin.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / return Path::new(env!("HOME")) [INFO] [stderr] 40 | | .join(DEFAULT_FOLDER) // this should probably be passed in at some point [INFO] [stderr] 41 | | .join(category) [INFO] [stderr] 42 | | .join(stripped); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Path::new(env!("HOME")) [INFO] [stderr] 40 | .join(DEFAULT_FOLDER) // this should probably be passed in at some point [INFO] [stderr] 41 | .join(category) [INFO] [stderr] 42 | .join(stripped) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checkin.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return fs::canonicalize(path_maybe); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fs::canonicalize(path_maybe)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:1:30 [INFO] [stderr] | [INFO] [stderr] 1 | pub const APPLICATION_NAME: &'static str = "dotter"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | pub const DEFAULT_FOLDER: &'static str = "dotter"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `open_in_place` [INFO] [stderr] --> src/secure.rs:1:33 [INFO] [stderr] | [INFO] [stderr] 1 | use ring::aead::{seal_in_place, open_in_place, AES_256_GCM, SealingKey}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checkin.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / return match stats { [INFO] [stderr] 28 | | Ok(stats) => Ok(stats.is_dir()), [INFO] [stderr] 29 | | Err(err) => Err(err), [INFO] [stderr] 30 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 27 | match stats { [INFO] [stderr] 28 | Ok(stats) => Ok(stats.is_dir()), [INFO] [stderr] 29 | Err(err) => Err(err), [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checkin.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / return Path::new(env!("HOME")) [INFO] [stderr] 40 | | .join(DEFAULT_FOLDER) // this should probably be passed in at some point [INFO] [stderr] 41 | | .join(category) [INFO] [stderr] 42 | | .join(stripped); [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | Path::new(env!("HOME")) [INFO] [stderr] 40 | .join(DEFAULT_FOLDER) // this should probably be passed in at some point [INFO] [stderr] 41 | .join(category) [INFO] [stderr] 42 | .join(stripped) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/checkin.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return fs::canonicalize(path_maybe); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `fs::canonicalize(path_maybe)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:1:30 [INFO] [stderr] | [INFO] [stderr] 1 | pub const APPLICATION_NAME: &'static str = "dotter"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/config.rs:2:28 [INFO] [stderr] | [INFO] [stderr] 2 | pub const DEFAULT_FOLDER: &'static str = "dotter"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused import: `open_in_place` [INFO] [stderr] --> src/secure.rs:1:33 [INFO] [stderr] | [INFO] [stderr] 1 | use ring::aead::{seal_in_place, open_in_place, AES_256_GCM, SealingKey}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/checkin.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let res = fs::copy(entry.path(), item_path); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/checkin.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | let res = fs::create_dir(item_path); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/checkin.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | let res = unix::fs::symlink(new_path, path); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/secure.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let res = random_nonce.fill(&mut nonce); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/secure.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn secure(matches: &ArgMatches) { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/checkin.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | print_error(format!("Couldn't find a parent directory for that file!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Couldn't find a parent directory for that file!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/checkin.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / let res; [INFO] [stderr] 117 | | if is_dir { [INFO] [stderr] 118 | | res = fs::remove_dir_all(path); [INFO] [stderr] 119 | | } else { [INFO] [stderr] 120 | | res = fs::remove_file(path); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if is_dir { fs::remove_dir_all(path) } else { fs::remove_file(path) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/init.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | fn make_dir(location: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/secure.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | for i in nonce.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/checkin.rs:106:21 [INFO] [stderr] | [INFO] [stderr] 106 | let res = fs::copy(entry.path(), item_path); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/checkin.rs:108:21 [INFO] [stderr] | [INFO] [stderr] 108 | let res = fs::create_dir(item_path); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/checkin.rs:134:9 [INFO] [stderr] | [INFO] [stderr] 134 | let res = unix::fs::symlink(new_path, path); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/secure.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | let res = random_nonce.fill(&mut nonce); [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `matches` [INFO] [stderr] --> src/secure.rs:5:15 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn secure(matches: &ArgMatches) { [INFO] [stderr] | ^^^^^^^ help: consider using `_matches` instead [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/checkin.rs:72:25 [INFO] [stderr] | [INFO] [stderr] 72 | print_error(format!("Couldn't find a parent directory for that file!")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Couldn't find a parent directory for that file!".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/checkin.rs:116:5 [INFO] [stderr] | [INFO] [stderr] 116 | / let res; [INFO] [stderr] 117 | | if is_dir { [INFO] [stderr] 118 | | res = fs::remove_dir_all(path); [INFO] [stderr] 119 | | } else { [INFO] [stderr] 120 | | res = fs::remove_file(path); [INFO] [stderr] 121 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let res = if is_dir { fs::remove_dir_all(path) } else { fs::remove_file(path) };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/init.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | fn make_dir(location: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/secure.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | for i in nonce.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.36s [INFO] running `"docker" "inspect" "9a93b9dbfd524a78f35e3a94303a3477dbcfe4243885ec248fe8098ac94f91cb"` [INFO] running `"docker" "rm" "-f" "9a93b9dbfd524a78f35e3a94303a3477dbcfe4243885ec248fe8098ac94f91cb"` [INFO] [stdout] 9a93b9dbfd524a78f35e3a94303a3477dbcfe4243885ec248fe8098ac94f91cb