[INFO] updating cached repository deebloo/brain-games-rust [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deebloo/brain-games-rust [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deebloo/brain-games-rust" "work/ex/clippy-test-run/sources/stable/gh/deebloo/brain-games-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deebloo/brain-games-rust'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deebloo/brain-games-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deebloo/brain-games-rust"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deebloo/brain-games-rust'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 87685eb4325718e46005efce6039eb50e172c748 [INFO] sha for GitHub repo deebloo/brain-games-rust: 87685eb4325718e46005efce6039eb50e172c748 [INFO] validating manifest of deebloo/brain-games-rust on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deebloo/brain-games-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deebloo/brain-games-rust [INFO] finished frobbing deebloo/brain-games-rust [INFO] frobbed toml for deebloo/brain-games-rust written to work/ex/clippy-test-run/sources/stable/gh/deebloo/brain-games-rust/Cargo.toml [INFO] started frobbing deebloo/brain-games-rust [INFO] finished frobbing deebloo/brain-games-rust [INFO] frobbed toml for deebloo/brain-games-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deebloo/brain-games-rust/Cargo.toml [INFO] crate deebloo/brain-games-rust has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deebloo/brain-games-rust against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deebloo/brain-games-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1cebe79784ad2ff74195bcab2d46ebc6746619263bd1e897eb3e74e6bbc1ab0f [INFO] running `"docker" "start" "-a" "1cebe79784ad2ff74195bcab2d46ebc6746619263bd1e897eb3e74e6bbc1ab0f"` [INFO] [stderr] Checking rust-xo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | index = index + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/bot.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | if let Some(_) = index { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 30 | | board.set_by_index(self.player.player_space, index.unwrap()); [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________- help: try this: `if index.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/board.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | index = index + 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `index += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/bot.rs:29:16 [INFO] [stderr] | [INFO] [stderr] 29 | if let Some(_) = index { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 30 | | board.set_by_index(self.player.player_space, index.unwrap()); [INFO] [stderr] 31 | | } [INFO] [stderr] | |_________- help: try this: `if index.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:26:20 [INFO] [stderr] | [INFO] [stderr] 26 | .split(",") [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `"docker" "inspect" "1cebe79784ad2ff74195bcab2d46ebc6746619263bd1e897eb3e74e6bbc1ab0f"` [INFO] running `"docker" "rm" "-f" "1cebe79784ad2ff74195bcab2d46ebc6746619263bd1e897eb3e74e6bbc1ab0f"` [INFO] [stdout] 1cebe79784ad2ff74195bcab2d46ebc6746619263bd1e897eb3e74e6bbc1ab0f