[INFO] updating cached repository deciduously/ar-bot [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deciduously/ar-bot [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deciduously/ar-bot" "work/ex/clippy-test-run/sources/stable/gh/deciduously/ar-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deciduously/ar-bot'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deciduously/ar-bot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deciduously/ar-bot"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deciduously/ar-bot'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 824c07024e36dfc46ecfd87e5178dca9590726e4 [INFO] sha for GitHub repo deciduously/ar-bot: 824c07024e36dfc46ecfd87e5178dca9590726e4 [INFO] validating manifest of deciduously/ar-bot on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deciduously/ar-bot on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deciduously/ar-bot [INFO] finished frobbing deciduously/ar-bot [INFO] frobbed toml for deciduously/ar-bot written to work/ex/clippy-test-run/sources/stable/gh/deciduously/ar-bot/Cargo.toml [INFO] started frobbing deciduously/ar-bot [INFO] finished frobbing deciduously/ar-bot [INFO] frobbed toml for deciduously/ar-bot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deciduously/ar-bot/Cargo.toml [INFO] crate deciduously/ar-bot has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deciduously/ar-bot against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deciduously/ar-bot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65d42b199cf0f75b8300c50fea9141e6a6c540efa04ab30fa0948e3fac73c6b9 [INFO] running `"docker" "start" "-a" "65d42b199cf0f75b8300c50fea9141e6a6c540efa04ab30fa0948e3fac73c6b9"` [INFO] [stderr] Compiling nom v4.0.0 [INFO] [stderr] Compiling toml v0.4.6 [INFO] [stderr] Checking env_logger v0.5.11 [INFO] [stderr] Checking askama_shared v0.7.1 [INFO] [stderr] Checking pretty_env_logger v0.2.4 [INFO] [stderr] Compiling askama_derive v0.7.1 [INFO] [stderr] Compiling askama v0.7.1 [INFO] [stderr] Compiling ar-bot v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ReportTemplate` [INFO] [stderr] --> src/page.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | struct ReportTemplate<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SkelTemplate` [INFO] [stderr] --> src/page.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | struct SkelTemplate {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ReportTemplate` [INFO] [stderr] --> src/page.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | struct ReportTemplate<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `SkelTemplate` [INFO] [stderr] --> src/page.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | struct SkelTemplate {} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/batch.rs:131:29 [INFO] [stderr] | [INFO] [stderr] 131 | entries.entry(e.id).or_insert(BatchEntry::from(e)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| BatchEntry::from(e))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/batch.rs:134:14 [INFO] [stderr] | [INFO] [stderr] 134 | .or_insert(BatchEntry::from(e_second)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| BatchEntry::from(e_second))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/batch.rs:356:14 [INFO] [stderr] | [INFO] [stderr] 356 | .or_insert(vec![test_time.clone()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![test_time.clone()])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/batch.rs:359:14 [INFO] [stderr] | [INFO] [stderr] 359 | .or_insert(vec![test_time.clone()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![test_time.clone()])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/email.rs:45:23 [INFO] [stderr] | [INFO] [stderr] 45 | filename: format!("Saturday, July 21, 2018 4:39 PM.html"), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Saturday, July 21, 2018 4:39 PM.html".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.66s [INFO] running `"docker" "inspect" "65d42b199cf0f75b8300c50fea9141e6a6c540efa04ab30fa0948e3fac73c6b9"` [INFO] running `"docker" "rm" "-f" "65d42b199cf0f75b8300c50fea9141e6a6c540efa04ab30fa0948e3fac73c6b9"` [INFO] [stdout] 65d42b199cf0f75b8300c50fea9141e6a6c540efa04ab30fa0948e3fac73c6b9